Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: aws_memorydb_user #22261

Merged
merged 4 commits into from
Dec 20, 2021
Merged

Conversation

roberth-k
Copy link
Contributor

@roberth-k roberth-k commented Dec 16, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #20631

Depends on PR #22256

Output from acceptance testing:

$ make testacc PKG=memorydb TESTS=TestAccUser_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/memorydb/... -v -count 1 -parallel 20 -run='TestAccUser_' -timeout 180m
=== RUN   TestAccUser_basic
=== PAUSE TestAccUser_basic
=== RUN   TestAccUser_disappears
=== PAUSE TestAccUser_disappears
=== RUN   TestAccUser_update_accessString
=== PAUSE TestAccUser_update_accessString
=== RUN   TestAccUser_update_passwords
=== PAUSE TestAccUser_update_passwords
=== RUN   TestAccUser_update_tags
=== PAUSE TestAccUser_update_tags
=== CONT  TestAccUser_basic
=== CONT  TestAccUser_update_passwords
=== CONT  TestAccUser_update_accessString
=== CONT  TestAccUser_disappears
=== CONT  TestAccUser_update_tags
--- PASS: TestAccUser_basic (70.81s)
--- PASS: TestAccUser_update_tags (74.31s)
--- PASS: TestAccUser_disappears (76.66s)
--- PASS: TestAccUser_update_accessString (135.37s)
--- PASS: TestAccUser_update_passwords (192.94s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/memorydb   194.847s

@roberth-k roberth-k changed the title F aws memorydb user New Resource: aws_memorydb_user Dec 16, 2021
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. generators Relates to code generators. provider Pertains to the provider itself, rather than any interaction with AWS. service/memorydb Issues and PRs that pertain to the memorydb service. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 16, 2021
@roberth-k roberth-k force-pushed the f-aws_memorydb_user branch 5 times, most recently from e677226 to 46714ff Compare December 16, 2021 23:05
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 17, 2021
@github-actions github-actions bot removed tags Pertains to resource tagging. generators Relates to code generators. labels Dec 20, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc PKG=memorydb TESTS=TestAccMemoryDBUser_ ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/memorydb/... -v -count 1 -parallel 2 -run='TestAccMemoryDBUser_' -timeout 180m
=== RUN   TestAccMemoryDBUser_basic
=== PAUSE TestAccMemoryDBUser_basic
=== RUN   TestAccMemoryDBUser_disappears
=== PAUSE TestAccMemoryDBUser_disappears
=== RUN   TestAccMemoryDBUser_update_accessString
=== PAUSE TestAccMemoryDBUser_update_accessString
=== RUN   TestAccMemoryDBUser_update_passwords
=== PAUSE TestAccMemoryDBUser_update_passwords
=== RUN   TestAccMemoryDBUser_update_tags
=== PAUSE TestAccMemoryDBUser_update_tags
=== CONT  TestAccMemoryDBUser_basic
=== CONT  TestAccMemoryDBUser_update_tags
--- PASS: TestAccMemoryDBUser_basic (36.51s)
=== CONT  TestAccMemoryDBUser_update_passwords
--- PASS: TestAccMemoryDBUser_update_tags (107.87s)
=== CONT  TestAccMemoryDBUser_update_accessString
--- PASS: TestAccMemoryDBUser_update_passwords (187.96s)
=== CONT  TestAccMemoryDBUser_disappears
--- PASS: TestAccMemoryDBUser_update_accessString (119.39s)
--- PASS: TestAccMemoryDBUser_disappears (74.60s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/memorydb	303.694s
GovCloud
% make testacc PKG=memorydb TESTS=TestAccMemoryDBUser_ ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/memorydb/... -v -count 1 -parallel 2 -run='TestAccMemoryDBUser_' -timeout 180m
=== RUN   TestAccMemoryDBUser_basic
=== PAUSE TestAccMemoryDBUser_basic
=== RUN   TestAccMemoryDBUser_disappears
=== PAUSE TestAccMemoryDBUser_disappears
=== RUN   TestAccMemoryDBUser_update_accessString
=== PAUSE TestAccMemoryDBUser_update_accessString
=== RUN   TestAccMemoryDBUser_update_passwords
=== PAUSE TestAccMemoryDBUser_update_passwords
=== RUN   TestAccMemoryDBUser_update_tags
=== PAUSE TestAccMemoryDBUser_update_tags
=== CONT  TestAccMemoryDBUser_basic
=== CONT  TestAccMemoryDBUser_update_passwords
=== CONT  TestAccMemoryDBUser_basic
    subnet_group_test.go:25: MemoryDB is not supported in aws-us-gov partition
=== CONT  TestAccMemoryDBUser_update_passwords
    subnet_group_test.go:25: MemoryDB is not supported in aws-us-gov partition
--- SKIP: TestAccMemoryDBUser_basic (1.43s)
=== CONT  TestAccMemoryDBUser_update_tags
--- SKIP: TestAccMemoryDBUser_update_passwords (1.43s)
=== CONT  TestAccMemoryDBUser_update_accessString
=== CONT  TestAccMemoryDBUser_update_tags
    subnet_group_test.go:25: MemoryDB is not supported in aws-us-gov partition
--- SKIP: TestAccMemoryDBUser_update_tags (0.00s)
=== CONT  TestAccMemoryDBUser_disappears
    subnet_group_test.go:25: MemoryDB is not supported in aws-us-gov partition
--- SKIP: TestAccMemoryDBUser_disappears (0.00s)
=== CONT  TestAccMemoryDBUser_update_accessString
    subnet_group_test.go:25: MemoryDB is not supported in aws-us-gov partition
--- SKIP: TestAccMemoryDBUser_update_accessString (0.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/memorydb	6.179s

@ewbankkit
Copy link
Contributor

@roberth-k Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 3af99d7 into hashicorp:main Dec 20, 2021
@github-actions github-actions bot added this to the v3.71.0 milestone Dec 20, 2021
@github-actions
Copy link

github-actions bot commented Jan 6, 2022

This functionality has been released in v3.71.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@roberth-k roberth-k deleted the f-aws_memorydb_user branch January 16, 2022 20:23
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/memorydb Issues and PRs that pertain to the memorydb service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants