Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/codebuild_resource_policy - new resource #22196

Merged
merged 7 commits into from
Jan 3, 2022

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Dec 13, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #22191

Output from acceptance testing:

$ make testacc TESTS=TestAccCodeBuildResourcePolicy_ PKG=codebuild
--- PASS: TestAccCodeBuildResourcePolicy_disappears_resource (70.65s)
--- PASS: TestAccCodeBuildResourcePolicy_disappears (73.32s)
--- PASS: TestAccCodeBuildResourcePolicy_basic (83.01s)

@DrFaust92 DrFaust92 changed the title r/code_build_resource_policy - new resource r/codebuild_resource_policy - new resource Dec 13, 2021
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/codebuild Issues and PRs that pertain to the codebuild service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Dec 13, 2021
@DrFaust92 DrFaust92 added the new-resource Introduces a new resource. label Dec 13, 2021
@DrFaust92 DrFaust92 marked this pull request as ready for review December 24, 2021 23:22
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccCodeBuildResourcePolicy_ PKG=codebuild
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/codebuild/... -v -count 1 -parallel 20 -run='TestAccCodeBuildResourcePolicy_' -timeout 180m
=== RUN   TestAccCodeBuildResourcePolicy_basic
=== PAUSE TestAccCodeBuildResourcePolicy_basic
=== RUN   TestAccCodeBuildResourcePolicy_disappears
=== PAUSE TestAccCodeBuildResourcePolicy_disappears
=== RUN   TestAccCodeBuildResourcePolicy_disappears_resource
=== PAUSE TestAccCodeBuildResourcePolicy_disappears_resource
=== CONT  TestAccCodeBuildResourcePolicy_basic
=== CONT  TestAccCodeBuildResourcePolicy_disappears_resource
=== CONT  TestAccCodeBuildResourcePolicy_disappears
--- PASS: TestAccCodeBuildResourcePolicy_disappears_resource (17.40s)
--- PASS: TestAccCodeBuildResourcePolicy_disappears (19.28s)
--- PASS: TestAccCodeBuildResourcePolicy_basic (21.79s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/codebuild	27.271s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit c10060c into hashicorp:main Jan 3, 2022
@github-actions github-actions bot added this to the v3.71.0 milestone Jan 3, 2022
@github-actions
Copy link

github-actions bot commented Jan 6, 2022

This functionality has been released in v3.71.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@DrFaust92 DrFaust92 deleted the r/code_build_resource_policy branch February 12, 2022 12:50
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/codebuild Issues and PRs that pertain to the codebuild service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Codebuild - add support for resource policy for projects and report groups
2 participants