Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSx Backup Volume addition #21960

Merged
merged 6 commits into from
Dec 10, 2021

Conversation

awsaxeman
Copy link
Contributor

@awsaxeman awsaxeman commented Nov 30, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #20778

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccFSxBackup' PKG_NAME=internal/service/fsx

--- PASS: TestAccFSxBackup_disappears (539.93s)
--- PASS: TestAccFSxBackup_basic (555.49s)
--- PASS: TestAccFSxBackup_Disappears_filesystem (558.67s)
--- PASS: TestAccFSxBackup_implicitTags (777.16s)
--- PASS: TestAccFSxBackup_tags (818.30s)
--- PASS: TestAccFSxBackup_ontapBasic (1845.21s)
--- PASS: TestAccFSxBackup_windowsBasic (3119.09s)
...

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/fsx Issues and PRs that pertain to the fsx service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 30, 2021
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Nov 30, 2021
@awsaxeman awsaxeman changed the title [WIP] FSx Backup Volume addition FSx Backup Volume addition Dec 1, 2021
@awsaxeman awsaxeman marked this pull request as ready for review December 1, 2021 16:15
Copy link
Collaborator

@DrFaust92 DrFaust92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment otherwise LGTM

internal/service/fsx/backup_test.go Outdated Show resolved Hide resolved
@DrFaust92 DrFaust92 added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 2, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccFSxBackup' PKG_NAME=internal/service/fsx
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/fsx/... -v -count 1 -parallel 20 -run=TestAccFSxBackup -timeout 180m
=== RUN   TestAccFSxBackup_basic
=== PAUSE TestAccFSxBackup_basic
=== RUN   TestAccFSxBackup_ontapBasic
=== PAUSE TestAccFSxBackup_ontapBasic
=== RUN   TestAccFSxBackup_windowsBasic
=== PAUSE TestAccFSxBackup_windowsBasic
=== RUN   TestAccFSxBackup_disappears
=== PAUSE TestAccFSxBackup_disappears
=== RUN   TestAccFSxBackup_Disappears_filesystem
=== PAUSE TestAccFSxBackup_Disappears_filesystem
=== RUN   TestAccFSxBackup_tags
=== PAUSE TestAccFSxBackup_tags
=== RUN   TestAccFSxBackup_implicitTags
=== PAUSE TestAccFSxBackup_implicitTags
=== CONT  TestAccFSxBackup_basic
=== CONT  TestAccFSxBackup_Disappears_filesystem
=== CONT  TestAccFSxBackup_ontapBasic
=== CONT  TestAccFSxBackup_tags
=== CONT  TestAccFSxBackup_windowsBasic
=== CONT  TestAccFSxBackup_implicitTags
=== CONT  TestAccFSxBackup_disappears
--- PASS: TestAccFSxBackup_tags (720.33s)
--- PASS: TestAccFSxBackup_implicitTags (812.38s)
--- PASS: TestAccFSxBackup_Disappears_filesystem (820.87s)
--- PASS: TestAccFSxBackup_basic (865.04s)
--- PASS: TestAccFSxBackup_disappears (884.24s)
--- PASS: TestAccFSxBackup_ontapBasic (3169.28s)
--- PASS: TestAccFSxBackup_windowsBasic (3578.05s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fsx	3581.646s

@ewbankkit
Copy link
Contributor

@awsaxeman Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 16dc650 into hashicorp:main Dec 10, 2021
@github-actions github-actions bot added this to the v3.70.0 milestone Dec 10, 2021
@github-actions
Copy link

This functionality has been released in v3.70.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 1, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2022
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. partner Contribution from a partner. service/fsx Issues and PRs that pertain to the fsx service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Amazon FSx for NetApp ONTAP
4 participants