Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple rules in ECR replication configuration #21898

Closed
ghost opened this issue Nov 24, 2021 · 2 comments · Fixed by #22281
Closed

Multiple rules in ECR replication configuration #21898

ghost opened this issue Nov 24, 2021 · 2 comments · Fixed by #22281
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ecr Issues and PRs that pertain to the ecr service. service/sts Issues and PRs that pertain to the sts service.

Comments

@ghost
Copy link

ghost commented Nov 24, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

ECR now supports up to 10 rules and 25 destinations per rule. Support passing in multiple rules.

New or Affected Resource(s)

  • aws_ecr_replication_configuration

Potential Terraform Configuration

data "aws_caller_identity" "current" {}

resource "aws_ecr_replication_configuration" "example" {
  replication_configuration {
    rule {
      destination {
        region      = "us-west-1"
        registry_id = data.aws_caller_identity.current.account_id
      }

      destination {
        region      = "us-west-2"
        registry_id = data.aws_caller_identity.current.account_id
      }
    }

    rule {
      destination {
        region      = "us-west-1"
        registry_id = "111122223333"
      }

      destination {
        region      = "us-west-2"
        registry_id = "111122223333"
      }
    }
  }
}

References

https://docs.aws.amazon.com/AmazonECR/latest/userguide/registry-settings-examples.html#registry-settings-examples-multiple-rules

@ghost ghost added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 24, 2021
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/ecr Issues and PRs that pertain to the ecr service. service/sts Issues and PRs that pertain to the sts service. labels Nov 24, 2021
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Dec 9, 2021
@sjonpaulbrown
Copy link

I have worked on this and created the following #22281

This request requires small changes to the schema of the resource so that the limits match that of the AWS API.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ecr Issues and PRs that pertain to the ecr service. service/sts Issues and PRs that pertain to the sts service.
Projects
None yet
2 participants