Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource aws_ses_email_dkim #21672

Closed
pikkemans opened this issue Nov 8, 2021 · 4 comments · Fixed by #27260
Closed

New resource aws_ses_email_dkim #21672

pikkemans opened this issue Nov 8, 2021 · 4 comments · Fixed by #27260
Labels
documentation Introduces or discusses updates to documentation. service/ses Issues and PRs that pertain to the ses service.
Milestone

Comments

@pikkemans
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

In addition of the aws_ses_domain_dkim resource also provide a aws_ses_email_dkim resource to enable DKIM for an email identity. As a result the dkim_tokens can be used to setup the route53 records.

New or Affected Resource(s)

  • aws_ses_email_dkim

Potential Terraform Configuration

resource "aws_ses_email_identity" "example" {
  email = "[email protected]"
}

resource "aws_ses_email_dkim" "example" {
  email = aws_ses_email_identity.example.email
}

resource "aws_route53_record" "example_amazonses_dkim_record" {
  count   = 3
  zone_id = "ABCDEFGHIJ123"
  name    = "${element(aws_ses_email_dkim.example.dkim_tokens, count.index)}._domainkey"
  type    = "CNAME"
  ttl     = "600"
  records = ["${element(aws_ses_email_dkim.example.dkim_tokens, count.index)}.dkim.amazonses.com"]
}
@pikkemans pikkemans added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 8, 2021
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/route53 Issues and PRs that pertain to the route53 service. service/ses Issues and PRs that pertain to the ses service. labels Nov 8, 2021
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 10, 2021
@bruno-yamada
Copy link

bruno-yamada commented Dec 1, 2021

Something worth noting,

  • easy DKIM is a DKIM implementation, a feature provided by aws, it is domain wide
  • meaning the e-mail DKIM for [email protected] has the same value as domain DKIM for example.com
  • e-mail DKIM is not available through the AWS console UI anymore, only domain DKIM

So it would make sense to not have this resource added, and instead have some note on the documentation regarding how it works

@pikkemans
Copy link
Author

I agree with you @bruno-yamada. It's also not part of the AWS CLI v2.

@DrFaust92 DrFaust92 added documentation Introduces or discusses updates to documentation. and removed enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. service/route53 Issues and PRs that pertain to the route53 service. labels Apr 12, 2022
@github-actions github-actions bot added this to the v4.37.0 milestone Oct 24, 2022
@github-actions
Copy link

This functionality has been released in v4.37.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/ses Issues and PRs that pertain to the ses service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants