Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: CloudFront response headers policies #21620

Merged
merged 24 commits into from
Nov 4, 2021
Merged

Feature: CloudFront response headers policies #21620

merged 24 commits into from
Nov 4, 2021

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Nov 3, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #21613.

Output from acceptance testing:

Commercial

% make testacc PKG_NAME=internal/service/cloudfront TESTARGS='-run=TestAccAWSCloudFrontResponseHeadersPolicy_\|TestAccAWSCloudFrontDataSourceResponseHeadersPolicy_\|TestAccCloudFrontDistribution_'                                         
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudfront/... -v -count 1 -parallel 20 -run=TestAccAWSCloudFrontResponseHeadersPolicy_\|TestAccAWSCloudFrontDataSourceResponseHeadersPolicy_\|TestAccCloudFrontDistribution_ -timeout 180m
=== RUN   TestAccCloudFrontDistribution_disappears
=== PAUSE TestAccCloudFrontDistribution_disappears
=== RUN   TestAccCloudFrontDistribution_s3Origin
=== PAUSE TestAccCloudFrontDistribution_s3Origin
=== RUN   TestAccCloudFrontDistribution_s3OriginWithTags
=== PAUSE TestAccCloudFrontDistribution_s3OriginWithTags
=== RUN   TestAccCloudFrontDistribution_customOrigin
=== PAUSE TestAccCloudFrontDistribution_customOrigin
=== RUN   TestAccCloudFrontDistribution_originPolicyDefault
=== PAUSE TestAccCloudFrontDistribution_originPolicyDefault
=== RUN   TestAccCloudFrontDistribution_originPolicyOrdered
=== PAUSE TestAccCloudFrontDistribution_originPolicyOrdered
=== RUN   TestAccCloudFrontDistribution_multiOrigin
=== PAUSE TestAccCloudFrontDistribution_multiOrigin
=== RUN   TestAccCloudFrontDistribution_orderedCacheBehavior
=== PAUSE TestAccCloudFrontDistribution_orderedCacheBehavior
=== RUN   TestAccCloudFrontDistribution_orderedCacheBehaviorCachePolicy
=== PAUSE TestAccCloudFrontDistribution_orderedCacheBehaviorCachePolicy
=== RUN   TestAccCloudFrontDistribution_orderedCacheBehaviorResponseHeadersPolicy
=== PAUSE TestAccCloudFrontDistribution_orderedCacheBehaviorResponseHeadersPolicy
=== RUN   TestAccCloudFrontDistribution_forwardedValuesToCachePolicy
=== PAUSE TestAccCloudFrontDistribution_forwardedValuesToCachePolicy
=== RUN   TestAccCloudFrontDistribution_Origin_emptyDomainName
=== PAUSE TestAccCloudFrontDistribution_Origin_emptyDomainName
=== RUN   TestAccCloudFrontDistribution_Origin_emptyOriginID
=== PAUSE TestAccCloudFrontDistribution_Origin_emptyOriginID
=== RUN   TestAccCloudFrontDistribution_Origin_connectionAttempts
=== PAUSE TestAccCloudFrontDistribution_Origin_connectionAttempts
=== RUN   TestAccCloudFrontDistribution_Origin_connectionTimeout
=== PAUSE TestAccCloudFrontDistribution_Origin_connectionTimeout
=== RUN   TestAccCloudFrontDistribution_Origin_originShield
=== PAUSE TestAccCloudFrontDistribution_Origin_originShield
=== RUN   TestAccCloudFrontDistribution_noOptionalItems
=== PAUSE TestAccCloudFrontDistribution_noOptionalItems
=== RUN   TestAccCloudFrontDistribution_http11
=== PAUSE TestAccCloudFrontDistribution_http11
=== RUN   TestAccCloudFrontDistribution_isIPV6Enabled
=== PAUSE TestAccCloudFrontDistribution_isIPV6Enabled
=== RUN   TestAccCloudFrontDistribution_noCustomErrorResponse
=== PAUSE TestAccCloudFrontDistribution_noCustomErrorResponse
=== RUN   TestAccCloudFrontDistribution_DefaultCacheBehaviorForwardedValuesCookies_whitelistedNames
=== PAUSE TestAccCloudFrontDistribution_DefaultCacheBehaviorForwardedValuesCookies_whitelistedNames
=== RUN   TestAccCloudFrontDistribution_DefaultCacheBehaviorForwardedValues_headers
=== PAUSE TestAccCloudFrontDistribution_DefaultCacheBehaviorForwardedValues_headers
=== RUN   TestAccCloudFrontDistribution_DefaultCacheBehavior_trustedKeyGroups
=== PAUSE TestAccCloudFrontDistribution_DefaultCacheBehavior_trustedKeyGroups
=== RUN   TestAccCloudFrontDistribution_DefaultCacheBehavior_trustedSigners
=== PAUSE TestAccCloudFrontDistribution_DefaultCacheBehavior_trustedSigners
=== RUN   TestAccCloudFrontDistribution_DefaultCacheBehavior_realtimeLogARN
=== PAUSE TestAccCloudFrontDistribution_DefaultCacheBehavior_realtimeLogARN
=== RUN   TestAccCloudFrontDistribution_OrderedCacheBehavior_realtimeLogARN
=== PAUSE TestAccCloudFrontDistribution_OrderedCacheBehavior_realtimeLogARN
=== RUN   TestAccCloudFrontDistribution_enabled
=== PAUSE TestAccCloudFrontDistribution_enabled
=== RUN   TestAccCloudFrontDistribution_retainOnDelete
=== PAUSE TestAccCloudFrontDistribution_retainOnDelete
=== RUN   TestAccCloudFrontDistribution_OrderedCacheBehaviorForwardedValuesCookies_whitelistedNames
=== PAUSE TestAccCloudFrontDistribution_OrderedCacheBehaviorForwardedValuesCookies_whitelistedNames
=== RUN   TestAccCloudFrontDistribution_OrderedCacheBehaviorForwardedValues_headers
=== PAUSE TestAccCloudFrontDistribution_OrderedCacheBehaviorForwardedValues_headers
=== RUN   TestAccCloudFrontDistribution_ViewerCertificate_acmCertificateARN
=== PAUSE TestAccCloudFrontDistribution_ViewerCertificate_acmCertificateARN
=== RUN   TestAccCloudFrontDistribution_ViewerCertificateACMCertificateARN_conflictsWithCloudFrontDefaultCertificate
=== PAUSE TestAccCloudFrontDistribution_ViewerCertificateACMCertificateARN_conflictsWithCloudFrontDefaultCertificate
=== RUN   TestAccCloudFrontDistribution_waitForDeployment
=== PAUSE TestAccCloudFrontDistribution_waitForDeployment
=== RUN   TestAccCloudFrontDistribution_originGroups
=== PAUSE TestAccCloudFrontDistribution_originGroups
=== RUN   TestAccAWSCloudFrontDataSourceResponseHeadersPolicy_basic
=== PAUSE TestAccAWSCloudFrontDataSourceResponseHeadersPolicy_basic
=== RUN   TestAccAWSCloudFrontResponseHeadersPolicy_CorsConfig
=== PAUSE TestAccAWSCloudFrontResponseHeadersPolicy_CorsConfig
=== RUN   TestAccAWSCloudFrontResponseHeadersPolicy_CustomHeadersConfig
=== PAUSE TestAccAWSCloudFrontResponseHeadersPolicy_CustomHeadersConfig
=== RUN   TestAccAWSCloudFrontResponseHeadersPolicy_SecurityHeadersConfig
=== PAUSE TestAccAWSCloudFrontResponseHeadersPolicy_SecurityHeadersConfig
=== RUN   TestAccAWSCloudFrontResponseHeadersPolicy_disappears
=== PAUSE TestAccAWSCloudFrontResponseHeadersPolicy_disappears
=== CONT  TestAccCloudFrontDistribution_disappears
=== CONT  TestAccCloudFrontDistribution_DefaultCacheBehaviorForwardedValuesCookies_whitelistedNames
=== CONT  TestAccCloudFrontDistribution_ViewerCertificate_acmCertificateARN
=== CONT  TestAccAWSCloudFrontResponseHeadersPolicy_CorsConfig
=== CONT  TestAccCloudFrontDistribution_DefaultCacheBehavior_realtimeLogARN
=== CONT  TestAccCloudFrontDistribution_DefaultCacheBehavior_trustedSigners
=== CONT  TestAccCloudFrontDistribution_DefaultCacheBehavior_trustedKeyGroups
=== CONT  TestAccCloudFrontDistribution_OrderedCacheBehavior_realtimeLogARN
=== CONT  TestAccCloudFrontDistribution_OrderedCacheBehaviorForwardedValues_headers
=== CONT  TestAccCloudFrontDistribution_OrderedCacheBehaviorForwardedValuesCookies_whitelistedNames
=== CONT  TestAccCloudFrontDistribution_retainOnDelete
=== CONT  TestAccCloudFrontDistribution_DefaultCacheBehaviorForwardedValues_headers
=== CONT  TestAccCloudFrontDistribution_originGroups
=== CONT  TestAccCloudFrontDistribution_enabled
=== CONT  TestAccAWSCloudFrontDataSourceResponseHeadersPolicy_basic
=== CONT  TestAccCloudFrontDistribution_forwardedValuesToCachePolicy
=== CONT  TestAccCloudFrontDistribution_waitForDeployment
=== CONT  TestAccCloudFrontDistribution_noCustomErrorResponse
=== CONT  TestAccCloudFrontDistribution_originPolicyOrdered
=== CONT  TestAccCloudFrontDistribution_isIPV6Enabled
--- PASS: TestAccAWSCloudFrontDataSourceResponseHeadersPolicy_basic (32.42s)
=== CONT  TestAccCloudFrontDistribution_http11
--- PASS: TestAccAWSCloudFrontResponseHeadersPolicy_CorsConfig (48.14s)
=== CONT  TestAccCloudFrontDistribution_noOptionalItems
--- PASS: TestAccCloudFrontDistribution_disappears (212.82s)
=== CONT  TestAccCloudFrontDistribution_Origin_originShield
--- PASS: TestAccCloudFrontDistribution_OrderedCacheBehaviorForwardedValues_headers (217.29s)
=== CONT  TestAccAWSCloudFrontResponseHeadersPolicy_disappears
--- PASS: TestAccCloudFrontDistribution_OrderedCacheBehaviorForwardedValuesCookies_whitelistedNames (225.30s)
=== CONT  TestAccCloudFrontDistribution_orderedCacheBehaviorResponseHeadersPolicy
--- PASS: TestAccCloudFrontDistribution_DefaultCacheBehavior_trustedSigners (225.42s)
=== CONT  TestAccCloudFrontDistribution_ViewerCertificateACMCertificateARN_conflictsWithCloudFrontDefaultCertificate
--- PASS: TestAccCloudFrontDistribution_DefaultCacheBehaviorForwardedValuesCookies_whitelistedNames (225.95s)
=== CONT  TestAccCloudFrontDistribution_orderedCacheBehaviorCachePolicy
--- PASS: TestAccAWSCloudFrontResponseHeadersPolicy_disappears (11.31s)
=== CONT  TestAccCloudFrontDistribution_orderedCacheBehavior
--- PASS: TestAccCloudFrontDistribution_DefaultCacheBehavior_realtimeLogARN (230.65s)
=== CONT  TestAccCloudFrontDistribution_customOrigin
--- PASS: TestAccCloudFrontDistribution_ViewerCertificate_acmCertificateARN (233.60s)
=== CONT  TestAccCloudFrontDistribution_originPolicyDefault
--- PASS: TestAccCloudFrontDistribution_DefaultCacheBehavior_trustedKeyGroups (260.51s)
=== CONT  TestAccCloudFrontDistribution_Origin_connectionTimeout
--- PASS: TestAccCloudFrontDistribution_DefaultCacheBehaviorForwardedValues_headers (265.04s)
=== CONT  TestAccAWSCloudFrontResponseHeadersPolicy_SecurityHeadersConfig
--- PASS: TestAccCloudFrontDistribution_OrderedCacheBehavior_realtimeLogARN (271.15s)
=== CONT  TestAccCloudFrontDistribution_Origin_connectionAttempts
--- PASS: TestAccAWSCloudFrontResponseHeadersPolicy_SecurityHeadersConfig (23.81s)
=== CONT  TestAccAWSCloudFrontResponseHeadersPolicy_CustomHeadersConfig
--- PASS: TestAccAWSCloudFrontResponseHeadersPolicy_CustomHeadersConfig (11.83s)
=== CONT  TestAccCloudFrontDistribution_Origin_emptyOriginID
--- PASS: TestAccCloudFrontDistribution_Origin_emptyOriginID (0.96s)
=== CONT  TestAccCloudFrontDistribution_Origin_emptyDomainName
--- PASS: TestAccCloudFrontDistribution_Origin_emptyDomainName (1.00s)
=== CONT  TestAccCloudFrontDistribution_multiOrigin
--- PASS: TestAccCloudFrontDistribution_noCustomErrorResponse (379.17s)
=== CONT  TestAccCloudFrontDistribution_s3OriginWithTags
--- PASS: TestAccCloudFrontDistribution_isIPV6Enabled (380.04s)
=== CONT  TestAccCloudFrontDistribution_s3Origin
--- PASS: TestAccCloudFrontDistribution_retainOnDelete (381.75s)
--- PASS: TestAccCloudFrontDistribution_originGroups (394.35s)
--- PASS: TestAccCloudFrontDistribution_originPolicyOrdered (398.72s)
--- PASS: TestAccCloudFrontDistribution_noOptionalItems (355.41s)
--- PASS: TestAccCloudFrontDistribution_ViewerCertificateACMCertificateARN_conflictsWithCloudFrontDefaultCertificate (186.49s)
--- PASS: TestAccCloudFrontDistribution_http11 (406.29s)
--- PASS: TestAccCloudFrontDistribution_waitForDeployment (452.60s)
--- PASS: TestAccCloudFrontDistribution_orderedCacheBehavior (322.71s)
--- PASS: TestAccCloudFrontDistribution_forwardedValuesToCachePolicy (557.41s)
--- PASS: TestAccCloudFrontDistribution_orderedCacheBehaviorCachePolicy (333.65s)
--- PASS: TestAccCloudFrontDistribution_orderedCacheBehaviorResponseHeadersPolicy (336.22s)
--- PASS: TestAccCloudFrontDistribution_originPolicyDefault (343.30s)
--- PASS: TestAccCloudFrontDistribution_customOrigin (353.04s)
--- PASS: TestAccCloudFrontDistribution_enabled (585.29s)
--- PASS: TestAccCloudFrontDistribution_Origin_connectionTimeout (359.34s)
--- PASS: TestAccCloudFrontDistribution_multiOrigin (319.55s)
--- PASS: TestAccCloudFrontDistribution_Origin_originShield (411.19s)
--- PASS: TestAccCloudFrontDistribution_Origin_connectionAttempts (403.42s)
--- PASS: TestAccCloudFrontDistribution_s3Origin (331.43s)
--- PASS: TestAccCloudFrontDistribution_s3OriginWithTags (515.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront	897.929s

GovCloud

% make testacc PKG_NAME=internal/service/cloudfront TESTARGS='-run=TestAccAWSCloudFrontResponseHeadersPolicy_\|TestAccAWSCloudFrontDataSourceResponseHeadersPolicy_\|TestAccCloudFrontDistribution_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudfront/... -v -count 1 -parallel 20 -run=TestAccAWSCloudFrontResponseHeadersPolicy_\|TestAccAWSCloudFrontDataSourceResponseHeadersPolicy_\|TestAccCloudFrontDistribution_ -timeout 180m
=== RUN   TestAccCloudFrontDistribution_disappears
=== PAUSE TestAccCloudFrontDistribution_disappears
=== RUN   TestAccCloudFrontDistribution_s3Origin
=== PAUSE TestAccCloudFrontDistribution_s3Origin
=== RUN   TestAccCloudFrontDistribution_s3OriginWithTags
=== PAUSE TestAccCloudFrontDistribution_s3OriginWithTags
=== RUN   TestAccCloudFrontDistribution_customOrigin
=== PAUSE TestAccCloudFrontDistribution_customOrigin
=== RUN   TestAccCloudFrontDistribution_originPolicyDefault
=== PAUSE TestAccCloudFrontDistribution_originPolicyDefault
=== RUN   TestAccCloudFrontDistribution_originPolicyOrdered
=== PAUSE TestAccCloudFrontDistribution_originPolicyOrdered
=== RUN   TestAccCloudFrontDistribution_multiOrigin
=== PAUSE TestAccCloudFrontDistribution_multiOrigin
=== RUN   TestAccCloudFrontDistribution_orderedCacheBehavior
=== PAUSE TestAccCloudFrontDistribution_orderedCacheBehavior
=== RUN   TestAccCloudFrontDistribution_orderedCacheBehaviorCachePolicy
=== PAUSE TestAccCloudFrontDistribution_orderedCacheBehaviorCachePolicy
=== RUN   TestAccCloudFrontDistribution_orderedCacheBehaviorResponseHeadersPolicy
=== PAUSE TestAccCloudFrontDistribution_orderedCacheBehaviorResponseHeadersPolicy
=== RUN   TestAccCloudFrontDistribution_forwardedValuesToCachePolicy
=== PAUSE TestAccCloudFrontDistribution_forwardedValuesToCachePolicy
=== RUN   TestAccCloudFrontDistribution_Origin_emptyDomainName
=== PAUSE TestAccCloudFrontDistribution_Origin_emptyDomainName
=== RUN   TestAccCloudFrontDistribution_Origin_emptyOriginID
=== PAUSE TestAccCloudFrontDistribution_Origin_emptyOriginID
=== RUN   TestAccCloudFrontDistribution_Origin_connectionAttempts
=== PAUSE TestAccCloudFrontDistribution_Origin_connectionAttempts
=== RUN   TestAccCloudFrontDistribution_Origin_connectionTimeout
=== PAUSE TestAccCloudFrontDistribution_Origin_connectionTimeout
=== RUN   TestAccCloudFrontDistribution_Origin_originShield
=== PAUSE TestAccCloudFrontDistribution_Origin_originShield
=== RUN   TestAccCloudFrontDistribution_noOptionalItems
=== PAUSE TestAccCloudFrontDistribution_noOptionalItems
=== RUN   TestAccCloudFrontDistribution_http11
=== PAUSE TestAccCloudFrontDistribution_http11
=== RUN   TestAccCloudFrontDistribution_isIPV6Enabled
=== PAUSE TestAccCloudFrontDistribution_isIPV6Enabled
=== RUN   TestAccCloudFrontDistribution_noCustomErrorResponse
=== PAUSE TestAccCloudFrontDistribution_noCustomErrorResponse
=== RUN   TestAccCloudFrontDistribution_DefaultCacheBehaviorForwardedValuesCookies_whitelistedNames
=== PAUSE TestAccCloudFrontDistribution_DefaultCacheBehaviorForwardedValuesCookies_whitelistedNames
=== RUN   TestAccCloudFrontDistribution_DefaultCacheBehaviorForwardedValues_headers
=== PAUSE TestAccCloudFrontDistribution_DefaultCacheBehaviorForwardedValues_headers
=== RUN   TestAccCloudFrontDistribution_DefaultCacheBehavior_trustedKeyGroups
=== PAUSE TestAccCloudFrontDistribution_DefaultCacheBehavior_trustedKeyGroups
=== RUN   TestAccCloudFrontDistribution_DefaultCacheBehavior_trustedSigners
=== PAUSE TestAccCloudFrontDistribution_DefaultCacheBehavior_trustedSigners
=== RUN   TestAccCloudFrontDistribution_DefaultCacheBehavior_realtimeLogARN
=== PAUSE TestAccCloudFrontDistribution_DefaultCacheBehavior_realtimeLogARN
=== RUN   TestAccCloudFrontDistribution_OrderedCacheBehavior_realtimeLogARN
=== PAUSE TestAccCloudFrontDistribution_OrderedCacheBehavior_realtimeLogARN
=== RUN   TestAccCloudFrontDistribution_enabled
=== PAUSE TestAccCloudFrontDistribution_enabled
=== RUN   TestAccCloudFrontDistribution_retainOnDelete
=== PAUSE TestAccCloudFrontDistribution_retainOnDelete
=== RUN   TestAccCloudFrontDistribution_OrderedCacheBehaviorForwardedValuesCookies_whitelistedNames
=== PAUSE TestAccCloudFrontDistribution_OrderedCacheBehaviorForwardedValuesCookies_whitelistedNames
=== RUN   TestAccCloudFrontDistribution_OrderedCacheBehaviorForwardedValues_headers
=== PAUSE TestAccCloudFrontDistribution_OrderedCacheBehaviorForwardedValues_headers
=== RUN   TestAccCloudFrontDistribution_ViewerCertificate_acmCertificateARN
=== PAUSE TestAccCloudFrontDistribution_ViewerCertificate_acmCertificateARN
=== RUN   TestAccCloudFrontDistribution_ViewerCertificateACMCertificateARN_conflictsWithCloudFrontDefaultCertificate
=== PAUSE TestAccCloudFrontDistribution_ViewerCertificateACMCertificateARN_conflictsWithCloudFrontDefaultCertificate
=== RUN   TestAccCloudFrontDistribution_waitForDeployment
=== PAUSE TestAccCloudFrontDistribution_waitForDeployment
=== RUN   TestAccCloudFrontDistribution_originGroups
=== PAUSE TestAccCloudFrontDistribution_originGroups
=== RUN   TestAccAWSCloudFrontDataSourceResponseHeadersPolicy_basic
=== PAUSE TestAccAWSCloudFrontDataSourceResponseHeadersPolicy_basic
=== RUN   TestAccAWSCloudFrontResponseHeadersPolicy_CorsConfig
=== PAUSE TestAccAWSCloudFrontResponseHeadersPolicy_CorsConfig
=== RUN   TestAccAWSCloudFrontResponseHeadersPolicy_CustomHeadersConfig
=== PAUSE TestAccAWSCloudFrontResponseHeadersPolicy_CustomHeadersConfig
=== RUN   TestAccAWSCloudFrontResponseHeadersPolicy_SecurityHeadersConfig
=== PAUSE TestAccAWSCloudFrontResponseHeadersPolicy_SecurityHeadersConfig
=== RUN   TestAccAWSCloudFrontResponseHeadersPolicy_disappears
=== PAUSE TestAccAWSCloudFrontResponseHeadersPolicy_disappears
=== CONT  TestAccCloudFrontDistribution_disappears
=== CONT  TestAccCloudFrontDistribution_DefaultCacheBehaviorForwardedValuesCookies_whitelistedNames
=== CONT  TestAccCloudFrontDistribution_forwardedValuesToCachePolicy
=== CONT  TestAccCloudFrontDistribution_ViewerCertificate_acmCertificateARN
=== CONT  TestAccCloudFrontDistribution_noCustomErrorResponse
=== CONT  TestAccCloudFrontDistribution_OrderedCacheBehaviorForwardedValues_headers
=== CONT  TestAccCloudFrontDistribution_isIPV6Enabled
=== CONT  TestAccCloudFrontDistribution_OrderedCacheBehaviorForwardedValuesCookies_whitelistedNames
=== CONT  TestAccCloudFrontDistribution_http11
=== CONT  TestAccCloudFrontDistribution_retainOnDelete
=== CONT  TestAccCloudFrontDistribution_noOptionalItems
=== CONT  TestAccCloudFrontDistribution_enabled
=== CONT  TestAccCloudFrontDistribution_Origin_originShield
=== CONT  TestAccCloudFrontDistribution_OrderedCacheBehavior_realtimeLogARN
=== CONT  TestAccCloudFrontDistribution_Origin_connectionTimeout
=== CONT  TestAccCloudFrontDistribution_DefaultCacheBehavior_realtimeLogARN
=== CONT  TestAccCloudFrontDistribution_Origin_connectionAttempts
=== CONT  TestAccCloudFrontDistribution_DefaultCacheBehavior_trustedSigners
=== CONT  TestAccCloudFrontDistribution_DefaultCacheBehavior_trustedKeyGroups
=== CONT  TestAccCloudFrontDistribution_Origin_emptyOriginID
=== CONT  TestAccCloudFrontDistribution_disappears
    acctest.go:593: skipping tests; partition aws-us-gov does not support cloudfront service
=== CONT  TestAccCloudFrontDistribution_forwardedValuesToCachePolicy
    acctest.go:593: skipping tests; partition aws-us-gov does not support cloudfront service
=== CONT  TestAccCloudFrontDistribution_ViewerCertificate_acmCertificateARN
    acctest.go:593: skipping tests; partition aws-us-gov does not support cloudfront service
--- SKIP: TestAccCloudFrontDistribution_forwardedValuesToCachePolicy (1.30s)
=== CONT  TestAccCloudFrontDistribution_DefaultCacheBehaviorForwardedValues_headers
=== CONT  TestAccCloudFrontDistribution_originPolicyOrdered
=== CONT  TestAccCloudFrontDistribution_orderedCacheBehaviorResponseHeadersPolicy
=== CONT  TestAccCloudFrontDistribution_originPolicyOrdered
    acctest.go:593: skipping tests; partition aws-us-gov does not support cloudfront service
=== CONT  TestAccCloudFrontDistribution_DefaultCacheBehaviorForwardedValues_headers
    acctest.go:593: skipping tests; partition aws-us-gov does not support cloudfront service
=== CONT  TestAccCloudFrontDistribution_Origin_emptyDomainName
=== CONT  TestAccCloudFrontDistribution_orderedCacheBehaviorCachePolicy
=== CONT  TestAccCloudFrontDistribution_DefaultCacheBehaviorForwardedValuesCookies_whitelistedNames
    acctest.go:593: skipping tests; partition aws-us-gov does not support cloudfront service
=== CONT  TestAccCloudFrontDistribution_Origin_emptyDomainName
    acctest.go:593: skipping tests; partition aws-us-gov does not support cloudfront service
=== CONT  TestAccCloudFrontDistribution_orderedCacheBehavior
--- SKIP: TestAccCloudFrontDistribution_disappears (1.30s)
=== CONT  TestAccAWSCloudFrontResponseHeadersPolicy_disappears
--- SKIP: TestAccCloudFrontDistribution_ViewerCertificate_acmCertificateARN (1.63s)
=== CONT  TestAccCloudFrontDistribution_noCustomErrorResponse
    acctest.go:593: skipping tests; partition aws-us-gov does not support cloudfront service
--- SKIP: TestAccCloudFrontDistribution_originPolicyOrdered (0.00s)
--- SKIP: TestAccCloudFrontDistribution_DefaultCacheBehaviorForwardedValues_headers (0.00s)
--- SKIP: TestAccCloudFrontDistribution_Origin_emptyDomainName (0.00s)
--- SKIP: TestAccCloudFrontDistribution_DefaultCacheBehaviorForwardedValuesCookies_whitelistedNames (1.30s)
=== CONT  TestAccCloudFrontDistribution_multiOrigin
--- SKIP: TestAccCloudFrontDistribution_noCustomErrorResponse (1.30s)
=== CONT  TestAccAWSCloudFrontResponseHeadersPolicy_disappears
    acctest.go:593: skipping tests; partition aws-us-gov does not support cloudfront service
--- SKIP: TestAccAWSCloudFrontResponseHeadersPolicy_disappears (0.00s)
=== CONT  TestAccCloudFrontDistribution_originGroups
=== CONT  TestAccCloudFrontDistribution_orderedCacheBehavior
    acctest.go:593: skipping tests; partition aws-us-gov does not support cloudfront service
=== CONT  TestAccCloudFrontDistribution_multiOrigin
    acctest.go:593: skipping tests; partition aws-us-gov does not support cloudfront service
=== CONT  TestAccAWSCloudFrontResponseHeadersPolicy_SecurityHeadersConfig
=== CONT  TestAccCloudFrontDistribution_orderedCacheBehaviorResponseHeadersPolicy
    acctest.go:593: skipping tests; partition aws-us-gov does not support cloudfront service
=== CONT  TestAccAWSCloudFrontResponseHeadersPolicy_CorsConfig
=== CONT  TestAccCloudFrontDistribution_originGroups
    acctest.go:593: skipping tests; partition aws-us-gov does not support cloudfront service
=== CONT  TestAccCloudFrontDistribution_customOrigin
=== CONT  TestAccCloudFrontDistribution_OrderedCacheBehaviorForwardedValues_headers
    acctest.go:593: skipping tests; partition aws-us-gov does not support cloudfront service
=== CONT  TestAccCloudFrontDistribution_originPolicyDefault
=== CONT  TestAccAWSCloudFrontResponseHeadersPolicy_SecurityHeadersConfig
    acctest.go:593: skipping tests; partition aws-us-gov does not support cloudfront service
=== CONT  TestAccCloudFrontDistribution_orderedCacheBehaviorCachePolicy
    acctest.go:593: skipping tests; partition aws-us-gov does not support cloudfront service
=== CONT  TestAccCloudFrontDistribution_isIPV6Enabled
    acctest.go:593: skipping tests; partition aws-us-gov does not support cloudfront service
=== CONT  TestAccCloudFrontDistribution_waitForDeployment
--- SKIP: TestAccCloudFrontDistribution_orderedCacheBehavior (0.00s)
--- SKIP: TestAccCloudFrontDistribution_multiOrigin (0.00s)
--- SKIP: TestAccCloudFrontDistribution_orderedCacheBehaviorResponseHeadersPolicy (0.00s)
--- SKIP: TestAccCloudFrontDistribution_originGroups (0.00s)
--- SKIP: TestAccCloudFrontDistribution_OrderedCacheBehaviorForwardedValues_headers (1.30s)
--- SKIP: TestAccAWSCloudFrontResponseHeadersPolicy_SecurityHeadersConfig (0.00s)
--- SKIP: TestAccCloudFrontDistribution_orderedCacheBehaviorCachePolicy (0.00s)
--- SKIP: TestAccCloudFrontDistribution_isIPV6Enabled (1.30s)
=== CONT  TestAccCloudFrontDistribution_s3Origin
=== CONT  TestAccCloudFrontDistribution_waitForDeployment
    acctest.go:593: skipping tests; partition aws-us-gov does not support cloudfront service
--- SKIP: TestAccCloudFrontDistribution_waitForDeployment (0.00s)
=== CONT  TestAccCloudFrontDistribution_ViewerCertificateACMCertificateARN_conflictsWithCloudFrontDefaultCertificate
    acctest.go:593: skipping tests; partition aws-us-gov does not support cloudfront service
=== CONT  TestAccAWSCloudFrontDataSourceResponseHeadersPolicy_basic
=== CONT  TestAccCloudFrontDistribution_s3Origin
    acctest.go:593: skipping tests; partition aws-us-gov does not support cloudfront service
=== CONT  TestAccCloudFrontDistribution_http11
    acctest.go:593: skipping tests; partition aws-us-gov does not support cloudfront service
=== CONT  TestAccCloudFrontDistribution_customOrigin
    acctest.go:593: skipping tests; partition aws-us-gov does not support cloudfront service
=== CONT  TestAccAWSCloudFrontResponseHeadersPolicy_CorsConfig
    acctest.go:593: skipping tests; partition aws-us-gov does not support cloudfront service
=== CONT  TestAccCloudFrontDistribution_s3OriginWithTags
=== CONT  TestAccCloudFrontDistribution_retainOnDelete
    acctest.go:593: skipping tests; partition aws-us-gov does not support cloudfront service
=== CONT  TestAccCloudFrontDistribution_OrderedCacheBehaviorForwardedValuesCookies_whitelistedNames
    acctest.go:593: skipping tests; partition aws-us-gov does not support cloudfront service
=== CONT  TestAccCloudFrontDistribution_noOptionalItems
    acctest.go:593: skipping tests; partition aws-us-gov does not support cloudfront service
=== CONT  TestAccCloudFrontDistribution_s3OriginWithTags
    acctest.go:593: skipping tests; partition aws-us-gov does not support cloudfront service
=== CONT  TestAccCloudFrontDistribution_originPolicyDefault
    acctest.go:593: skipping tests; partition aws-us-gov does not support cloudfront service
--- SKIP: TestAccCloudFrontDistribution_ViewerCertificateACMCertificateARN_conflictsWithCloudFrontDefaultCertificate (0.22s)
--- SKIP: TestAccCloudFrontDistribution_s3Origin (0.00s)
=== CONT  TestAccAWSCloudFrontDataSourceResponseHeadersPolicy_basic
    acctest.go:593: skipping tests; partition aws-us-gov does not support cloudfront service
--- SKIP: TestAccCloudFrontDistribution_http11 (1.30s)
--- SKIP: TestAccCloudFrontDistribution_customOrigin (0.00s)
=== CONT  TestAccAWSCloudFrontResponseHeadersPolicy_CustomHeadersConfig
--- SKIP: TestAccAWSCloudFrontDataSourceResponseHeadersPolicy_basic (0.00s)
--- SKIP: TestAccAWSCloudFrontResponseHeadersPolicy_CorsConfig (0.00s)
--- SKIP: TestAccCloudFrontDistribution_retainOnDelete (1.30s)
--- SKIP: TestAccCloudFrontDistribution_OrderedCacheBehaviorForwardedValuesCookies_whitelistedNames (1.30s)
--- SKIP: TestAccCloudFrontDistribution_noOptionalItems (1.30s)
--- SKIP: TestAccCloudFrontDistribution_s3OriginWithTags (0.00s)
--- SKIP: TestAccCloudFrontDistribution_originPolicyDefault (0.00s)
=== CONT  TestAccCloudFrontDistribution_enabled
    acctest.go:593: skipping tests; partition aws-us-gov does not support cloudfront service
=== CONT  TestAccAWSCloudFrontResponseHeadersPolicy_CustomHeadersConfig
    acctest.go:593: skipping tests; partition aws-us-gov does not support cloudfront service
--- SKIP: TestAccCloudFrontDistribution_enabled (1.30s)
--- SKIP: TestAccAWSCloudFrontResponseHeadersPolicy_CustomHeadersConfig (0.00s)
=== CONT  TestAccCloudFrontDistribution_Origin_originShield
    acctest.go:593: skipping tests; partition aws-us-gov does not support cloudfront service
--- SKIP: TestAccCloudFrontDistribution_Origin_originShield (1.30s)
=== CONT  TestAccCloudFrontDistribution_OrderedCacheBehavior_realtimeLogARN
    acctest.go:593: skipping tests; partition aws-us-gov does not support cloudfront service
--- SKIP: TestAccCloudFrontDistribution_OrderedCacheBehavior_realtimeLogARN (1.30s)
=== CONT  TestAccCloudFrontDistribution_DefaultCacheBehavior_realtimeLogARN
    acctest.go:593: skipping tests; partition aws-us-gov does not support cloudfront service
--- SKIP: TestAccCloudFrontDistribution_DefaultCacheBehavior_realtimeLogARN (1.30s)
=== CONT  TestAccCloudFrontDistribution_Origin_connectionAttempts
    acctest.go:593: skipping tests; partition aws-us-gov does not support cloudfront service
--- SKIP: TestAccCloudFrontDistribution_Origin_connectionAttempts (1.30s)
=== CONT  TestAccCloudFrontDistribution_Origin_connectionTimeout
    acctest.go:593: skipping tests; partition aws-us-gov does not support cloudfront service
--- SKIP: TestAccCloudFrontDistribution_Origin_connectionTimeout (1.30s)
=== CONT  TestAccCloudFrontDistribution_DefaultCacheBehavior_trustedSigners
    acctest.go:593: skipping tests; partition aws-us-gov does not support cloudfront service
--- SKIP: TestAccCloudFrontDistribution_DefaultCacheBehavior_trustedSigners (1.30s)
=== CONT  TestAccCloudFrontDistribution_Origin_emptyOriginID
    acctest.go:593: skipping tests; partition aws-us-gov does not support cloudfront service
=== CONT  TestAccCloudFrontDistribution_DefaultCacheBehavior_trustedKeyGroups
    acctest.go:593: skipping tests; partition aws-us-gov does not support cloudfront service
--- SKIP: TestAccCloudFrontDistribution_DefaultCacheBehavior_trustedKeyGroups (1.30s)
--- SKIP: TestAccCloudFrontDistribution_Origin_emptyOriginID (1.30s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront	4.941s

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/cloudfront Issues and PRs that pertain to the cloudfront service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 3, 2021
@ewbankkit
Run 'go mod tidy'.
c7ec2f6
@ewbankkit
Add CHANGELOG entry.
bf8a0ba
@ewbankkit
Add 'FindResponseHeadersPolicyByID'.
9929c96 
Acceptance test output:

% make testacc PKG_NAME=internal/service/cloudfront TESTARGS='-run=TestAccAWSCloudFrontResponseHeadersPolicy_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudfront/... -v -count 1 -parallel 20 -run=TestAccAWSCloudFrontResponseHeadersPolicy_ -timeout 180m
=== RUN   TestAccAWSCloudFrontResponseHeadersPolicy_basic
=== PAUSE TestAccAWSCloudFrontResponseHeadersPolicy_basic
=== RUN   TestAccAWSCloudFrontResponseHeadersPolicy_disappears
=== PAUSE TestAccAWSCloudFrontResponseHeadersPolicy_disappears
=== RUN   TestAccAWSCloudFrontResponseHeadersPolicy_update
=== PAUSE TestAccAWSCloudFrontResponseHeadersPolicy_update
=== CONT  TestAccAWSCloudFrontResponseHeadersPolicy_basic
=== CONT  TestAccAWSCloudFrontResponseHeadersPolicy_disappears
=== CONT  TestAccAWSCloudFrontResponseHeadersPolicy_update
--- PASS: TestAccAWSCloudFrontResponseHeadersPolicy_disappears (12.89s)
--- PASS: TestAccAWSCloudFrontResponseHeadersPolicy_basic (16.57s)
--- PASS: TestAccAWSCloudFrontResponseHeadersPolicy_update (28.36s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront	33.439s
@ewbankkit
Fix tfproviderdocs error.
176ce1f
@ewbankkit
Fix terrafmt errors.
6332ca5
@ewbankkit
Fix misspellings.
7b71cb7
@ewbankkit
Fix markdown-lint errors.
277b1c5
@ewbankkit
Fix acceptance test terrafmt errors.
f2d3ff0
@ewbankkit
Fix terrafmt errors.
0c87d7d
@ewbankkit
Fix acceptance test terrafmt errors.
b3bc845
@ewbankkit
d/aws_cloudfront_response_headers_policy: Tidy up acceptance tests.
4957e15
@ewbankkit
r/aws_cloudfront_response_headers_policy: Standardize flex.
260df14 
Acceptance test output:

% make testacc PKG_NAME=internal/service/cloudfront TESTARGS='-run=TestAccAWSCloudFrontDataSourceResponseHeadersPolicy_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudfront/... -v -count 1 -parallel 20 -run=TestAccAWSCloudFrontDataSourceResponseHeadersPolicy_ -timeout 180m
=== RUN   TestAccAWSCloudFrontDataSourceResponseHeadersPolicy_basic
=== PAUSE TestAccAWSCloudFrontDataSourceResponseHeadersPolicy_basic
=== CONT  TestAccAWSCloudFrontDataSourceResponseHeadersPolicy_basic
--- PASS: TestAccAWSCloudFrontDataSourceResponseHeadersPolicy_basic (13.39s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront	17.848s
@ewbankkit
r/aws_cloudfront_response_headers_policy: Finish up standard flex.
81b9674 
Acceptance test output:

% make testacc PKG_NAME=internal/service/cloudfront TESTARGS='-run=TestAccAWSCloudFrontResponseHeadersPolicy_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudfront/... -v -count 1 -parallel 20 -run=TestAccAWSCloudFrontResponseHeadersPolicy_ -timeout 180m
=== RUN   TestAccAWSCloudFrontResponseHeadersPolicy_basic
=== PAUSE TestAccAWSCloudFrontResponseHeadersPolicy_basic
=== RUN   TestAccAWSCloudFrontResponseHeadersPolicy_disappears
=== PAUSE TestAccAWSCloudFrontResponseHeadersPolicy_disappears
=== RUN   TestAccAWSCloudFrontResponseHeadersPolicy_update
=== PAUSE TestAccAWSCloudFrontResponseHeadersPolicy_update
=== CONT  TestAccAWSCloudFrontResponseHeadersPolicy_basic
=== CONT  TestAccAWSCloudFrontResponseHeadersPolicy_update
=== CONT  TestAccAWSCloudFrontResponseHeadersPolicy_disappears
--- PASS: TestAccAWSCloudFrontResponseHeadersPolicy_disappears (10.34s)
--- PASS: TestAccAWSCloudFrontResponseHeadersPolicy_basic (13.19s)
--- PASS: TestAccAWSCloudFrontResponseHeadersPolicy_update (20.73s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront	23.748s
@ewbankkit
Use AWS Go SDK '_Values()': #14601.
c81bf3f
@ewbankkit
At least one of 'cors_config', 'custom_headers_config' or 'security_h…
3d8a421 
…eaders_config' must be specified.
@ewbankkit
r/aws_cloudfront_response_headers_policy: Don't forget 'access_contro…
935aabc 
…l_expose_headers'.
@ewbankkit
Test updating 'name'.
536af58
@ewbankkit
Add 'TestAccAWSCloudFrontResponseHeadersPolicy_CustomHeadersConfig'.
333fe2b
@ewbankkit
Add 'TestAccAWSCloudFrontResponseHeadersPolicy_SecurityHeadersConfig'.
a24e09d
@ewbankkit
r/aws_cloudfront_response_headers_policy: Deal with empty container o…
cf5f27d 
…bjects returned by AWS API.
@ewbankkit
Fix terrafmt acceptance test errors.
4abcb42
@ewbankkit
Copy link
Contributor Author

LGTM 🚀.

@ewbankkit
Copy link
Contributor Author

@AdamTylerLynch @skyscrapr Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 927ed9c into main Nov 4, 2021
@ewbankkit ewbankkit deleted the f-aws-cloudfront-response-headers-policies branch November 4, 2021 17:04
@github-actions github-actions bot added this to the v3.64.0 milestone Nov 4, 2021
github-actions bot pushed a commit that referenced this pull request Nov 4, 2021
Update CHANGELOG.md for #21620
144c0f5
@github-actions
Copy link

github-actions bot commented Nov 4, 2021

This functionality has been released in v3.64.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@willfarrell willfarrell mentioned this pull request Nov 4, 2021
Closed
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/cloudfront Issues and PRs that pertain to the cloudfront service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.64.0
Development

Successfully merging this pull request may close these issues.

Support CloudFront response headers policy
2 participants
@ewbankkit @AdamTylerLynch