Fixed an issue when importing Route53 Records with underscores

[jdeschenes]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

There is an issue when a DNS record contains an underscore. This problem occurred when trying to import a DNS Record for a DKIM record of Microsoft 365. Here is an example from Microsoft Link

*._domainkey.SubDomainThatShouldntSendMail.contoso.com. TXT "v=DKIM1; p="

In my particular case, the DNS entries that needed to be imported looked like this:

selector1._domainkey.contoso.com.
selector2._domainkey.contoso.com.

The problem was solved for the case where the underscore was the first character of the DNS Name but did not validate when the underscore was somewhere else in the Name.

Closes #16213

Output from acceptance testing: N/A

Let me know if there is something to adjust.

[github-actions]

Welcome @jdeschenes 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[DragonStuff]

Thank you for fixing this! Just ran into this today with my team.

[gdavison]

Thanks for the PR, @jdeschenes, it looks good. 🚀

I've added a couple test cases and made a few tweaks

Acceptance test results

--- PASS: TestAccRoute53Record_Weighted_basic (203.10s)
--- PASS: TestAccRoute53Record_doNotAllowOverwrite (204.66s)
--- PASS: TestAccRoute53Record_basic (210.39s)
--- PASS: TestAccRoute53Record_Alias_elb (217.45s)
--- PASS: TestAccRoute53Record_longTXTrecord (233.64s)
--- PASS: TestAccRoute53Record_empty (233.75s)
--- PASS: TestAccRoute53Record_generatesSuffix (234.57s)
--- PASS: TestAccRoute53Record_Alias_s3 (235.16s)
--- PASS: TestAccRoute53Record_failover (240.53s)
--- PASS: TestAccRoute53Record_dsSupport (244.50s)
--- PASS: TestAccRoute53Record_Latency_basic (252.93s)
--- PASS: TestAccRoute53Record_MultiValueAnswer_basic (256.58s)
--- PASS: TestAccRoute53Record_allowOverwrite (258.53s)
--- PASS: TestAccRoute53Record_setIdentifierChange (305.28s)
--- PASS: TestAccRoute53Record_typeChange (317.00s)
--- PASS: TestAccRoute53Record_aliasChange (320.10s)
--- PASS: TestAccRoute53Record_wildcard (320.61s)
--- PASS: TestAccRoute53Record_WeightedToSimple_basic (323.00s)
--- PASS: TestAccRoute53Record_nameChange (354.95s)
--- PASS: TestAccRoute53Record_Geolocation_basic (163.93s)
--- PASS: TestAccRoute53Record_Alias_uppercase (145.51s)
--- PASS: TestAccRoute53Record_caaSupport (146.74s)
--- PASS: TestAccRoute53Record_Basic_trailingPeriodAndZoneID (155.58s)
--- PASS: TestAccRoute53Record_spfSupport (156.73s)
--- PASS: TestAccRoute53Record_disappears (135.70s)
--- PASS: TestAccRoute53Record_txtSupport (152.53s)
--- PASS: TestAccRoute53Record_underscored (162.50s)
--- PASS: TestAccRoute53Record_Basic_fqdn (170.53s)
--- PASS: TestAccRoute53Record_HealthCheckID_typeChange (222.80s)
--- PASS: TestAccRoute53Record_Disappears_multipleRecords (191.33s)
--- PASS: TestAccRoute53Record_HealthCheckID_setIdentifierChange (274.05s)
--- PASS: TestAccRoute53Record_Weighted_alias (312.35s)
--- PASS: TestAccRoute53Record_Alias_vpcEndpoint (601.62s)

[github-actions]

This functionality has been released in v3.72.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.