r/aws_sagemaker_domain: add arguments to DefaultResourceSpec #21508

philof · 2021-10-26T20:39:09Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccDomain_kernelGatewayAppSettings_lifecycleConfig' PKG_NAME=internal/service/sagemaker
TF_ACC=1 go test ./internal/service/sagemaker/... -v -count 1 -parallel 20 -run=TestAccDomain_kernelGatewayAppSettings_lifecycleConfig -timeout 180m
=== RUN   TestAccDomain_kernelGatewayAppSettings_lifecycleConfig
--- PASS: TestAccDomain_kernelGatewayAppSettings_lifecycleConfig (402.17s)
PASS
ok       github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker  403.972s

DrFaust92 · 2021-10-28T06:05:53Z

@philof can we add this for user profile as well? both resource share schema for default_resource_spec

internal/service/sagemaker/domain.go

…efaultResourceSpec Acceptance test output: $ make testacc TESTARGS='-run=TestAccDomain' PKG_NAME=internal/service/sagemaker TF_ACC=1 go test ./internal/service/sagemaker/... -v -count 1 -parallel 20 -run=TestAccDomain -timeout 180m === RUN TestAccDomain_kernelGatewayAppSettings_lifecycleConfig --- PASS: TestAccDomain_kernelGatewayAppSettings_lifecycleConfig (304.07s) === RUN TestAccDomain_kernelGatewayAppSettings_defaultResourceSpecAndCustomImage --- PASS: TestAccDomain_kernelGatewayAppSettings_defaultResourceSpecAndCustomImage (304.09s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker 630.080s

Acceptance test output: $ make testacc TESTARGS='-run=TestAccUserProfile' PKG_NAME=internal/service/sagemaker TF_ACC=1 go test ./internal/service/sagemaker/... -v -count 1 -parallel 20 -run=TestAccUserProfile -timeout 180m === RUN TestAccUserProfile_kernelGatewayAppSettings_lifecycleconfig --- PASS: TestAccUserProfile_kernelGatewayAppSettings_lifecycleconfig (261.42s) === RUN TestAccUserProfile_kernelGatewayAppSettings_imageConfig --- PASS: TestAccUserProfile_kernelGatewayAppSettings_imageconfig (262.10s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker 550.326s

DrFaust92 · 2021-11-06T19:53:30Z

@philof missing docs

fatboysalimshady · 2021-11-10T02:25:09Z

@philof can we add this for create app as well?
https://docs.aws.amazon.com/cli/latest/reference/sagemaker/create-app.html
https://docs.aws.amazon.com/sagemaker/latest/APIReference/API_CreateApp.html

Acceptance test output: $ make testacc TESTARGS='-run=TestAccApp' PKG_NAME=internal/service/sagemaker TF_ACC=1 go test ./internal/service/sagemaker/... -v -count 1 -parallel 20 -run=TestAccApp -timeout 180m === RUN TestAccApp_resourceSpec --- PASS: TestAccApp_resourceSpec (624.88s) === RUN TestAccApp_resourceSpecLifecycle --- PASS: TestAccApp_resourceSpecLifecycle (603.75s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker 1230.041s

DrFaust92 · 2021-11-13T22:38:49Z

while verifying acceptance tests:

=== RUN   TestAccSageMaker_serial/Domain/kernelGatewayAppSettings_lifecycleConfig
panic: Invalid address to set: []string{"default_user_settings", "0", "kernel_gateway_app_settings", "0", "default_resource_spec", "0", "lifcycle_config_arn"}

goroutine 20393 [running]:
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*ResourceData).Set(0x14002c29300, 0x106ce39b5, 0x15, 0x1079d4060, 0x14002ab0510, 0x0, 0x0)
        /Users/ilia/go/pkg/mod/github.com/gdavison/terraform-plugin-sdk/[email protected]/helper/schema/resource_data.go:230 +0x2d4
github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker.resourceDomainRead(0x14002c29300, 0x108447f80, 0x140018c0000, 0x1400397fae0, 0x0)
        /Users/ilia/git/terraform-provider-aws/internal/service/sagemaker/domain.go:384 +0x4e4
github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker.resourceDomainCreate(0x14002c29300, 0x108447f80, 0x140018c0000, 0xffffffffffffffff, 0x14001bbd798)
        /Users/ilia/git/terraform-provider-aws/internal/service/sagemaker/domain.go:351 +0x6b0
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).create(0x1400049b180, 0x1097261a8, 0x14002aadbc0, 0x14002c29300, 0x108447f80, 0x140018c0000, 0x0, 0x0, 0x0)
        /Users/ilia/go/pkg/mod/github.com/gdavison/terraform-plugin-sdk/[email protected]/helper/schema/resource.go:318 +0x170
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).Apply(0x1400049b180, 0x1097261a8, 0x14002aadbc0, 0x14002197340, 0x14002a817e0, 0x108447f80, 0x140018c0000, 0x0, 0x0, 0x0, ...)
        /Users/ilia/go/pkg/mod/github.com/gdavison/terraform-plugin-sdk/[email protected]/helper/schema/resource.go:456 +0x4ec
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*GRPCProviderServer).ApplyResourceChange(0x14000f700a8, 0x1097261a8, 0x14002aadbc0, 0x14002adca00, 0x14002aadbc0, 0x1090dd760, 0x0)
        /Users/ilia/go/pkg/mod/github.com/gdavison/terraform-plugin-sdk/[email protected]/helper/schema/grpc_provider.go:955 +0x6f8
github.com/hashicorp/terraform-plugin-go/tfprotov5/server.(*server).ApplyResourceChange(0x14001f44120, 0x109726250, 0x14002aadbc0, 0x140021971f0, 0x14001f44120, 0x105c39b40, 0x108e5d480)
        /Users/ilia/go/pkg/mod/github.com/hashicorp/[email protected]/tfprotov5/server/server.go:332 +0x94
github.com/hashicorp/terraform-plugin-go/tfprotov5/internal/tfplugin5._Provider_ApplyResourceChange_Handler(0x1090dd760, 0x14001f44120, 0x109726250, 0x14001ffeb40, 0x14001614480, 0x0, 0x109726250, 0x14001ffeb40, 0x14001c3b800, 0x750)
        /Users/ilia/go/pkg/mod/github.com/hashicorp/[email protected]/tfprotov5/internal/tfplugin5/tfplugin5_grpc.pb.go:380 +0x1c8
google.golang.org/grpc.(*Server).processUnaryRPC(0x1400120a380, 0x10974ae78, 0x14002e58480, 0x140016c9a00, 0x1400253e600, 0x10d1f70e0, 0x0, 0x0, 0x0)
        /Users/ilia/go/pkg/mod/google.golang.org/[email protected]/server.go:1194 +0x3e8
google.golang.org/grpc.(*Server).handleStream(0x1400120a380, 0x10974ae78, 0x14002e58480, 0x140016c9a00, 0x0)
        /Users/ilia/go/pkg/mod/google.golang.org/[email protected]/server.go:1517 +0xa50
google.golang.org/grpc.(*Server).serveStreams.func1.2(0x1400211e1b0, 0x1400120a380, 0x10974ae78, 0x14002e58480, 0x140016c9a00)
        /Users/ilia/go/pkg/mod/google.golang.org/[email protected]/server.go:859 +0x94
created by google.golang.org/grpc.(*Server).serveStreams.func1
        /Users/ilia/go/pkg/mod/google.golang.org/[email protected]/server.go:857 +0x1f8
FAIL    github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker  3007.921s

Acceptance test output: ❯ ACCTEST_TIMEOUT=600m SAGEMAKER_IMAGE_VERSION_BASE_IMAGE=x.dkr.ecr.us-east-1.amazonaws.com/smtest make testacc TESTARGS='-run=TestAccSageMaker_serial' PKG_NAME=internal/service/sagemaker ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/sagemaker/... -v -count 1 -parallel 20 -run=TestAccSageMaker_serial -timeout 600m === RUN TestAccSageMaker_serial === RUN TestAccSageMaker_serial/App === RUN TestAccSageMaker_serial/App/disappears === RUN TestAccSageMaker_serial/App/tags === RUN TestAccSageMaker_serial/App/resourceSpec === RUN TestAccSageMaker_serial/App/resourceSpecLifecycle === RUN TestAccSageMaker_serial/App/basic === RUN TestAccSageMaker_serial/Domain === RUN TestAccSageMaker_serial/Domain/kernelGatewayAppSettings_defaultResourceAndCustomImage === RUN TestAccSageMaker_serial/Domain/jupyterServerAppSettings === RUN TestAccSageMaker_serial/Domain/sharingSettings === RUN TestAccSageMaker_serial/Domain/tensorboardAppSettings === RUN TestAccSageMaker_serial/Domain/tensorboardAppSettingsWithImage === RUN TestAccSageMaker_serial/Domain/kernelGatewayAppSettings === RUN TestAccSageMaker_serial/Domain/kernelGatewayAppSettings_customImage === RUN TestAccSageMaker_serial/Domain/kernelGatewayAppSettings_lifecycleConfig === RUN TestAccSageMaker_serial/Domain/kms === RUN TestAccSageMaker_serial/Domain/securityGroup === RUN TestAccSageMaker_serial/Domain/basic === RUN TestAccSageMaker_serial/Domain/disappears === RUN TestAccSageMaker_serial/Domain/tags === RUN TestAccSageMaker_serial/FlowDefinition === RUN TestAccSageMaker_serial/FlowDefinition/HumanLoopRequestSource === RUN TestAccSageMaker_serial/FlowDefinition/Tags === RUN TestAccSageMaker_serial/FlowDefinition/basic === RUN TestAccSageMaker_serial/FlowDefinition/disappears === RUN TestAccSageMaker_serial/FlowDefinition/HumanLoopConfigPublicWorkforce === RUN TestAccSageMaker_serial/UserProfile === RUN TestAccSageMaker_serial/UserProfile/tensorboardAppSettingsWithImage === RUN TestAccSageMaker_serial/UserProfile/jupyterServerAppSettings === RUN TestAccSageMaker_serial/UserProfile/basic === RUN TestAccSageMaker_serial/UserProfile/disappears === RUN TestAccSageMaker_serial/UserProfile/tags === RUN TestAccSageMaker_serial/UserProfile/tensorboardAppSettings === RUN TestAccSageMaker_serial/UserProfile/kernelGatewayAppSettings === RUN TestAccSageMaker_serial/UserProfile/kernelGatewayAppSettings_lifecycleConfig === RUN TestAccSageMaker_serial/UserProfile/kernelGatewayAppSettings_imageConfig === RUN TestAccSageMaker_serial/Workforce === RUN TestAccSageMaker_serial/Workforce/CognitoConfig === RUN TestAccSageMaker_serial/Workforce/OidcConfig === RUN TestAccSageMaker_serial/Workforce/SourceIpConfig === RUN TestAccSageMaker_serial/Workforce/disappears === RUN TestAccSageMaker_serial/Workteam === RUN TestAccSageMaker_serial/Workteam/disappears === RUN TestAccSageMaker_serial/Workteam/CognitoConfig === RUN TestAccSageMaker_serial/Workteam/NotificationConfig === RUN TestAccSageMaker_serial/Workteam/OidcConfig === RUN TestAccSageMaker_serial/Workteam/Tags --- PASS: TestAccSageMaker_serial (10828.38s) --- PASS: TestAccSageMaker_serial/App (3331.75s) --- PASS: TestAccSageMaker_serial/App/disappears (659.96s) --- PASS: TestAccSageMaker_serial/App/tags (665.90s) --- PASS: TestAccSageMaker_serial/App/resourceSpec (687.94s) --- PASS: TestAccSageMaker_serial/App/resourceSpecLifecycle (625.07s) --- PASS: TestAccSageMaker_serial/App/basic (692.87s) --- PASS: TestAccSageMaker_serial/Domain (3581.61s) --- PASS: TestAccSageMaker_serial/Domain/kernelGatewayAppSettings_defaultResourceAndCustomImage (315.60s) --- PASS: TestAccSageMaker_serial/Domain/jupyterServerAppSettings (254.26s) --- PASS: TestAccSageMaker_serial/Domain/sharingSettings (264.29s) --- PASS: TestAccSageMaker_serial/Domain/tensorboardAppSettings (253.72s) --- PASS: TestAccSageMaker_serial/Domain/tensorboardAppSettingsWithImage (314.30s) --- PASS: TestAccSageMaker_serial/Domain/kernelGatewayAppSettings (271.20s) --- PASS: TestAccSageMaker_serial/Domain/kernelGatewayAppSettings_customImage (320.28s) --- PASS: TestAccSageMaker_serial/Domain/kernelGatewayAppSettings_lifecycleConfig (248.10s) --- PASS: TestAccSageMaker_serial/Domain/kms (249.18s) --- PASS: TestAccSageMaker_serial/Domain/securityGroup (297.40s) --- PASS: TestAccSageMaker_serial/Domain/basic (248.37s) --- PASS: TestAccSageMaker_serial/Domain/disappears (299.19s) --- PASS: TestAccSageMaker_serial/Domain/tags (245.71s) --- PASS: TestAccSageMaker_serial/FlowDefinition (488.14s) --- PASS: TestAccSageMaker_serial/FlowDefinition/HumanLoopRequestSource (100.13s) --- PASS: TestAccSageMaker_serial/FlowDefinition/Tags (150.63s) --- PASS: TestAccSageMaker_serial/FlowDefinition/basic (100.80s) --- PASS: TestAccSageMaker_serial/FlowDefinition/disappears (95.39s) --- PASS: TestAccSageMaker_serial/FlowDefinition/HumanLoopConfigPublicWorkforce (41.19s) --- PASS: TestAccSageMaker_serial/UserProfile (2905.15s) --- PASS: TestAccSageMaker_serial/UserProfile/tensorboardAppSettingsWithImage (278.65s) --- PASS: TestAccSageMaker_serial/UserProfile/jupyterServerAppSettings (269.30s) --- PASS: TestAccSageMaker_serial/UserProfile/basic (267.72s) --- PASS: TestAccSageMaker_serial/UserProfile/disappears (693.27s) --- PASS: TestAccSageMaker_serial/UserProfile/tags (264.54s) --- PASS: TestAccSageMaker_serial/UserProfile/tensorboardAppSettings (265.57s) --- PASS: TestAccSageMaker_serial/UserProfile/kernelGatewayAppSettings (286.11s) --- PASS: TestAccSageMaker_serial/UserProfile/kernelGatewayAppSettings_lifecycleConfig (292.83s) --- PASS: TestAccSageMaker_serial/UserProfile/kernelGatewayAppSettings_imageConfig (287.15s) --- PASS: TestAccSageMaker_serial/Workforce (146.87s) --- PASS: TestAccSageMaker_serial/Workforce/CognitoConfig (25.39s) --- PASS: TestAccSageMaker_serial/Workforce/OidcConfig (40.59s) --- PASS: TestAccSageMaker_serial/Workforce/SourceIpConfig (58.63s) --- PASS: TestAccSageMaker_serial/Workforce/disappears (22.27s) --- PASS: TestAccSageMaker_serial/Workteam (374.85s) --- PASS: TestAccSageMaker_serial/Workteam/disappears (20.02s) --- PASS: TestAccSageMaker_serial/Workteam/CognitoConfig (133.54s) --- PASS: TestAccSageMaker_serial/Workteam/NotificationConfig (52.59s) --- PASS: TestAccSageMaker_serial/Workteam/OidcConfig (52.72s) --- PASS: TestAccSageMaker_serial/Workteam/Tags (115.98s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker 10829.875s

maldo91 · 2021-11-22T08:07:49Z

@DrFaust92 @philof can I help here somehow? Is there anything missing? Thanks :)

DrFaust92 · 2021-11-26T02:16:33Z

Domain tests:

        --- PASS: TestAccSageMaker_serial/Domain/jupyterServerAppSettings (334.64s)
        --- PASS: TestAccSageMaker_serial/Domain/securityGroup (396.19s)
        --- PASS: TestAccSageMaker_serial/Domain/kernelGatewayAppSettings_lifecycleConfig (332.03s)
        --- PASS: TestAccSageMaker_serial/Domain/basic (333.96s)
        --- PASS: TestAccSageMaker_serial/Domain/disappears (462.43s)
        --- PASS: TestAccSageMaker_serial/Domain/tensorboardAppSettings (229.29s)
        --- PASS: TestAccSageMaker_serial/Domain/tensorboardAppSettingsWithImage (395.96s)
        --- PASS: TestAccSageMaker_serial/Domain/kms (215.58s)

App:

--- PASS: TestAccSageMaker_serial/App/resourceSpecLifecycle (655.57s)

DrFaust92

LGTM

maldo91 · 2021-12-02T08:42:37Z

@DrFaust92 is it possible to add this to the next release?

maldo91 · 2021-12-10T09:38:34Z

@DrFaust92 can we please add this fix on the next release? everything seems correct, right?

ewbankkit

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSageMaker_serial/App' PKG_NAME=internal/service/sagemaker         
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sagemaker/... -v -count 1 -parallel 20 -run=TestAccSageMaker_serial/App -timeout 180m
=== RUN   TestAccSageMaker_serial
=== RUN   TestAccSageMaker_serial/App
=== RUN   TestAccSageMaker_serial/App/resourceSpec
=== RUN   TestAccSageMaker_serial/App/resourceSpecLifecycle
=== RUN   TestAccSageMaker_serial/App/basic
=== RUN   TestAccSageMaker_serial/App/disappears
=== RUN   TestAccSageMaker_serial/App/tags
--- PASS: TestAccSageMaker_serial (2515.27s)
    --- PASS: TestAccSageMaker_serial/App (2515.26s)
        --- PASS: TestAccSageMaker_serial/App/resourceSpec (443.02s)
        --- PASS: TestAccSageMaker_serial/App/resourceSpecLifecycle (523.98s)
        --- PASS: TestAccSageMaker_serial/App/basic (493.96s)
        --- PASS: TestAccSageMaker_serial/App/disappears (556.16s)
        --- PASS: TestAccSageMaker_serial/App/tags (498.14s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker	2518.113s
% make testacc TESTARGS='-run=TestAccSageMaker_serial/Domain' PKG_NAME=internal/service/sagemaker
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sagemaker/... -v -count 1 -parallel 20 -run=TestAccSageMaker_serial/Domain -timeout 180m
=== RUN   TestAccSageMaker_serial
=== RUN   TestAccSageMaker_serial/Domain
=== RUN   TestAccSageMaker_serial/Domain/sharingSettings
=== RUN   TestAccSageMaker_serial/Domain/basic
=== RUN   TestAccSageMaker_serial/Domain/tags
=== RUN   TestAccSageMaker_serial/Domain/kernelGatewayAppSettings
=== RUN   TestAccSageMaker_serial/Domain/kms
=== RUN   TestAccSageMaker_serial/Domain/securityGroup
=== RUN   TestAccSageMaker_serial/Domain/kernelGatewayAppSettings_defaultResourceAndCustomImage
    domain_test.go:370: Environment variable SAGEMAKER_IMAGE_VERSION_BASE_IMAGE is not set
=== RUN   TestAccSageMaker_serial/Domain/jupyterServerAppSettings
=== RUN   TestAccSageMaker_serial/Domain/disappears
=== RUN   TestAccSageMaker_serial/Domain/tensorboardAppSettings
=== RUN   TestAccSageMaker_serial/Domain/tensorboardAppSettingsWithImage
=== RUN   TestAccSageMaker_serial/Domain/kernelGatewayAppSettings_customImage
    domain_test.go:331: Environment variable SAGEMAKER_IMAGE_VERSION_BASE_IMAGE is not set
=== RUN   TestAccSageMaker_serial/Domain/kernelGatewayAppSettings_lifecycleConfig
--- PASS: TestAccSageMaker_serial (2673.13s)
    --- PASS: TestAccSageMaker_serial/Domain (2673.13s)
        --- PASS: TestAccSageMaker_serial/Domain/sharingSettings (133.68s)
        --- PASS: TestAccSageMaker_serial/Domain/basic (255.62s)
        --- PASS: TestAccSageMaker_serial/Domain/tags (116.03s)
        --- PASS: TestAccSageMaker_serial/Domain/kernelGatewayAppSettings (194.16s)
        --- PASS: TestAccSageMaker_serial/Domain/kms (276.68s)
        --- PASS: TestAccSageMaker_serial/Domain/securityGroup (294.48s)
        --- SKIP: TestAccSageMaker_serial/Domain/kernelGatewayAppSettings_defaultResourceAndCustomImage (0.00s)
        --- PASS: TestAccSageMaker_serial/Domain/jupyterServerAppSettings (252.12s)
        --- PASS: TestAccSageMaker_serial/Domain/disappears (312.47s)
        --- PASS: TestAccSageMaker_serial/Domain/tensorboardAppSettings (271.41s)
        --- PASS: TestAccSageMaker_serial/Domain/tensorboardAppSettingsWithImage (315.88s)
        --- SKIP: TestAccSageMaker_serial/Domain/kernelGatewayAppSettings_customImage (0.00s)
        --- PASS: TestAccSageMaker_serial/Domain/kernelGatewayAppSettings_lifecycleConfig (250.59s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker	2676.242s
% make testacc TESTARGS='-run=TestAccSageMaker_serial/UserProfile' PKG_NAME=internal/service/sagemaker
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sagemaker/... -v -count 1 -parallel 20 -run=TestAccSageMaker_serial/UserProfile -timeout 180m
=== RUN   TestAccSageMaker_serial
=== RUN   TestAccSageMaker_serial/UserProfile
=== RUN   TestAccSageMaker_serial/UserProfile/basic
=== RUN   TestAccSageMaker_serial/UserProfile/disappears
=== RUN   TestAccSageMaker_serial/UserProfile/tensorboardAppSettings
=== RUN   TestAccSageMaker_serial/UserProfile/tensorboardAppSettingsWithImage
=== RUN   TestAccSageMaker_serial/UserProfile/jupyterServerAppSettings
=== RUN   TestAccSageMaker_serial/UserProfile/tags
=== RUN   TestAccSageMaker_serial/UserProfile/kernelGatewayAppSettings
=== RUN   TestAccSageMaker_serial/UserProfile/kernelGatewayAppSettings_lifecycleConfig
=== RUN   TestAccSageMaker_serial/UserProfile/kernelGatewayAppSettings_imageConfig
    user_profile_test.go:223: Environment variable SAGEMAKER_IMAGE_VERSION_BASE_IMAGE is not set
--- PASS: TestAccSageMaker_serial (2203.04s)
    --- PASS: TestAccSageMaker_serial/UserProfile (2203.04s)
        --- PASS: TestAccSageMaker_serial/UserProfile/basic (274.07s)
        --- PASS: TestAccSageMaker_serial/UserProfile/disappears (323.34s)
        --- PASS: TestAccSageMaker_serial/UserProfile/tensorboardAppSettings (266.62s)
        --- PASS: TestAccSageMaker_serial/UserProfile/tensorboardAppSettingsWithImage (267.17s)
        --- PASS: TestAccSageMaker_serial/UserProfile/jupyterServerAppSettings (265.02s)
        --- PASS: TestAccSageMaker_serial/UserProfile/tags (266.67s)
        --- PASS: TestAccSageMaker_serial/UserProfile/kernelGatewayAppSettings (268.95s)
        --- PASS: TestAccSageMaker_serial/UserProfile/kernelGatewayAppSettings_lifecycleConfig (271.18s)
        --- SKIP: TestAccSageMaker_serial/UserProfile/kernelGatewayAppSettings_imageConfig (0.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker	2206.050s

github-actions · 2022-01-06T23:55:03Z

This functionality has been released in v3.71.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2022-05-30T02:40:05Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

r/aws_sagemaker_domain: add arguments to DefaultResourceSpec

d9a0b11

DrFaust92 added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 26, 2021

DrFaust92 self-requested a review October 28, 2021 06:07

DrFaust92 suggested changes Oct 28, 2021

View reviewed changes

internal/service/sagemaker/domain.go Show resolved Hide resolved

philof added 2 commits November 2, 2021 19:23

github-actions bot added size/L Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels Nov 2, 2021

philof added 3 commits November 3, 2021 16:29

r/aws_sagemaker_user_profile: terrafmt

30c4c3e

r/aws_sagemaker_user_profile: providerlint

e28aeda

r/aws_sagemaker_user_profile: golangci-lint

e9dd9e9

Update docs & Add CHANGELOG entry

ba6ab7b

github-actions bot added the documentation Introduces or discusses updates to documentation. label Nov 8, 2021

github-actions bot added size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Nov 11, 2021

philof added 2 commits November 11, 2021 18:12

r/aws_sagemaker_app: providerlint

4f64033

r/aws_sagemaker_app: golangci-lint

aa17f68

DrFaust92 self-assigned this Nov 13, 2021

philof added 2 commits November 15, 2021 11:32

r/aws_sagemaker_domain: fix markdown-lint

dbaed13

DrFaust92 approved these changes Nov 26, 2021

View reviewed changes

DrFaust92 removed their assignment Nov 26, 2021

Update 21508.txt

5d3a1a0

ewbankkit approved these changes Jan 2, 2022

View reviewed changes

ewbankkit merged commit 6e9f9e9 into hashicorp:main Jan 3, 2022

github-actions bot added this to the v3.71.0 milestone Jan 3, 2022

ewbankkit mentioned this pull request Jan 3, 2022

Correct resource names in CHANGELOG entries #22389

Merged

github-actions bot locked as resolved and limited conversation to collaborators May 30, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

r/aws_sagemaker_domain: add arguments to DefaultResourceSpec #21508

r/aws_sagemaker_domain: add arguments to DefaultResourceSpec #21508

philof commented Oct 26, 2021

DrFaust92 commented Oct 28, 2021

DrFaust92 commented Nov 6, 2021

fatboysalimshady commented Nov 10, 2021 •

edited

Loading

DrFaust92 commented Nov 13, 2021

maldo91 commented Nov 22, 2021

DrFaust92 commented Nov 26, 2021 •

edited

Loading

DrFaust92 left a comment

maldo91 commented Dec 2, 2021

maldo91 commented Dec 10, 2021

ewbankkit left a comment •

edited

Loading

github-actions bot commented Jan 6, 2022

github-actions bot commented May 30, 2022

r/aws_sagemaker_domain: add arguments to DefaultResourceSpec #21508

r/aws_sagemaker_domain: add arguments to DefaultResourceSpec #21508

Conversation

philof commented Oct 26, 2021

Community Note

DrFaust92 commented Oct 28, 2021

DrFaust92 commented Nov 6, 2021

fatboysalimshady commented Nov 10, 2021 • edited Loading

DrFaust92 commented Nov 13, 2021

maldo91 commented Nov 22, 2021

DrFaust92 commented Nov 26, 2021 • edited Loading

DrFaust92 left a comment

Choose a reason for hiding this comment

maldo91 commented Dec 2, 2021

maldo91 commented Dec 10, 2021

ewbankkit left a comment • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Jan 6, 2022

github-actions bot commented May 30, 2022

fatboysalimshady commented Nov 10, 2021 •

edited

Loading

DrFaust92 commented Nov 26, 2021 •

edited

Loading

ewbankkit left a comment •

edited

Loading