Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider: cn-northwest-1 (Ningxia) hostedZoneID #21337

Merged
merged 2 commits into from
Oct 18, 2021

Conversation

PatMyron
Copy link
Contributor

@PatMyron PatMyron commented Oct 17, 2021

https://docs.aws.amazon.com/general/latest/gr/s3.html#s3_region, aws/aws-cdk#17024

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/s3 Issues and PRs that pertain to the s3 service. size/XS Managed by automation to categorize the size of a PR. labels Oct 17, 2021
@ewbankkit ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. service/s3 Issues and PRs that pertain to the s3 service. and removed service/s3 Issues and PRs that pertain to the s3 service. needs-triage Waiting for first response or review from a maintainer. labels Oct 18, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@ewbankkit
Copy link
Contributor

@PatMyron Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 4a8bb5c into hashicorp:main Oct 18, 2021
@github-actions github-actions bot added this to the v3.64.0 milestone Oct 18, 2021
@PatMyron PatMyron deleted the patch-1 branch October 18, 2021 19:07
mergify bot pushed a commit to aws/aws-cdk that referenced this pull request Oct 19, 2021
…ZONE_ID (#17024)


https://docs.aws.amazon.com/general/latest/gr/s3.html#s3_region, hashicorp/terraform-provider-aws#21337


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented Nov 4, 2021

This functionality has been released in v3.64.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
…ZONE_ID (aws#17024)


https://docs.aws.amazon.com/general/latest/gr/s3.html#s3_region, hashicorp/terraform-provider-aws#21337


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/s3 Issues and PRs that pertain to the s3 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants