Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DirectConnect Connection & LAG: provider_name -> Computed #21085

Merged
merged 3 commits into from
Sep 29, 2021

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Sep 29, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #21068.
Relates #17852.

Output from acceptance testing:

% make testacc TESTARGS='-run=TestAccAwsDxConnection_\|TestAccAwsDxLag_'                                                             
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsDxConnection_\|TestAccAwsDxLag_ -timeout 180m
=== RUN   TestAccAwsDxConnection_basic
=== PAUSE TestAccAwsDxConnection_basic
=== RUN   TestAccAwsDxConnection_disappears
=== PAUSE TestAccAwsDxConnection_disappears
=== RUN   TestAccAwsDxConnection_ProviderName
=== PAUSE TestAccAwsDxConnection_ProviderName
=== RUN   TestAccAwsDxConnection_Tags
=== PAUSE TestAccAwsDxConnection_Tags
=== RUN   TestAccAwsDxLag_basic
=== PAUSE TestAccAwsDxLag_basic
=== RUN   TestAccAwsDxLag_ProviderName
=== PAUSE TestAccAwsDxLag_ProviderName
=== RUN   TestAccAwsDxLag_disappears
=== PAUSE TestAccAwsDxLag_disappears
=== RUN   TestAccAwsDxLag_Tags
=== PAUSE TestAccAwsDxLag_Tags
=== CONT  TestAccAwsDxConnection_basic
=== CONT  TestAccAwsDxLag_ProviderName
=== CONT  TestAccAwsDxLag_basic
=== CONT  TestAccAwsDxLag_disappears
=== CONT  TestAccAwsDxConnection_Tags
=== CONT  TestAccAwsDxConnection_disappears
=== CONT  TestAccAwsDxLag_Tags
=== CONT  TestAccAwsDxConnection_ProviderName
--- PASS: TestAccAwsDxConnection_disappears (20.92s)
--- PASS: TestAccAwsDxLag_disappears (22.80s)
--- PASS: TestAccAwsDxConnection_basic (25.56s)
--- PASS: TestAccAwsDxConnection_ProviderName (27.93s)
--- PASS: TestAccAwsDxLag_ProviderName (28.42s)
--- PASS: TestAccAwsDxLag_basic (40.31s)
--- PASS: TestAccAwsDxConnection_Tags (51.05s)
--- PASS: TestAccAwsDxLag_Tags (54.65s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	58.220s

@github-actions github-actions bot added service/directconnect Issues and PRs that pertain to the directconnect service. size/XS Managed by automation to categorize the size of a PR. labels Sep 29, 2021
@ewbankkit ewbankkit added bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. labels Sep 29, 2021
@anGie44 anGie44 self-assigned this Sep 29, 2021
@ewbankkit ewbankkit merged commit be5ec82 into main Sep 29, 2021
@ewbankkit ewbankkit deleted the b-aws_dx_connection-provider_name-computed branch September 29, 2021 20:18
@github-actions github-actions bot added this to the v3.61.0 milestone Sep 29, 2021
github-actions bot pushed a commit that referenced this pull request Sep 29, 2021
@github-actions
Copy link

github-actions bot commented Oct 7, 2021

This functionality has been released in v3.61.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/directconnect Issues and PRs that pertain to the directconnect service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resource aws_dx_connection seems to be broken after introducing attribute provider_name in version v3.56.0
2 participants