Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider: Add HTTP proxy setting #21077

Merged
merged 3 commits into from
Sep 29, 2021
Merged

provider: Add HTTP proxy setting #21077

merged 3 commits into from
Sep 29, 2021

Conversation

gdavison
Copy link
Contributor

The AWS Provider currently supports the environment variables HTTP_PROXY or HTTPS_PROXY to configure an HTTP proxy. In some cases, only the AWS Provider or a specific instance of the AWS Provider need to traverse the proxy.

This PR allows setting the HTTP proxy at the level of the provider configuration.

Closes #14942

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. size/XS Managed by automation to categorize the size of a PR. labels Sep 28, 2021
@ewbankkit
Copy link
Contributor

Needs a CHANGELOG entry.

@ewbankkit ewbankkit self-assigned this Sep 29, 2021
ewbankkit
ewbankkit approved these changes Sep 29, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@ewbankkit ewbankkit removed their assignment Sep 29, 2021
@ewbankkit
Copy link
Contributor

It looks like go mod tidy needs running.

@gdavison
Copy link
Contributor Author

The failing check is due to a commit that removed the trailing newline from the go.mod file

@gdavison gdavison merged commit e80fb45 into main Sep 29, 2021
@gdavison gdavison deleted the add-http-proxy branch September 29, 2021 17:35
@github-actions github-actions bot added this to the v3.61.0 milestone Sep 29, 2021
github-actions bot pushed a commit that referenced this pull request Sep 29, 2021
Update CHANGELOG.md for #21077
615cd8b
@github-actions
Copy link

github-actions bot commented Oct 7, 2021

This functionality has been released in v3.61.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@gdavison gdavison mentioned this pull request Feb 24, 2022
Closed
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v3.61.0
Development

Successfully merging this pull request may close these issues.

Support for HTTP proxy in provider configuration
2 participants
@gdavison @ewbankkit