Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/sagemaker_studio_lifecycle_config - new resource + usage in domain and user profile #21041

Merged

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSSagemakerStudioLifecycleConfig_'
--- PASS: TestAccAWSSagemakerStudioLifecycleConfig_basic (55.73s)
--- PASS: TestAccAWSSagemakerStudioLifecycleConfig_tags (123.60s)
--- PASS: TestAccAWSSagemakerStudioLifecycleConfig_disappears (37.28s)

@github-actions github-actions bot added the size/XL Managed by automation to categorize the size of a PR. label Sep 24, 2021
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/sagemaker Issues and PRs that pertain to the sagemaker service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 24, 2021
@DrFaust92 DrFaust92 marked this pull request as draft September 24, 2021 20:10
@DrFaust92 DrFaust92 changed the title r/sagemaker_studio_lifecycle_config - new resource r/sagemaker_studio_lifecycle_config - new resource + usage in domain and user profile Sep 24, 2021
@DrFaust92 DrFaust92 marked this pull request as ready for review September 25, 2021 15:41
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TESTARGS='-run=TestAccAWSSagemakerStudioLifecycleConfig_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerStudioLifecycleConfig_ -timeout 180m
=== RUN   TestAccAWSSagemakerStudioLifecycleConfig_basic
--- PASS: TestAccAWSSagemakerStudioLifecycleConfig_basic (17.38s)
=== RUN   TestAccAWSSagemakerStudioLifecycleConfig_tags
--- PASS: TestAccAWSSagemakerStudioLifecycleConfig_tags (34.60s)
=== RUN   TestAccAWSSagemakerStudioLifecycleConfig_disappears
--- PASS: TestAccAWSSagemakerStudioLifecycleConfig_disappears (9.76s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	66.126s
% make testacc TESTARGS='-run=TestAccAWSSagemaker_serial/Domain'        
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemaker_serial/Domain -timeout 180m
=== RUN   TestAccAWSSagemaker_serial
=== RUN   TestAccAWSSagemaker_serial/Domain
=== RUN   TestAccAWSSagemaker_serial/Domain/basic
=== RUN   TestAccAWSSagemaker_serial/Domain/kernelGatewayAppSettings_customImage
    resource_aws_sagemaker_domain_test.go:380: Environment variable SAGEMAKER_IMAGE_VERSION_BASE_IMAGE is not set
=== RUN   TestAccAWSSagemaker_serial/Domain/kernelGatewayAppSettings_lifecycleConfig
=== RUN   TestAccAWSSagemaker_serial/Domain/securityGroup
=== RUN   TestAccAWSSagemaker_serial/Domain/sharingSettings
=== RUN   TestAccAWSSagemaker_serial/Domain/kms
=== RUN   TestAccAWSSagemaker_serial/Domain/disappears
=== RUN   TestAccAWSSagemaker_serial/Domain/tags
=== RUN   TestAccAWSSagemaker_serial/Domain/tensorboardAppSettings
=== RUN   TestAccAWSSagemaker_serial/Domain/tensorboardAppSettingsWithImage
=== RUN   TestAccAWSSagemaker_serial/Domain/kernelGatewayAppSettings
=== RUN   TestAccAWSSagemaker_serial/Domain/jupyterServerAppSettings
--- PASS: TestAccAWSSagemaker_serial (2903.34s)
    --- PASS: TestAccAWSSagemaker_serial/Domain (2903.34s)
        --- PASS: TestAccAWSSagemaker_serial/Domain/basic (244.82s)
        --- SKIP: TestAccAWSSagemaker_serial/Domain/kernelGatewayAppSettings_customImage (0.00s)
        --- PASS: TestAccAWSSagemaker_serial/Domain/kernelGatewayAppSettings_lifecycleConfig (244.67s)
        --- PASS: TestAccAWSSagemaker_serial/Domain/securityGroup (271.63s)
        --- PASS: TestAccAWSSagemaker_serial/Domain/sharingSettings (248.18s)
        --- PASS: TestAccAWSSagemaker_serial/Domain/kms (244.89s)
        --- PASS: TestAccAWSSagemaker_serial/Domain/disappears (296.08s)
        --- PASS: TestAccAWSSagemaker_serial/Domain/tags (250.31s)
        --- PASS: TestAccAWSSagemaker_serial/Domain/tensorboardAppSettings (245.93s)
        --- PASS: TestAccAWSSagemaker_serial/Domain/tensorboardAppSettingsWithImage (354.26s)
        --- PASS: TestAccAWSSagemaker_serial/Domain/kernelGatewayAppSettings (255.58s)
        --- PASS: TestAccAWSSagemaker_serial/Domain/jupyterServerAppSettings (246.97s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	2906.565s
% make testacc TESTARGS='-run=TestAccAWSSagemaker_serial/UserProfile'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemaker_serial/UserProfile -timeout 180m
=== RUN   TestAccAWSSagemaker_serial
=== RUN   TestAccAWSSagemaker_serial/UserProfile
=== RUN   TestAccAWSSagemaker_serial/UserProfile/jupyterServerAppSettings
=== RUN   TestAccAWSSagemaker_serial/UserProfile/basic
=== RUN   TestAccAWSSagemaker_serial/UserProfile/disappears
=== RUN   TestAccAWSSagemaker_serial/UserProfile/tags
=== RUN   TestAccAWSSagemaker_serial/UserProfile/tensorboardAppSettings
=== RUN   TestAccAWSSagemaker_serial/UserProfile/tensorboardAppSettingsWithImage
=== RUN   TestAccAWSSagemaker_serial/UserProfile/kernelGatewayAppSettings
=== RUN   TestAccAWSSagemaker_serial/UserProfile/kernelGatewayAppSettings_lifecycleConfig
--- PASS: TestAccAWSSagemaker_serial (2068.84s)
    --- PASS: TestAccAWSSagemaker_serial/UserProfile (2068.84s)
        --- PASS: TestAccAWSSagemaker_serial/UserProfile/jupyterServerAppSettings (256.96s)
        --- PASS: TestAccAWSSagemaker_serial/UserProfile/basic (253.26s)
        --- PASS: TestAccAWSSagemaker_serial/UserProfile/disappears (293.69s)
        --- PASS: TestAccAWSSagemaker_serial/UserProfile/tags (248.92s)
        --- PASS: TestAccAWSSagemaker_serial/UserProfile/tensorboardAppSettings (252.18s)
        --- PASS: TestAccAWSSagemaker_serial/UserProfile/tensorboardAppSettingsWithImage (256.23s)
        --- PASS: TestAccAWSSagemaker_serial/UserProfile/kernelGatewayAppSettings (254.57s)
        --- PASS: TestAccAWSSagemaker_serial/UserProfile/kernelGatewayAppSettings_lifecycleConfig (254.62s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	2072.590s
GovCloud
% make testacc TESTARGS='-run=TestAccAWSSagemakerStudioLifecycleConfig_'                                                                       
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerStudioLifecycleConfig_ -timeout 180m
=== RUN   TestAccAWSSagemakerStudioLifecycleConfig_basic
    provider_test.go:1166: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating SageMaker Studio Lifecycle Config (tf-acc-test-3222345105382646143): UnknownOperationException: 
        	status code: 400, request id: d7bcf260-9ae1-4a11-bc16-3a24094c429d
        
          with aws_sagemaker_studio_lifecycle_config.test,
          on terraform_plugin_test.tf line 2, in resource "aws_sagemaker_studio_lifecycle_config" "test":
           2: resource "aws_sagemaker_studio_lifecycle_config" "test" {
        
--- SKIP: TestAccAWSSagemakerStudioLifecycleConfig_basic (7.10s)
=== RUN   TestAccAWSSagemakerStudioLifecycleConfig_tags
    provider_test.go:1166: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating SageMaker Studio Lifecycle Config (tf-acc-test-8921054896267421618): UnknownOperationException: 
        	status code: 400, request id: 038e78c4-408f-427a-b495-2368108ae297
        
          with aws_sagemaker_studio_lifecycle_config.test,
          on terraform_plugin_test.tf line 2, in resource "aws_sagemaker_studio_lifecycle_config" "test":
           2: resource "aws_sagemaker_studio_lifecycle_config" "test" {
        
--- SKIP: TestAccAWSSagemakerStudioLifecycleConfig_tags (5.51s)
=== RUN   TestAccAWSSagemakerStudioLifecycleConfig_disappears
    provider_test.go:1166: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating SageMaker Studio Lifecycle Config (tf-acc-test-1260094885660971949): UnknownOperationException: 
        	status code: 400, request id: f95ec3da-b0a6-4ad7-acbd-4c975f5cde6b
        
          with aws_sagemaker_studio_lifecycle_config.test,
          on terraform_plugin_test.tf line 2, in resource "aws_sagemaker_studio_lifecycle_config" "test":
           2: resource "aws_sagemaker_studio_lifecycle_config" "test" {
        
--- SKIP: TestAccAWSSagemakerStudioLifecycleConfig_disappears (5.49s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	21.380s
% make testacc TESTARGS='-run=TestAccAWSSagemaker_serial/Domain'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemaker_serial/Domain -timeout 180m
=== RUN   TestAccAWSSagemaker_serial
=== RUN   TestAccAWSSagemaker_serial/Domain
=== RUN   TestAccAWSSagemaker_serial/Domain/jupyterServerAppSettings
    provider_test.go:1166: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating SageMaker domain: UnknownOperationException: The requested operation is not supported in the called region.
        	status code: 400, request id: f18e1e2e-75d3-42aa-b65e-145f8bbeaa74
        
          with aws_sagemaker_domain.test,
          on terraform_plugin_test.tf line 43, in resource "aws_sagemaker_domain" "test":
          43: resource "aws_sagemaker_domain" "test" {
        
=== RUN   TestAccAWSSagemaker_serial/Domain/kms
    provider_test.go:1166: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating SageMaker domain: UnknownOperationException: The requested operation is not supported in the called region.
        	status code: 400, request id: 4db5116b-6029-4f37-ad5d-665807cd71d4
        
          with aws_sagemaker_domain.test,
          on terraform_plugin_test.tf line 48, in resource "aws_sagemaker_domain" "test":
          48: resource "aws_sagemaker_domain" "test" {
        
=== RUN   TestAccAWSSagemaker_serial/Domain/sharingSettings
    provider_test.go:1166: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating SageMaker domain: UnknownOperationException: The requested operation is not supported in the called region.
        	status code: 400, request id: cdc99b0d-7459-4aaf-bbb3-aa1142710d92
        
          with aws_sagemaker_domain.test,
          on terraform_plugin_test.tf line 54, in resource "aws_sagemaker_domain" "test":
          54: resource "aws_sagemaker_domain" "test" {
        
=== RUN   TestAccAWSSagemaker_serial/Domain/disappears
    provider_test.go:1166: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating SageMaker domain: UnknownOperationException: The requested operation is not supported in the called region.
        	status code: 400, request id: 2bc7cc0b-0e13-4f03-a73d-c98aa878618f
        
          with aws_sagemaker_domain.test,
          on terraform_plugin_test.tf line 43, in resource "aws_sagemaker_domain" "test":
          43: resource "aws_sagemaker_domain" "test" {
        
=== RUN   TestAccAWSSagemaker_serial/Domain/tensorboardAppSettings
    provider_test.go:1166: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating SageMaker domain: UnknownOperationException: The requested operation is not supported in the called region.
        	status code: 400, request id: f7095b2b-0779-44f9-8031-e9cc8fba468b
        
          with aws_sagemaker_domain.test,
          on terraform_plugin_test.tf line 43, in resource "aws_sagemaker_domain" "test":
          43: resource "aws_sagemaker_domain" "test" {
        
=== RUN   TestAccAWSSagemaker_serial/Domain/kernelGatewayAppSettings
    provider_test.go:1166: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating SageMaker domain: UnknownOperationException: The requested operation is not supported in the called region.
        	status code: 400, request id: a5124dfd-39a3-4fb0-9784-74825cd6a02b
        
          with aws_sagemaker_domain.test,
          on terraform_plugin_test.tf line 43, in resource "aws_sagemaker_domain" "test":
          43: resource "aws_sagemaker_domain" "test" {
        
=== RUN   TestAccAWSSagemaker_serial/Domain/kernelGatewayAppSettings_customImage
    resource_aws_sagemaker_domain_test.go:380: Environment variable SAGEMAKER_IMAGE_VERSION_BASE_IMAGE is not set
=== RUN   TestAccAWSSagemaker_serial/Domain/kernelGatewayAppSettings_lifecycleConfig
    provider_test.go:1166: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating SageMaker Studio Lifecycle Config (tf-acc-test-8896600867147537051): UnknownOperationException: 
        	status code: 400, request id: 0640da09-25f6-4142-b103-7fc101ba68ba
        
          with aws_sagemaker_studio_lifecycle_config.test,
          on terraform_plugin_test.tf line 43, in resource "aws_sagemaker_studio_lifecycle_config" "test":
          43: resource "aws_sagemaker_studio_lifecycle_config" "test" {
        
=== RUN   TestAccAWSSagemaker_serial/Domain/basic
    provider_test.go:1166: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating SageMaker domain: UnknownOperationException: The requested operation is not supported in the called region.
        	status code: 400, request id: 340f0fb7-ebb2-4ebb-be41-13f4b4c536c4
        
          with aws_sagemaker_domain.test,
          on terraform_plugin_test.tf line 43, in resource "aws_sagemaker_domain" "test":
          43: resource "aws_sagemaker_domain" "test" {
        
=== RUN   TestAccAWSSagemaker_serial/Domain/tags
    provider_test.go:1166: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating SageMaker domain: UnknownOperationException: The requested operation is not supported in the called region.
        	status code: 400, request id: 5a0e8d58-ceb9-4c1a-80c9-be38fe9f9efe
        
          with aws_sagemaker_domain.test,
          on terraform_plugin_test.tf line 43, in resource "aws_sagemaker_domain" "test":
          43: resource "aws_sagemaker_domain" "test" {
        
=== RUN   TestAccAWSSagemaker_serial/Domain/tensorboardAppSettingsWithImage
    provider_test.go:1166: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating SageMaker Image tf-acc-test-6881573892223694546: UnknownOperationException: The requested operation is not supported in the called region.
        	status code: 400, request id: c0a5aeea-25df-4db1-a612-0a2742b28128
        
          with aws_sagemaker_image.test,
          on terraform_plugin_test.tf line 43, in resource "aws_sagemaker_image" "test":
          43: resource "aws_sagemaker_image" "test" {
        
=== RUN   TestAccAWSSagemaker_serial/Domain/securityGroup
    provider_test.go:1166: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating SageMaker domain: UnknownOperationException: The requested operation is not supported in the called region.
        	status code: 400, request id: 76b96358-ed7d-4ae7-a6ac-8ad4f7d3ea01
        
          with aws_sagemaker_domain.test,
          on terraform_plugin_test.tf line 47, in resource "aws_sagemaker_domain" "test":
          47: resource "aws_sagemaker_domain" "test" {
        
--- PASS: TestAccAWSSagemaker_serial (226.89s)
    --- PASS: TestAccAWSSagemaker_serial/Domain (226.89s)
        --- SKIP: TestAccAWSSagemaker_serial/Domain/jupyterServerAppSettings (18.03s)
        --- SKIP: TestAccAWSSagemaker_serial/Domain/kms (14.47s)
        --- SKIP: TestAccAWSSagemaker_serial/Domain/sharingSettings (15.92s)
        --- SKIP: TestAccAWSSagemaker_serial/Domain/disappears (15.24s)
        --- SKIP: TestAccAWSSagemaker_serial/Domain/tensorboardAppSettings (16.49s)
        --- SKIP: TestAccAWSSagemaker_serial/Domain/kernelGatewayAppSettings (15.28s)
        --- SKIP: TestAccAWSSagemaker_serial/Domain/kernelGatewayAppSettings_customImage (0.00s)
        --- SKIP: TestAccAWSSagemaker_serial/Domain/kernelGatewayAppSettings_lifecycleConfig (14.38s)
        --- SKIP: TestAccAWSSagemaker_serial/Domain/basic (14.74s)
        --- SKIP: TestAccAWSSagemaker_serial/Domain/tags (16.40s)
        --- SKIP: TestAccAWSSagemaker_serial/Domain/tensorboardAppSettingsWithImage (70.59s)
        --- SKIP: TestAccAWSSagemaker_serial/Domain/securityGroup (15.34s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	230.121s
% make testacc TESTARGS='-run=TestAccAWSSagemaker_serial/UserProfile'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemaker_serial/UserProfile -timeout 180m
=== RUN   TestAccAWSSagemaker_serial
=== RUN   TestAccAWSSagemaker_serial/UserProfile
=== RUN   TestAccAWSSagemaker_serial/UserProfile/tags
    provider_test.go:1166: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating SageMaker domain: UnknownOperationException: The requested operation is not supported in the called region.
        	status code: 400, request id: 8f8efc30-c87e-40a2-bbd0-da0e0ae9bf57
        
          with aws_sagemaker_domain.test,
          on terraform_plugin_test.tf line 36, in resource "aws_sagemaker_domain" "test":
          36: resource "aws_sagemaker_domain" "test" {
        
=== RUN   TestAccAWSSagemaker_serial/UserProfile/tensorboardAppSettings
    provider_test.go:1166: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating SageMaker domain: UnknownOperationException: The requested operation is not supported in the called region.
        	status code: 400, request id: b547d0c5-f566-4094-85e6-0c415eabf6f2
        
          with aws_sagemaker_domain.test,
          on terraform_plugin_test.tf line 36, in resource "aws_sagemaker_domain" "test":
          36: resource "aws_sagemaker_domain" "test" {
        
=== RUN   TestAccAWSSagemaker_serial/UserProfile/tensorboardAppSettingsWithImage
    provider_test.go:1166: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating SageMaker domain: UnknownOperationException: The requested operation is not supported in the called region.
        	status code: 400, request id: 7f7fe518-22c5-4c89-85c6-f38bbdf8dd47
        
          with aws_sagemaker_domain.test,
          on terraform_plugin_test.tf line 36, in resource "aws_sagemaker_domain" "test":
          36: resource "aws_sagemaker_domain" "test" {
        
        
        Error: error creating SageMaker Image tf-acc-test-4365608291143385255: UnknownOperationException: The requested operation is not supported in the called region.
        	status code: 400, request id: 033df89c-4ddf-4efd-9c08-afa91e3fe406
        
          with aws_sagemaker_image.test,
          on terraform_plugin_test.tf line 51, in resource "aws_sagemaker_image" "test":
          51: resource "aws_sagemaker_image" "test" {
        
=== RUN   TestAccAWSSagemaker_serial/UserProfile/kernelGatewayAppSettings
    provider_test.go:1166: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating SageMaker domain: UnknownOperationException: The requested operation is not supported in the called region.
        	status code: 400, request id: 53ebac94-3e83-458c-bcfc-038ccb5fc7e7
        
          with aws_sagemaker_domain.test,
          on terraform_plugin_test.tf line 36, in resource "aws_sagemaker_domain" "test":
          36: resource "aws_sagemaker_domain" "test" {
        
=== RUN   TestAccAWSSagemaker_serial/UserProfile/kernelGatewayAppSettings_lifecycleConfig
    provider_test.go:1166: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating SageMaker domain: UnknownOperationException: The requested operation is not supported in the called region.
        	status code: 400, request id: 885f6432-63ee-44ea-811a-10890831d183
        
          with aws_sagemaker_domain.test,
          on terraform_plugin_test.tf line 36, in resource "aws_sagemaker_domain" "test":
          36: resource "aws_sagemaker_domain" "test" {
        
        
        Error: error creating SageMaker Studio Lifecycle Config (tf-acc-test-8177780271478995843): UnknownOperationException: 
        	status code: 400, request id: 99c72fab-ba4c-43f5-9392-c0b0bb7db0c9
        
          with aws_sagemaker_studio_lifecycle_config.test,
          on terraform_plugin_test.tf line 51, in resource "aws_sagemaker_studio_lifecycle_config" "test":
          51: resource "aws_sagemaker_studio_lifecycle_config" "test" {
        
=== RUN   TestAccAWSSagemaker_serial/UserProfile/jupyterServerAppSettings
    provider_test.go:1166: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating SageMaker domain: UnknownOperationException: The requested operation is not supported in the called region.
        	status code: 400, request id: 80587b19-e679-4d95-9966-1265135e33ef
        
          with aws_sagemaker_domain.test,
          on terraform_plugin_test.tf line 36, in resource "aws_sagemaker_domain" "test":
          36: resource "aws_sagemaker_domain" "test" {
        
=== RUN   TestAccAWSSagemaker_serial/UserProfile/basic
    provider_test.go:1166: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating SageMaker domain: UnknownOperationException: The requested operation is not supported in the called region.
        	status code: 400, request id: e78f607c-4812-48f2-8a2c-22d233330048
        
          with aws_sagemaker_domain.test,
          on terraform_plugin_test.tf line 36, in resource "aws_sagemaker_domain" "test":
          36: resource "aws_sagemaker_domain" "test" {
        
=== RUN   TestAccAWSSagemaker_serial/UserProfile/disappears
    provider_test.go:1166: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating SageMaker domain: UnknownOperationException: The requested operation is not supported in the called region.
        	status code: 400, request id: 05769332-c6e9-4fe1-b737-15291a643c73
        
          with aws_sagemaker_domain.test,
          on terraform_plugin_test.tf line 36, in resource "aws_sagemaker_domain" "test":
          36: resource "aws_sagemaker_domain" "test" {
        
--- PASS: TestAccAWSSagemaker_serial (178.37s)
    --- PASS: TestAccAWSSagemaker_serial/UserProfile (178.37s)
        --- SKIP: TestAccAWSSagemaker_serial/UserProfile/tags (16.58s)
        --- SKIP: TestAccAWSSagemaker_serial/UserProfile/tensorboardAppSettings (15.15s)
        --- SKIP: TestAccAWSSagemaker_serial/UserProfile/tensorboardAppSettingsWithImage (71.00s)
        --- SKIP: TestAccAWSSagemaker_serial/UserProfile/kernelGatewayAppSettings (16.23s)
        --- SKIP: TestAccAWSSagemaker_serial/UserProfile/kernelGatewayAppSettings_lifecycleConfig (15.38s)
        --- SKIP: TestAccAWSSagemaker_serial/UserProfile/jupyterServerAppSettings (14.42s)
        --- SKIP: TestAccAWSSagemaker_serial/UserProfile/basic (14.47s)
        --- SKIP: TestAccAWSSagemaker_serial/UserProfile/disappears (15.14s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	181.560s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit acf2c8b into hashicorp:main Sep 27, 2021
@github-actions github-actions bot added this to the v3.61.0 milestone Sep 27, 2021
@DrFaust92 DrFaust92 deleted the r/sagemaker_studio_lifecycle_config branch September 27, 2021 15:39
@github-actions
Copy link

github-actions bot commented Oct 7, 2021

This functionality has been released in v3.61.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@DrFaust92 DrFaust92 restored the r/sagemaker_studio_lifecycle_config branch October 7, 2021 19:02
@DrFaust92 DrFaust92 deleted the r/sagemaker_studio_lifecycle_config branch October 7, 2021 19:02
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/sagemaker Issues and PRs that pertain to the sagemaker service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants