BugFix: Add bypass_file_system_lockout_safety_check to efs efs_file_system_policy

[tommrr]

Allow the ability to bypass the EFS file system lockout protection.

The fix is to allow pass through from of the 'BypassPolicyLockoutSafetyCheck' to the underlying GoSDK.

This is the error that the fix is for, where unable to create or update an filesystem policy.

Error: error creating EFS File System Policy "": InvalidPolicyException: This policy would prevent future FileSystemPolicy updates. Retry the request with the BypassPolicyLockoutSafetyCheck parameter to apply this policy.

Tested against our test environment.

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

[github-actions]

Welcome @tomrosier 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[ewbankkit]

LGTM 🚀.

Commercial

% make testacc TESTARGS='-run=TestAccAWSEFSFileSystemPolicy_'                      
TestAccAWSEFSFileSystemPolicy_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEFSFileSystemPolicy_ -timeout 180m
=== RUN   TestAccAWSEFSFileSystemPolicy_basic
=== PAUSE TestAccAWSEFSFileSystemPolicy_basic
=== RUN   TestAccAWSEFSFileSystemPolicy_disappears
=== PAUSE TestAccAWSEFSFileSystemPolicy_disappears
=== RUN   TestAccAWSEFSFileSystemPolicy_PolicyBypass
=== PAUSE TestAccAWSEFSFileSystemPolicy_PolicyBypass
=== CONT  TestAccAWSEFSFileSystemPolicy_basic
=== CONT  TestAccAWSEFSFileSystemPolicy_PolicyBypass
=== CONT  TestAccAWSEFSFileSystemPolicy_disappears
--- PASS: TestAccAWSEFSFileSystemPolicy_disappears (23.81s)
--- PASS: TestAccAWSEFSFileSystemPolicy_basic (36.74s)
--- PASS: TestAccAWSEFSFileSystemPolicy_PolicyBypass (37.40s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	41.244s

GovCloud

% make testacc TESTARGS='-run=TestAccAWSEFSFileSystemPolicy_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEFSFileSystemPolicy_ -timeout 180m
=== RUN   TestAccAWSEFSFileSystemPolicy_basic
=== PAUSE TestAccAWSEFSFileSystemPolicy_basic
=== RUN   TestAccAWSEFSFileSystemPolicy_disappears
=== PAUSE TestAccAWSEFSFileSystemPolicy_disappears
=== RUN   TestAccAWSEFSFileSystemPolicy_PolicyBypass
=== PAUSE TestAccAWSEFSFileSystemPolicy_PolicyBypass
=== CONT  TestAccAWSEFSFileSystemPolicy_basic
=== CONT  TestAccAWSEFSFileSystemPolicy_PolicyBypass
=== CONT  TestAccAWSEFSFileSystemPolicy_disappears
--- PASS: TestAccAWSEFSFileSystemPolicy_disappears (27.16s)
--- PASS: TestAccAWSEFSFileSystemPolicy_basic (44.23s)
--- PASS: TestAccAWSEFSFileSystemPolicy_PolicyBypass (44.28s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	47.484s

[ewbankkit]

@tomrosier Thanks for the contribution 🎉 👏.
I changed the new argument name from bypass_file_system_lockout_safety_check to bypass_policy_lockout_safety_check to mirror the underlying AWS API.

[github-actions]

This functionality has been released in v3.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.