Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configuration_set on aws_cognito_user_pool always detected as a change #20791

Conversation

Puneeth-n
Copy link
Contributor

@Puneeth-n Puneeth-n commented Sep 3, 2021

closes #20755

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

root@47307cab8cc7:/go/src/github.com/terraform-providers/terraform-provider-aws# TEST_AWS_SES_VERIFIED_EMAIL_ARN=arn:aws:ses:us-east-1:01234567890:identity/[email protected] make testacc ACCTEST_PARALLELISM=1 TESTARGS='-run=TestAccAWSCognitoUserPool_withEmailConfigurationSource'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 1 -run=TestAccAWSCognitoUserPool_withEmailConfigurationSource -timeout 180m
=== RUN   TestAccAWSCognitoUserPool_withEmailConfigurationSource
=== PAUSE TestAccAWSCognitoUserPool_withEmailConfigurationSource
=== CONT  TestAccAWSCognitoUserPool_withEmailConfigurationSource
--- PASS: TestAccAWSCognitoUserPool_withEmailConfigurationSource (46.56s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	46.716s
root@47307cab8cc7:/go/src/github.com/terraform-providers/terraform-provider-aws#

@Puneeth-n Puneeth-n changed the title Set configuration_set configuration_set on aws_cognito_user_pool always detected as a change Sep 3, 2021
@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/cognito labels Sep 3, 2021
@breathingdust breathingdust added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 3, 2021
@Puneeth-n
Copy link
Contributor Author

@teamterraform @breathingdust I re-ran the tests by setting up a test email identity :)

Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@ewbankkit
Copy link
Contributor

@Puneeth-n Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 65ebfbf into hashicorp:main Sep 11, 2021
ewbankkit added a commit that referenced this pull request Sep 11, 2021
@Puneeth-n Puneeth-n deleted the fix/cognito-user-pool-email-configuration-configuration-set branch September 13, 2021 05:15
@breathingdust breathingdust added this to the v3.59.0 milestone Sep 16, 2021
@github-actions
Copy link

This functionality has been released in v3.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

configuration_set on aws_cognito_user_pool always detected as a change
3 participants