Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_eks_addon: Update addon versions for TestAccAWSEksAddon_AddonVersion #20562

Merged
merged 2 commits into from
Aug 18, 2021

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Aug 13, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #20559.
Closes #20404.

Output from acceptance testing:

% make testacc TESTARGS='-run=TestAccAWSEksAddon_'                                             
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEksAddon_ -timeout 180m
=== RUN   TestAccAWSEksAddon_basic
=== PAUSE TestAccAWSEksAddon_basic
=== RUN   TestAccAWSEksAddon_disappears
=== PAUSE TestAccAWSEksAddon_disappears
=== RUN   TestAccAWSEksAddon_disappears_Cluster
=== PAUSE TestAccAWSEksAddon_disappears_Cluster
=== RUN   TestAccAWSEksAddon_AddonVersion
=== PAUSE TestAccAWSEksAddon_AddonVersion
=== RUN   TestAccAWSEksAddon_ResolveConflicts
=== PAUSE TestAccAWSEksAddon_ResolveConflicts
=== RUN   TestAccAWSEksAddon_ServiceAccountRoleArn
=== PAUSE TestAccAWSEksAddon_ServiceAccountRoleArn
=== RUN   TestAccAWSEksAddon_Tags
=== PAUSE TestAccAWSEksAddon_Tags
=== RUN   TestAccAWSEksAddon_defaultTags_providerOnly
=== PAUSE TestAccAWSEksAddon_defaultTags_providerOnly
=== RUN   TestAccAWSEksAddon_defaultTags_updateToProviderOnly
=== PAUSE TestAccAWSEksAddon_defaultTags_updateToProviderOnly
=== RUN   TestAccAWSEksAddon_defaultTags_updateToResourceOnly
=== PAUSE TestAccAWSEksAddon_defaultTags_updateToResourceOnly
=== RUN   TestAccAWSEksAddon_defaultTags_providerAndResource_nonOverlappingTag
=== PAUSE TestAccAWSEksAddon_defaultTags_providerAndResource_nonOverlappingTag
=== RUN   TestAccAWSEksAddon_defaultTags_providerAndResource_overlappingTag
=== PAUSE TestAccAWSEksAddon_defaultTags_providerAndResource_overlappingTag
=== RUN   TestAccAWSEksAddon_defaultTags_providerAndResource_duplicateTag
=== PAUSE TestAccAWSEksAddon_defaultTags_providerAndResource_duplicateTag
=== RUN   TestAccAWSEksAddon_defaultAndIgnoreTags
=== PAUSE TestAccAWSEksAddon_defaultAndIgnoreTags
=== RUN   TestAccAWSEksAddon_ignoreTags
=== PAUSE TestAccAWSEksAddon_ignoreTags
=== CONT  TestAccAWSEksAddon_basic
=== CONT  TestAccAWSEksAddon_defaultAndIgnoreTags
=== CONT  TestAccAWSEksAddon_defaultTags_providerAndResource_duplicateTag
=== CONT  TestAccAWSEksAddon_defaultTags_updateToResourceOnly
=== CONT  TestAccAWSEksAddon_defaultTags_providerAndResource_overlappingTag
=== CONT  TestAccAWSEksAddon_ServiceAccountRoleArn
=== CONT  TestAccAWSEksAddon_defaultTags_updateToProviderOnly
=== CONT  TestAccAWSEksAddon_ignoreTags
=== CONT  TestAccAWSEksAddon_Tags
=== CONT  TestAccAWSEksAddon_defaultTags_providerOnly
=== CONT  TestAccAWSEksAddon_disappears_Cluster
=== CONT  TestAccAWSEksAddon_disappears
=== CONT  TestAccAWSEksAddon_defaultTags_providerAndResource_nonOverlappingTag
=== CONT  TestAccAWSEksAddon_ResolveConflicts
=== CONT  TestAccAWSEksAddon_AddonVersion
--- PASS: TestAccAWSEksAddon_defaultTags_providerAndResource_duplicateTag (8.19s)
--- PASS: TestAccAWSEksAddon_defaultAndIgnoreTags (706.18s)
--- PASS: TestAccAWSEksAddon_Tags (737.67s)
--- PASS: TestAccAWSEksAddon_defaultTags_providerAndResource_overlappingTag (742.59s)
--- PASS: TestAccAWSEksAddon_disappears_Cluster (769.20s)
--- PASS: TestAccAWSEksAddon_defaultTags_updateToResourceOnly (807.04s)
--- PASS: TestAccAWSEksAddon_defaultTags_providerOnly (827.16s)
--- PASS: TestAccAWSEksAddon_ServiceAccountRoleArn (827.61s)
--- PASS: TestAccAWSEksAddon_defaultTags_providerAndResource_nonOverlappingTag (833.54s)
--- PASS: TestAccAWSEksAddon_defaultTags_updateToProviderOnly (838.97s)
--- PASS: TestAccAWSEksAddon_basic (848.20s)
--- PASS: TestAccAWSEksAddon_ignoreTags (857.08s)
--- PASS: TestAccAWSEksAddon_AddonVersion (860.12s)
--- PASS: TestAccAWSEksAddon_ResolveConflicts (880.88s)
--- PASS: TestAccAWSEksAddon_disappears (938.30s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       941.907s

@github-actions github-actions bot added service/eks Issues and PRs that pertain to the eks service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XS Managed by automation to categorize the size of a PR. labels Aug 13, 2021
Copy link
Member

@breathingdust breathingdust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@ewbankkit ewbankkit merged commit 0c74f25 into main Aug 18, 2021
@ewbankkit ewbankkit deleted the t-aws_eks_addon-version branch August 18, 2021 20:31
@github-actions github-actions bot added this to the v3.55.0 milestone Aug 18, 2021
@github-actions
Copy link

This functionality has been released in v3.55.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/eks Issues and PRs that pertain to the eks service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
2 participants