New resource for AppStream Fleet

[coderGo93]

Added a new resource, docs and tests for AppStream Fleet called aws_appstream_fleet

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #6508

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAwsAppStreamFleet'                                
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsAppStreamFleet -timeout 180m
=== RUN   TestAccAwsAppStreamFleet_basic
=== PAUSE TestAccAwsAppStreamFleet_basic
=== RUN   TestAccAwsAppStreamFleet_disappears
=== PAUSE TestAccAwsAppStreamFleet_disappears
=== RUN   TestAccAwsAppStreamFleet_completeWithStop
=== PAUSE TestAccAwsAppStreamFleet_completeWithStop
=== RUN   TestAccAwsAppStreamFleet_completeWithoutStop
=== PAUSE TestAccAwsAppStreamFleet_completeWithoutStop
=== RUN   TestAccAwsAppStreamFleet_withTags
=== PAUSE TestAccAwsAppStreamFleet_withTags
=== CONT  TestAccAwsAppStreamFleet_basic
=== CONT  TestAccAwsAppStreamFleet_completeWithoutStop
=== CONT  TestAccAwsAppStreamFleet_withTags
=== CONT  TestAccAwsAppStreamFleet_completeWithStop
=== CONT  TestAccAwsAppStreamFleet_disappears
--- PASS: TestAccAwsAppStreamFleet_disappears (746.95s)
--- PASS: TestAccAwsAppStreamFleet_basic (785.69s)
--- PASS: TestAccAwsAppStreamFleet_withTags (1419.06s)
--- PASS: TestAccAwsAppStreamFleet_completeWithoutStop (1800.00s)
--- PASS: TestAccAwsAppStreamFleet_completeWithStop (2630.85s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       2630.990s

[YakDriver]

@coderGo93 Overall, an excellent start to this resource! Thank you! Please see comments below.

[YakDriver]

This resource seems to be working fairly well. However, in acceptance testing, it seems to leave resources around. That combined with a lack of a sweeper is a bad combination. At this point, this needs 1. a sweeper, 2. debugging around why it's not destroying all resources - why tests aren't catching it...

[YakDriver]

Looks good! 👍

Subsequently, we need a sweeper and the waiter needs work for the unusual handling of errors on AWS side.

Output from acceptance tests (us-west-2):

--- PASS: TestAccAwsAppStreamFleet_basic (890.28s)
--- PASS: TestAccAwsAppStreamFleet_disappears (917.92s)
--- PASS: TestAccAwsAppStreamFleet_completeWithoutStop (936.91s)
--- PASS: TestAccAwsAppStreamFleet_withTags (958.20s)
--- PASS: TestAccAwsAppStreamFleet_completeWithStop (1775.73s)

--- PASS: TestAccAWSCodeStarConnectionsHost_vpcConfig (494.73s)
--- PASS: TestAccAWSDataSourceIAMGroup_basic (10.46s)
--- PASS: TestAccAWSDataSourceIAMRole_tags (10.57s)
--- PASS: TestAccAWSSQSQueuePolicy_basic (26.19s)

[github-actions]

This functionality has been released in v3.60.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.