aws route53recoveryreadiness add new resources

[WyatyPeert]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #20525
Closes #20384

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAwsRoute53RecoveryReadiness'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsRoute53RecoveryReadiness -timeout 180m
=== RUN   TestAccAwsRoute53RecoveryReadinessCell_basic
=== PAUSE TestAccAwsRoute53RecoveryReadinessCell_basic
=== RUN   TestAccAwsRoute53RecoveryReadinessCell_nestedCell
=== PAUSE TestAccAwsRoute53RecoveryReadinessCell_nestedCell
=== RUN   TestAccAwsRoute53RecoveryReadinessCell_tags
=== PAUSE TestAccAwsRoute53RecoveryReadinessCell_tags
=== RUN   TestAccAwsRoute53RecoveryReadinessReadinessCheck_basic
=== PAUSE TestAccAwsRoute53RecoveryReadinessReadinessCheck_basic
=== RUN   TestAccAwsRoute53RecoveryReadinessReadinessCheck_tags
=== PAUSE TestAccAwsRoute53RecoveryReadinessReadinessCheck_tags
=== RUN   TestAccAwsRoute53RecoveryReadinessRecoveryGroup_basic
=== PAUSE TestAccAwsRoute53RecoveryReadinessRecoveryGroup_basic
=== RUN   TestAccAwsRoute53RecoveryReadinessRecoveryGroup_nestedCell
=== PAUSE TestAccAwsRoute53RecoveryReadinessRecoveryGroup_nestedCell
=== RUN   TestAccAwsRoute53RecoveryReadinessRecoveryGroup_tags
=== PAUSE TestAccAwsRoute53RecoveryReadinessRecoveryGroup_tags
=== RUN   TestAccAwsRoute53RecoveryReadinessResourceSet_basic
=== PAUSE TestAccAwsRoute53RecoveryReadinessResourceSet_basic
=== RUN   TestAccAwsRoute53RecoveryReadinessResourceSet_tags
=== PAUSE TestAccAwsRoute53RecoveryReadinessResourceSet_tags
=== RUN   TestAccAwsRoute53RecoveryReadinessResourceSet_readinessScope
=== PAUSE TestAccAwsRoute53RecoveryReadinessResourceSet_readinessScope
=== RUN   TestAccAwsRoute53RecoveryReadinessResourceSet_basicDnsTargetResource
=== PAUSE TestAccAwsRoute53RecoveryReadinessResourceSet_basicDnsTargetResource
=== RUN   TestAccAwsRoute53RecoveryReadinessResourceSet_DnsTargetResourceNlbTarget
=== PAUSE TestAccAwsRoute53RecoveryReadinessResourceSet_DnsTargetResourceNlbTarget
=== RUN   TestAccAwsRoute53RecoveryReadinessResourceSet_DnsTargetResourceR53Target
=== PAUSE TestAccAwsRoute53RecoveryReadinessResourceSet_DnsTargetResourceR53Target
=== CONT  TestAccAwsRoute53RecoveryReadinessCell_basic
=== CONT  TestAccAwsRoute53RecoveryReadinessResourceSet_basic
=== CONT  TestAccAwsRoute53RecoveryReadinessResourceSet_DnsTargetResourceNlbTarget
=== CONT  TestAccAwsRoute53RecoveryReadinessResourceSet_tags
=== CONT  TestAccAwsRoute53RecoveryReadinessReadinessCheck_tags
=== CONT  TestAccAwsRoute53RecoveryReadinessRecoveryGroup_basic
=== CONT  TestAccAwsRoute53RecoveryReadinessResourceSet_readinessScope
=== CONT  TestAccAwsRoute53RecoveryReadinessRecoveryGroup_nestedCell
=== CONT  TestAccAwsRoute53RecoveryReadinessResourceSet_basicDnsTargetResource
=== CONT  TestAccAwsRoute53RecoveryReadinessRecoveryGroup_tags
=== CONT  TestAccAwsRoute53RecoveryReadinessCell_tags
=== CONT  TestAccAwsRoute53RecoveryReadinessReadinessCheck_basic
=== CONT  TestAccAwsRoute53RecoveryReadinessResourceSet_DnsTargetResourceR53Target
=== CONT  TestAccAwsRoute53RecoveryReadinessCell_nestedCell
--- PASS: TestAccAwsRoute53RecoveryReadinessReadinessCheck_basic (46.48s)
--- PASS: TestAccAwsRoute53RecoveryReadinessResourceSet_basic (48.71s)
--- PASS: TestAccAwsRoute53RecoveryReadinessCell_basic (48.71s)
--- PASS: TestAccAwsRoute53RecoveryReadinessResourceSet_DnsTargetResourceR53Target (49.04s)
--- PASS: TestAccAwsRoute53RecoveryReadinessRecoveryGroup_basic (49.09s)
--- PASS: TestAccAwsRoute53RecoveryReadinessRecoveryGroup_nestedCell (49.85s)
--- PASS: TestAccAwsRoute53RecoveryReadinessResourceSet_basicDnsTargetResource (50.32s)
--- PASS: TestAccAwsRoute53RecoveryReadinessResourceSet_readinessScope (51.05s)
--- PASS: TestAccAwsRoute53RecoveryReadinessCell_nestedCell (83.83s)
--- PASS: TestAccAwsRoute53RecoveryReadinessCell_tags (83.91s)
--- PASS: TestAccAwsRoute53RecoveryReadinessRecoveryGroup_tags (83.97s)
--- PASS: TestAccAwsRoute53RecoveryReadinessResourceSet_tags (83.99s)
--- PASS: TestAccAwsRoute53RecoveryReadinessReadinessCheck_tags (85.00s)
--- PASS: TestAccAwsRoute53RecoveryReadinessResourceSet_DnsTargetResourceNlbTarget (246.37s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	249.321s
...

[WyatyPeert]

Appears I didn't terrafmt the web docs. Rev inc

[WyatyPeert]

I'm clearly having issues running make lint locally given I keep running it, seeing no output and then hitting these snags...

[YakDriver]

Two of the acceptance tests initially failed in us-west-2, errors below. However, I ran the two 10X and they never failed again. Not sure why the initial hiccup but they seem to be okay.

=== CONT  TestAccAwsRoute53RecoveryReadinessReadinessCheck_tags
    resource_aws_route53recoveryreadiness_readiness_check_test.go:61: Step 1/4 error: Error running apply: exit status 1
        
        Error: error creating Route53 Recovery Readiness ReadinessCheck: Validation: 
        	status code: 400, request id: ed0e38ab-6ba8-40e3-ae10-940f438af8e6
        
          with aws_route53recoveryreadiness_readiness_check.test,
          on terraform_plugin_test.tf line 11, in resource "aws_route53recoveryreadiness_readiness_check" "test":
          11: resource "aws_route53recoveryreadiness_readiness_check" "test" {
        
=== CONT  TestAccAwsRoute53RecoveryReadinessReadinessCheck_timeout
    resource_aws_route53recoveryreadiness_readiness_check_test.go:112: Step 1/2 error: Error running apply: exit status 1
        
        Error: error creating Route53 Recovery Readiness ReadinessCheck: Validation: 
        	status code: 400, request id: 8ec277a6-3118-4cb2-994e-e312da167f31
        
          with aws_route53recoveryreadiness_readiness_check.test,
          on terraform_plugin_test.tf line 11, in resource "aws_route53recoveryreadiness_readiness_check" "test":
          11: resource "aws_route53recoveryreadiness_readiness_check" "test" {
        
--- FAIL: TestAccAwsRoute53RecoveryReadinessReadinessCheck_tags (22.62s)
--- FAIL: TestAccAwsRoute53RecoveryReadinessReadinessCheck_timeout (23.66s)

[YakDriver]

Looks good! 🎉

I made a few minor changes.

Output from acceptance tests (us-west-2):

--- PASS: TestAccAwsRoute53RecoveryReadinessRecoveryGroup_disappears (28.64s)
--- PASS: TestAccAwsRoute53RecoveryReadinessRecoveryGroup_timeout (33.61s)
--- PASS: TestAccAwsRoute53RecoveryReadinessResourceSet_basic (34.58s)
--- PASS: TestAccAwsRoute53RecoveryReadinessReadinessCheck_timeout (37.89s)
--- PASS: TestAccAwsRoute53RecoveryReadinessCell_basic (38.10s)
--- PASS: TestAccAwsRoute53RecoveryReadinessRecoveryGroup_basic (38.54s)
--- PASS: TestAccAwsRoute53RecoveryReadinessResourceSet_basicDNSTargetResource (38.63s)
--- PASS: TestAccAwsRoute53RecoveryReadinessCell_timeout (40.74s)
--- PASS: TestAccAwsRoute53RecoveryReadinessReadinessCheck_disappears (42.75s)
--- PASS: TestAccAwsRoute53RecoveryReadinessRecoveryGroup_nestedCell (51.00s)
--- PASS: TestAccAwsRoute53RecoveryReadinessResourceSet_dnsTargetResourceR53Target (52.24s)
--- PASS: TestAccAwsRoute53RecoveryReadinessResourceSet_disappears (52.67s)
--- PASS: TestAccAwsRoute53RecoveryReadinessResourceSet_readinessScope (53.16s)
--- PASS: TestAccAwsRoute53RecoveryReadinessResourceSet_timeout (53.44s)
--- PASS: TestAccAwsRoute53RecoveryReadinessCell_disappears (29.39s)
--- PASS: TestAccAwsRoute53RecoveryReadinessCell_tags (65.53s)
--- PASS: TestAccAwsRoute53RecoveryReadinessResourceSet_tags (71.42s)
--- PASS: TestAccAwsRoute53RecoveryReadinessRecoveryGroup_tags (73.76s)
--- PASS: TestAccAwsRoute53RecoveryReadinessReadinessCheck_basic (76.41s)
--- PASS: TestAccAwsRoute53RecoveryReadinessCell_nestedCell (50.02s)
--- PASS: TestAccAwsRoute53RecoveryReadinessReadinessCheck_tags (88.92s)
--- PASS: TestAccAwsRoute53RecoveryReadinessResourceSet_dnsTargetResourceNLBTarget (234.53s)

Output from acceptance test (GovCloud):

--- SKIP: TestAccAwsRoute53RecoveryReadinessCell_basic (25.35s)
--- SKIP: TestAccAwsRoute53RecoveryReadinessCell_disappears (22.15s)
--- SKIP: TestAccAwsRoute53RecoveryReadinessCell_nestedCell (19.27s)
--- SKIP: TestAccAwsRoute53RecoveryReadinessCell_tags (23.14s)
--- SKIP: TestAccAwsRoute53RecoveryReadinessCell_timeout (29.00s)
--- SKIP: TestAccAwsRoute53RecoveryReadinessReadinessCheck_basic (25.67s)
--- SKIP: TestAccAwsRoute53RecoveryReadinessReadinessCheck_disappears (23.57s)
--- SKIP: TestAccAwsRoute53RecoveryReadinessReadinessCheck_tags (26.15s)
--- SKIP: TestAccAwsRoute53RecoveryReadinessReadinessCheck_timeout (22.99s)
--- SKIP: TestAccAwsRoute53RecoveryReadinessRecoveryGroup_basic (22.34s)
--- SKIP: TestAccAwsRoute53RecoveryReadinessRecoveryGroup_disappears (25.17s)
--- SKIP: TestAccAwsRoute53RecoveryReadinessRecoveryGroup_nestedCell (27.24s)
--- SKIP: TestAccAwsRoute53RecoveryReadinessRecoveryGroup_tags (27.55s)
--- SKIP: TestAccAwsRoute53RecoveryReadinessRecoveryGroup_timeout (20.68s)
--- SKIP: TestAccAwsRoute53RecoveryReadinessResourceSet_basic (25.26s)
--- SKIP: TestAccAwsRoute53RecoveryReadinessResourceSet_basicDNSTargetResource (23.60s)
--- SKIP: TestAccAwsRoute53RecoveryReadinessResourceSet_disappears (26.81s)
--- SKIP: TestAccAwsRoute53RecoveryReadinessResourceSet_dnsTargetResourceNLBTarget (22.48s)
--- SKIP: TestAccAwsRoute53RecoveryReadinessResourceSet_dnsTargetResourceR53Target (23.92s)
--- SKIP: TestAccAwsRoute53RecoveryReadinessResourceSet_readinessScope (28.50s)
--- SKIP: TestAccAwsRoute53RecoveryReadinessResourceSet_tags (20.31s)
--- SKIP: TestAccAwsRoute53RecoveryReadinessResourceSet_timeout (18.78s)

[github-actions]

This functionality has been released in v3.56.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.