Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Unicode Support For Oracle RDS databases in the provider #20413

Closed
fergoid opened this issue Aug 2, 2021 · 2 comments · Fixed by #20437
Closed

Add Unicode Support For Oracle RDS databases in the provider #20413

fergoid opened this issue Aug 2, 2021 · 2 comments · Fixed by #20437
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service.
Milestone

Comments

@fergoid
Copy link
Contributor

fergoid commented Aug 2, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

To manage Oracle databases in RDS for databases in Asia using Terraform then, as per my understanding and the documentation detailed below, we need to be able to set the national character set (‘NcharCharacterSetName’) variable in the AWS API at the point of database creation.

A new resource parameter (national_character_set) would be added that is optional and it would be flagged in the documentation as being Oracle specific.

New or Affected Resource(s)

  • aws_db_instance

Potential Terraform Configuration

resource "aws_db_instance" "default" {
  allocated_storage    = 10
  engine                       = "oracle-ee"
  engine_version        = "19"
  instance_class         = "db.t3.micro"
  name                        = "mydb"
  username                = "foo"
  password                = "foobarbaz"
  skip_final_snapshot  = true
  national_character_set = "UTF8"
}

References

@fergoid fergoid added the enhancement Requests to existing resources that expand the functionality or scope. label Aug 2, 2021
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/rds Issues and PRs that pertain to the rds service. labels Aug 2, 2021
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Aug 4, 2021
@github-actions github-actions bot added this to the v3.53.0 milestone Aug 4, 2021
@github-actions
Copy link

github-actions bot commented Aug 5, 2021

This functionality has been released in v3.53.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Sep 5, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants