Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for other arguments in kafka_settings configuration block to aws_dms_endpoint #20138

Closed
evairmarinho opened this issue Jul 12, 2021 · 3 comments · Fixed by #20904
Closed
Labels
enhancement Requests to existing resources that expand the functionality or scope.
Milestone

Comments

@evairmarinho
Copy link

evairmarinho commented Jul 12, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The resource aws_dms_endpoint doesn't have other arguments in kafka_settings configuration block.

New or Affected Resource(s)

aws_dms_endpoint

Potential Terraform Configuration

resource "aws_dms_endpoint" "my_endpoint" {
 ...
  kafka_settings = {
    broker = "HOSTNAME:PORT"  # already exists in aws provider
    topic = "my_topic" # already exists in aws provider
    include_null_and_empty = true
    message_format = "JSON"
    include_transaction_details = false
    include_partition_value = false
    partition_include_schema_table = false

  ## To verify other arguments available, access https://docs.aws.amazon.com/cli/latest/reference/dms/create-endpoint.html
  }
...
}

References

https://docs.aws.amazon.com/cli/latest/reference/dms/create-endpoint.html

https://docs.aws.amazon.com/sdk-for-go/api/service/databasemigrationservice/#KafkaSettings

@evairmarinho evairmarinho added the enhancement Requests to existing resources that expand the functionality or scope. label Jul 12, 2021
@evairmarinho evairmarinho changed the title Add support for enndpoint_settings to aws_dms_endpoint Add support for endpoint_settings to aws_dms_endpoint Jul 12, 2021
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/databasemigrationservice labels Jul 12, 2021
@evairmarinho
Copy link
Author

@bflad

@evairmarinho evairmarinho changed the title Add support for endpoint_settings to aws_dms_endpoint Add support for other arguments in kafka_settings configuration block to aws_dms_endpoint Aug 1, 2021
@anGie44 anGie44 removed the needs-triage Waiting for first response or review from a maintainer. label Aug 18, 2021
@github-actions github-actions bot added this to the v3.62.0 milestone Oct 7, 2021
@github-actions
Copy link

github-actions bot commented Oct 8, 2021

This functionality has been released in v3.62.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 3, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants