Check VpcSettings and ConnectSettings for nil values

[bill-rich]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #17168

Output from acceptance testing:

 TESTARGS="-run=TestAccDataSourceAwsDirectoryServiceDirectory_" make testacc
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsDirectoryServiceDirectory_ -timeout 180m
=== RUN   TestAccDataSourceAwsDirectoryServiceDirectory_NonExistent
=== PAUSE TestAccDataSourceAwsDirectoryServiceDirectory_NonExistent
=== RUN   TestAccDataSourceAwsDirectoryServiceDirectory_SimpleAD
=== PAUSE TestAccDataSourceAwsDirectoryServiceDirectory_SimpleAD
=== RUN   TestAccDataSourceAwsDirectoryServiceDirectory_MicrosoftAD
=== PAUSE TestAccDataSourceAwsDirectoryServiceDirectory_MicrosoftAD
=== RUN   TestAccDataSourceAwsDirectoryServiceDirectory_connector
=== PAUSE TestAccDataSourceAwsDirectoryServiceDirectory_connector
=== CONT  TestAccDataSourceAwsDirectoryServiceDirectory_NonExistent
=== CONT  TestAccDataSourceAwsDirectoryServiceDirectory_connector
=== CONT  TestAccDataSourceAwsDirectoryServiceDirectory_SimpleAD
=== CONT  TestAccDataSourceAwsDirectoryServiceDirectory_MicrosoftAD
--- PASS: TestAccDataSourceAwsDirectoryServiceDirectory_NonExistent (3.56s)
--- PASS: TestAccDataSourceAwsDirectoryServiceDirectory_SimpleAD (773.20s)
--- PASS: TestAccDataSourceAwsDirectoryServiceDirectory_connector (1290.75s)
--- PASS: TestAccDataSourceAwsDirectoryServiceDirectory_MicrosoftAD (1892.31s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1892.367s

[ewbankkit]

LGTM 🚀.

Commercial

% make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAwsDirectoryServiceDirectory_'                           
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsDirectoryServiceDirectory_ -timeout 180m
=== RUN   TestAccDataSourceAwsDirectoryServiceDirectory_NonExistent
=== PAUSE TestAccDataSourceAwsDirectoryServiceDirectory_NonExistent
=== RUN   TestAccDataSourceAwsDirectoryServiceDirectory_SimpleAD
=== PAUSE TestAccDataSourceAwsDirectoryServiceDirectory_SimpleAD
=== RUN   TestAccDataSourceAwsDirectoryServiceDirectory_MicrosoftAD
=== PAUSE TestAccDataSourceAwsDirectoryServiceDirectory_MicrosoftAD
=== RUN   TestAccDataSourceAwsDirectoryServiceDirectory_connector
=== PAUSE TestAccDataSourceAwsDirectoryServiceDirectory_connector
=== CONT  TestAccDataSourceAwsDirectoryServiceDirectory_NonExistent
=== CONT  TestAccDataSourceAwsDirectoryServiceDirectory_connector
=== CONT  TestAccDataSourceAwsDirectoryServiceDirectory_MicrosoftAD
=== CONT  TestAccDataSourceAwsDirectoryServiceDirectory_SimpleAD
--- PASS: TestAccDataSourceAwsDirectoryServiceDirectory_NonExistent (3.23s)
--- PASS: TestAccDataSourceAwsDirectoryServiceDirectory_SimpleAD (763.98s)
--- PASS: TestAccDataSourceAwsDirectoryServiceDirectory_connector (1238.92s)
--- PASS: TestAccDataSourceAwsDirectoryServiceDirectory_MicrosoftAD (1903.97s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1907.696s

GovCloud

% make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAwsDirectoryServiceDirectory_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsDirectoryServiceDirectory_ -timeout 180m
=== RUN   TestAccDataSourceAwsDirectoryServiceDirectory_NonExistent
=== PAUSE TestAccDataSourceAwsDirectoryServiceDirectory_NonExistent
=== RUN   TestAccDataSourceAwsDirectoryServiceDirectory_SimpleAD
=== PAUSE TestAccDataSourceAwsDirectoryServiceDirectory_SimpleAD
=== RUN   TestAccDataSourceAwsDirectoryServiceDirectory_MicrosoftAD
=== PAUSE TestAccDataSourceAwsDirectoryServiceDirectory_MicrosoftAD
=== RUN   TestAccDataSourceAwsDirectoryServiceDirectory_connector
=== PAUSE TestAccDataSourceAwsDirectoryServiceDirectory_connector
=== CONT  TestAccDataSourceAwsDirectoryServiceDirectory_NonExistent
=== CONT  TestAccDataSourceAwsDirectoryServiceDirectory_MicrosoftAD
=== CONT  TestAccDataSourceAwsDirectoryServiceDirectory_SimpleAD
=== CONT  TestAccDataSourceAwsDirectoryServiceDirectory_connector
=== CONT  TestAccDataSourceAwsDirectoryServiceDirectory_SimpleAD
    resource_aws_directory_service_directory_test.go:490: skipping acceptance testing: ClientException: Simple AD directory creation is currently not supported in this region. : RequestId: 6e09e2c8-c3b9-4806-8f86-e0afdfd1a103 : RequestId: 6e09e2c8-c3b9-4806-8f86-e0afdfd1a103
        {
          RespMetadata: {
            StatusCode: 400,
            RequestID: "6e09e2c8-c3b9-4806-8f86-e0afdfd1a103"
          },
          Message_: "Simple AD directory creation is currently not supported in this region. : RequestId: 6e09e2c8-c3b9-4806-8f86-e0afdfd1a103 : RequestId: 6e09e2c8-c3b9-4806-8f86-e0afdfd1a103",
          RequestId: "6e09e2c8-c3b9-4806-8f86-e0afdfd1a103"
        }
--- SKIP: TestAccDataSourceAwsDirectoryServiceDirectory_SimpleAD (1.80s)
=== CONT  TestAccDataSourceAwsDirectoryServiceDirectory_connector
    resource_aws_directory_service_directory_test.go:490: skipping acceptance testing: ClientException: Simple AD directory creation is currently not supported in this region. : RequestId: 37e65247-1570-45a3-8398-266b1e9235a2 : RequestId: 37e65247-1570-45a3-8398-266b1e9235a2
        {
          RespMetadata: {
            StatusCode: 400,
            RequestID: "37e65247-1570-45a3-8398-266b1e9235a2"
          },
          Message_: "Simple AD directory creation is currently not supported in this region. : RequestId: 37e65247-1570-45a3-8398-266b1e9235a2 : RequestId: 37e65247-1570-45a3-8398-266b1e9235a2",
          RequestId: "37e65247-1570-45a3-8398-266b1e9235a2"
        }
--- SKIP: TestAccDataSourceAwsDirectoryServiceDirectory_connector (2.17s)
--- PASS: TestAccDataSourceAwsDirectoryServiceDirectory_NonExistent (3.72s)
--- PASS: TestAccDataSourceAwsDirectoryServiceDirectory_MicrosoftAD (1816.98s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1820.053s

[ewbankkit]

Needs a .changelog/19820.txt file.

[github-actions]

This functionality has been released in v3.46.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.