Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_batch_job_definition: Match equivalency of null and [] for linuxParameters.devices and linuxParameters.tmpfs #19666

Merged
merged 2 commits into from
Jun 9, 2021

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Jun 4, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #19624.

Output from acceptance testing:

Commercial

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSBatchJobDefinition_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSBatchJobDefinition_ -timeout 180m
=== RUN   TestAccAWSBatchJobDefinition_basic
=== PAUSE TestAccAWSBatchJobDefinition_basic
=== RUN   TestAccAWSBatchJobDefinition_disappears
=== PAUSE TestAccAWSBatchJobDefinition_disappears
=== RUN   TestAccAWSBatchJobDefinition_PlatformCapabilities_EC2
=== PAUSE TestAccAWSBatchJobDefinition_PlatformCapabilities_EC2
=== RUN   TestAccAWSBatchJobDefinition_PlatformCapabilities_Fargate_ContainerPropertiesDefaults
=== PAUSE TestAccAWSBatchJobDefinition_PlatformCapabilities_Fargate_ContainerPropertiesDefaults
=== RUN   TestAccAWSBatchJobDefinition_PlatformCapabilities_Fargate
=== PAUSE TestAccAWSBatchJobDefinition_PlatformCapabilities_Fargate
=== RUN   TestAccAWSBatchJobDefinition_ContainerProperties_Advanced
=== PAUSE TestAccAWSBatchJobDefinition_ContainerProperties_Advanced
=== RUN   TestAccAWSBatchJobDefinition_updateForcesNewResource
=== PAUSE TestAccAWSBatchJobDefinition_updateForcesNewResource
=== RUN   TestAccAWSBatchJobDefinition_Tags
=== PAUSE TestAccAWSBatchJobDefinition_Tags
=== RUN   TestAccAWSBatchJobDefinition_PropagateTags
=== PAUSE TestAccAWSBatchJobDefinition_PropagateTags
=== CONT  TestAccAWSBatchJobDefinition_basic
=== CONT  TestAccAWSBatchJobDefinition_ContainerProperties_Advanced
=== CONT  TestAccAWSBatchJobDefinition_PropagateTags
=== CONT  TestAccAWSBatchJobDefinition_PlatformCapabilities_Fargate
=== CONT  TestAccAWSBatchJobDefinition_Tags
=== CONT  TestAccAWSBatchJobDefinition_updateForcesNewResource
=== CONT  TestAccAWSBatchJobDefinition_PlatformCapabilities_EC2
=== CONT  TestAccAWSBatchJobDefinition_disappears
=== CONT  TestAccAWSBatchJobDefinition_PlatformCapabilities_Fargate_ContainerPropertiesDefaults
--- PASS: TestAccAWSBatchJobDefinition_PropagateTags (20.62s)
--- PASS: TestAccAWSBatchJobDefinition_disappears (21.13s)
--- PASS: TestAccAWSBatchJobDefinition_ContainerProperties_Advanced (22.43s)
--- PASS: TestAccAWSBatchJobDefinition_basic (22.54s)
--- PASS: TestAccAWSBatchJobDefinition_PlatformCapabilities_EC2 (22.84s)
--- PASS: TestAccAWSBatchJobDefinition_PlatformCapabilities_Fargate (23.58s)
--- PASS: TestAccAWSBatchJobDefinition_PlatformCapabilities_Fargate_ContainerPropertiesDefaults (23.64s)
--- PASS: TestAccAWSBatchJobDefinition_updateForcesNewResource (34.60s)
--- PASS: TestAccAWSBatchJobDefinition_Tags (38.04s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	41.262s

GovCloud

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSBatchJobDefinition_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSBatchJobDefinition_ -timeout 180m
=== RUN   TestAccAWSBatchJobDefinition_basic
=== PAUSE TestAccAWSBatchJobDefinition_basic
=== RUN   TestAccAWSBatchJobDefinition_disappears
=== PAUSE TestAccAWSBatchJobDefinition_disappears
=== RUN   TestAccAWSBatchJobDefinition_PlatformCapabilities_EC2
=== PAUSE TestAccAWSBatchJobDefinition_PlatformCapabilities_EC2
=== RUN   TestAccAWSBatchJobDefinition_PlatformCapabilities_Fargate_ContainerPropertiesDefaults
=== PAUSE TestAccAWSBatchJobDefinition_PlatformCapabilities_Fargate_ContainerPropertiesDefaults
=== RUN   TestAccAWSBatchJobDefinition_PlatformCapabilities_Fargate
=== PAUSE TestAccAWSBatchJobDefinition_PlatformCapabilities_Fargate
=== RUN   TestAccAWSBatchJobDefinition_ContainerProperties_Advanced
=== PAUSE TestAccAWSBatchJobDefinition_ContainerProperties_Advanced
=== RUN   TestAccAWSBatchJobDefinition_updateForcesNewResource
=== PAUSE TestAccAWSBatchJobDefinition_updateForcesNewResource
=== RUN   TestAccAWSBatchJobDefinition_Tags
=== PAUSE TestAccAWSBatchJobDefinition_Tags
=== RUN   TestAccAWSBatchJobDefinition_PropagateTags
=== PAUSE TestAccAWSBatchJobDefinition_PropagateTags
=== CONT  TestAccAWSBatchJobDefinition_basic
=== CONT  TestAccAWSBatchJobDefinition_ContainerProperties_Advanced
=== CONT  TestAccAWSBatchJobDefinition_PlatformCapabilities_Fargate_ContainerPropertiesDefaults
=== CONT  TestAccAWSBatchJobDefinition_Tags
=== CONT  TestAccAWSBatchJobDefinition_PropagateTags
=== CONT  TestAccAWSBatchJobDefinition_updateForcesNewResource
=== CONT  TestAccAWSBatchJobDefinition_PlatformCapabilities_Fargate
=== CONT  TestAccAWSBatchJobDefinition_PlatformCapabilities_EC2
=== CONT  TestAccAWSBatchJobDefinition_disappears
--- PASS: TestAccAWSBatchJobDefinition_PropagateTags (20.36s)
--- PASS: TestAccAWSBatchJobDefinition_basic (22.25s)
--- PASS: TestAccAWSBatchJobDefinition_disappears (22.47s)
--- PASS: TestAccAWSBatchJobDefinition_PlatformCapabilities_Fargate (26.80s)
--- PASS: TestAccAWSBatchJobDefinition_ContainerProperties_Advanced (27.56s)
--- PASS: TestAccAWSBatchJobDefinition_PlatformCapabilities_EC2 (27.81s)
--- PASS: TestAccAWSBatchJobDefinition_PlatformCapabilities_Fargate_ContainerPropertiesDefaults (31.80s)
--- PASS: TestAccAWSBatchJobDefinition_updateForcesNewResource (35.52s)
--- PASS: TestAccAWSBatchJobDefinition_Tags (50.12s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	53.190s

…'linuxParameters.devices' and 'linuxParameters.tmpfs'.
@ewbankkit ewbankkit requested a review from a team as a code owner June 4, 2021 13:42
@ghost ghost added size/M Managed by automation to categorize the size of a PR. labels Jun 4, 2021
@github-actions github-actions bot added service/batch Issues and PRs that pertain to the batch service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 4, 2021
@ewbankkit ewbankkit added the bug Addresses a defect in current functionality. label Jun 4, 2021
@anGie44 anGie44 self-assigned this Jun 8, 2021
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Output of acceptance tests (commercial):

--- PASS: TestEquivalentBatchContainerPropertiesJSON (0.00s)

--- PASS: TestAccAWSBatchJobDefinition_disappears (25.05s)
--- PASS: TestAccAWSBatchJobDefinition_PropagateTags (29.36s)
--- PASS: TestAccAWSBatchJobDefinition_ContainerProperties_Advanced (31.70s)
--- PASS: TestAccAWSBatchJobDefinition_PlatformCapabilities_EC2 (33.74s)
--- PASS: TestAccAWSBatchJobDefinition_basic (33.90s)
--- PASS: TestAccAWSBatchJobDefinition_PlatformCapabilities_Fargate (36.36s)
--- PASS: TestAccAWSBatchJobDefinition_PlatformCapabilities_Fargate_ContainerPropertiesDefaults (37.08s)
--- PASS: TestAccAWSBatchJobDefinition_updateForcesNewResource (44.48s)
--- PASS: TestAccAWSBatchJobDefinition_Tags (53.53s)

@ewbankkit ewbankkit merged commit 7c13773 into main Jun 9, 2021
@ewbankkit ewbankkit deleted the b-aws_batch_job_definition-recreate branch June 9, 2021 16:36
@github-actions github-actions bot added this to the v3.45.0 milestone Jun 9, 2021
github-actions bot pushed a commit that referenced this pull request Jun 9, 2021
@github-actions
Copy link

This functionality has been released in v3.45.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/batch Issues and PRs that pertain to the batch service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_batch_job_definition gets recreated on every apply, even if the config does not change
2 participants