Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/devicefarm_project - add default_job_timeout_minutes and tags arguments #19574

Merged
merged 5 commits into from
Jun 2, 2021

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented May 28, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #8745.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSDeviceFarmProject_'
--- PASS: TestAccAWSDeviceFarmProject_disappears (25.35s)
--- PASS: TestAccAWSDeviceFarmProject_basic (59.77s)
--- PASS: TestAccAWSDeviceFarmProject_timeout (60.49s)
--- PASS: TestAccAWSDeviceFarmProject_tags (87.44s)

@DrFaust92 DrFaust92 requested a review from a team as a code owner May 28, 2021 18:09
@ghost ghost added size/M Managed by automation to categorize the size of a PR. labels May 28, 2021
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/devicefarm Issues and PRs that pertain to the devicefarm service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 28, 2021
@DrFaust92 DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label May 28, 2021
@DrFaust92 DrFaust92 changed the title r/devicefarm_project - add default_job_timeout_minutes arg r/devicefarm_project - add default_job_timeout_minutes and tags arguments May 28, 2021
@ghost ghost added size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels May 28, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSDeviceFarmProject_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDeviceFarmProject_ -timeout 180m
=== RUN   TestAccAWSDeviceFarmProject_basic
=== PAUSE TestAccAWSDeviceFarmProject_basic
=== RUN   TestAccAWSDeviceFarmProject_timeout
=== PAUSE TestAccAWSDeviceFarmProject_timeout
=== RUN   TestAccAWSDeviceFarmProject_tags
=== PAUSE TestAccAWSDeviceFarmProject_tags
=== RUN   TestAccAWSDeviceFarmProject_disappears
=== PAUSE TestAccAWSDeviceFarmProject_disappears
=== CONT  TestAccAWSDeviceFarmProject_basic
=== CONT  TestAccAWSDeviceFarmProject_tags
=== CONT  TestAccAWSDeviceFarmProject_timeout
=== CONT  TestAccAWSDeviceFarmProject_disappears
--- PASS: TestAccAWSDeviceFarmProject_disappears (13.04s)
--- PASS: TestAccAWSDeviceFarmProject_basic (29.05s)
--- PASS: TestAccAWSDeviceFarmProject_timeout (29.39s)
--- PASS: TestAccAWSDeviceFarmProject_tags (39.17s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	44.059s
GovCloud
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSDeviceFarmProject_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDeviceFarmProject_ -timeout 180m
=== RUN   TestAccAWSDeviceFarmProject_basic
=== PAUSE TestAccAWSDeviceFarmProject_basic
=== RUN   TestAccAWSDeviceFarmProject_timeout
=== PAUSE TestAccAWSDeviceFarmProject_timeout
=== RUN   TestAccAWSDeviceFarmProject_tags
=== PAUSE TestAccAWSDeviceFarmProject_tags
=== RUN   TestAccAWSDeviceFarmProject_disappears
=== PAUSE TestAccAWSDeviceFarmProject_disappears
=== CONT  TestAccAWSDeviceFarmProject_basic
=== CONT  TestAccAWSDeviceFarmProject_disappears
=== CONT  TestAccAWSDeviceFarmProject_timeout
=== CONT  TestAccAWSDeviceFarmProject_tags
=== CONT  TestAccAWSDeviceFarmProject_basic
    provider_test.go:734: skipping tests; partition aws-us-gov does not support devicefarm service
=== CONT  TestAccAWSDeviceFarmProject_timeout
    provider_test.go:734: skipping tests; partition aws-us-gov does not support devicefarm service
=== CONT  TestAccAWSDeviceFarmProject_disappears
    provider_test.go:734: skipping tests; partition aws-us-gov does not support devicefarm service
--- SKIP: TestAccAWSDeviceFarmProject_basic (1.36s)
--- SKIP: TestAccAWSDeviceFarmProject_disappears (1.36s)
--- SKIP: TestAccAWSDeviceFarmProject_timeout (1.36s)
=== CONT  TestAccAWSDeviceFarmProject_tags
    provider_test.go:734: skipping tests; partition aws-us-gov does not support devicefarm service
--- SKIP: TestAccAWSDeviceFarmProject_tags (1.36s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	5.883s

@ewbankkit ewbankkit merged commit c4b4e16 into hashicorp:main Jun 2, 2021
@github-actions github-actions bot added this to the v3.44.0 milestone Jun 2, 2021
@ghost
Copy link

ghost commented Jun 3, 2021

This has been released in version 3.44.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@DrFaust92 DrFaust92 deleted the r/devicefarm_project_timeout branch June 4, 2021 16:38
@github-actions
Copy link

github-actions bot commented Jul 5, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/devicefarm Issues and PRs that pertain to the devicefarm service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS Device Farm tagging
2 participants