Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/cloudtrail: Add DynamoDB as data_resource #19559

Merged
merged 8 commits into from
May 28, 2021

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented May 27, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #18420 (supercedes)
Closes #18394

Output from acceptance testing (us-west-2):

--- PASS: TestAccAWSCloudTrail_serial (650.96s)
    --- PASS: TestAccAWSCloudTrail_serial/Trail (650.96s)
        --- PASS: TestAccAWSCloudTrail_serial/Trail/logValidation (53.82s)
        --- PASS: TestAccAWSCloudTrail_serial/Trail/tags (78.76s)
        --- PASS: TestAccAWSCloudTrail_serial/Trail/insightSelector (30.12s)
        --- PASS: TestAccAWSCloudTrail_serial/Trail/globalServiceEvents (30.77s)
        --- PASS: TestAccAWSCloudTrail_serial/Trail/multiRegion (77.79s)
        --- PASS: TestAccAWSCloudTrail_serial/Trail/enableLogging (76.99s)
        --- SKIP: TestAccAWSCloudTrail_serial/Trail/organization (0.17s)
        --- PASS: TestAccAWSCloudTrail_serial/Trail/kmsKey (30.12s)
        --- PASS: TestAccAWSCloudTrail_serial/Trail/eventSelector (115.19s)
        --- PASS: TestAccAWSCloudTrail_serial/Trail/eventSelectorDynamoDB (27.34s)
        --- PASS: TestAccAWSCloudTrail_serial/Trail/basic (53.45s)
        --- PASS: TestAccAWSCloudTrail_serial/Trail/cloudwatch (76.43s)

Output from acceptance testing (GovCloud):

--- PASS: TestAccAWSCloudTrail_serial (683.67s)
    --- PASS: TestAccAWSCloudTrail_serial/Trail (683.67s)
        --- PASS: TestAccAWSCloudTrail_serial/Trail/enableLogging (86.19s)
        --- PASS: TestAccAWSCloudTrail_serial/Trail/globalServiceEvents (32.68s)
        --- PASS: TestAccAWSCloudTrail_serial/Trail/logValidation (57.99s)
        --- PASS: TestAccAWSCloudTrail_serial/Trail/tags (83.77s)
        --- PASS: TestAccAWSCloudTrail_serial/Trail/eventSelector (126.22s)
        --- PASS: TestAccAWSCloudTrail_serial/Trail/insightSelector (33.18s)
        --- PASS: TestAccAWSCloudTrail_serial/Trail/basic (57.35s)
        --- PASS: TestAccAWSCloudTrail_serial/Trail/multiRegion (81.52s)
        --- SKIP: TestAccAWSCloudTrail_serial/Trail/organization (0.55s)
        --- PASS: TestAccAWSCloudTrail_serial/Trail/kmsKey (31.90s)
        --- SKIP: TestAccAWSCloudTrail_serial/Trail/eventSelectorDynamoDB (21.34s)
        --- PASS: TestAccAWSCloudTrail_serial/Trail/cloudwatch (70.98s)

@YakDriver YakDriver requested a review from a team as a code owner May 27, 2021 21:54
@ghost ghost added the size/XS Managed by automation to categorize the size of a PR. label May 27, 2021
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. labels May 27, 2021
@ghost ghost added size/M Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels May 27, 2021
@github-actions github-actions bot added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label May 27, 2021
@ghost ghost added size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels May 27, 2021
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels May 28, 2021
@YakDriver YakDriver modified the milestones: v3.44.0, v3.43.0 May 28, 2021
@YakDriver YakDriver merged commit b7c5eb8 into main May 28, 2021
@YakDriver YakDriver deleted the f-cloudtrail-dynamodb-events branch May 28, 2021 03:09
github-actions bot pushed a commit that referenced this pull request May 28, 2021
@ghost
Copy link

ghost commented Jun 1, 2021

This has been released in version 3.43.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

github-actions bot commented Jul 3, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. size/XXL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for DynamoDB events to aws_cloudtrail
2 participants