Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_ec2_managed_prefix_list: Fix crash with multiple description-only changes #19517

Merged
merged 2 commits into from
May 26, 2021

Conversation

ewbankkit
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #19421.

Output from acceptance testing:

% make testacc TEST=./aws TESTARGS='-run=TestAccAwsEc2ManagedPrefixList_'                 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsEc2ManagedPrefixList_ -timeout 180m
=== RUN   TestAccAwsEc2ManagedPrefixList_basic
=== PAUSE TestAccAwsEc2ManagedPrefixList_basic
=== RUN   TestAccAwsEc2ManagedPrefixList_disappears
=== PAUSE TestAccAwsEc2ManagedPrefixList_disappears
=== RUN   TestAccAwsEc2ManagedPrefixList_AddressFamily_IPv6
=== PAUSE TestAccAwsEc2ManagedPrefixList_AddressFamily_IPv6
=== RUN   TestAccAwsEc2ManagedPrefixList_Entry_Cidr
=== PAUSE TestAccAwsEc2ManagedPrefixList_Entry_Cidr
=== RUN   TestAccAwsEc2ManagedPrefixList_Entry_Description
=== PAUSE TestAccAwsEc2ManagedPrefixList_Entry_Description
=== RUN   TestAccAwsEc2ManagedPrefixList_Name
=== PAUSE TestAccAwsEc2ManagedPrefixList_Name
=== RUN   TestAccAwsEc2ManagedPrefixList_Tags
=== PAUSE TestAccAwsEc2ManagedPrefixList_Tags
=== CONT  TestAccAwsEc2ManagedPrefixList_basic
=== CONT  TestAccAwsEc2ManagedPrefixList_Entry_Description
=== CONT  TestAccAwsEc2ManagedPrefixList_Tags
=== CONT  TestAccAwsEc2ManagedPrefixList_AddressFamily_IPv6
=== CONT  TestAccAwsEc2ManagedPrefixList_Entry_Cidr
=== CONT  TestAccAwsEc2ManagedPrefixList_disappears
=== CONT  TestAccAwsEc2ManagedPrefixList_Name
--- PASS: TestAccAwsEc2ManagedPrefixList_disappears (21.89s)
--- PASS: TestAccAwsEc2ManagedPrefixList_AddressFamily_IPv6 (26.80s)
--- PASS: TestAccAwsEc2ManagedPrefixList_basic (28.43s)
--- PASS: TestAccAwsEc2ManagedPrefixList_Entry_Description (39.82s)
--- PASS: TestAccAwsEc2ManagedPrefixList_Name (40.13s)
--- PASS: TestAccAwsEc2ManagedPrefixList_Entry_Cidr (43.77s)
--- PASS: TestAccAwsEc2ManagedPrefixList_Tags (47.19s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	50.693s

@ewbankkit ewbankkit requested a review from a team as a code owner May 25, 2021 15:22
@ghost ghost added the size/S Managed by automation to categorize the size of a PR. label May 25, 2021
@ewbankkit ewbankkit added bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. labels May 25, 2021
@github-actions github-actions bot added service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 25, 2021
@YakDriver YakDriver self-assigned this May 26, 2021
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🎉

Output of acceptance tests (us-west-2):

--- PASS: TestAccAwsEc2ManagedPrefixList_disappears (20.90s)
--- PASS: TestAccAwsEc2ManagedPrefixList_AddressFamily_IPv6 (25.55s)
--- PASS: TestAccAwsEc2ManagedPrefixList_basic (25.73s)
--- PASS: TestAccAwsEc2ManagedPrefixList_Name (35.63s)
--- PASS: TestAccAwsEc2ManagedPrefixList_Entry_Description (38.48s)
--- PASS: TestAccAwsEc2ManagedPrefixList_Entry_Cidr (39.09s)
--- PASS: TestAccAwsEc2ManagedPrefixList_Tags (45.19s)

GovCloud:

--- SKIP: TestAccAwsEc2ManagedPrefixList_AddressFamily_IPv6 (1.57s)
--- SKIP: TestAccAwsEc2ManagedPrefixList_basic (1.59s)
--- SKIP: TestAccAwsEc2ManagedPrefixList_disappears (1.59s)
--- SKIP: TestAccAwsEc2ManagedPrefixList_Entry_Cidr (1.59s)
--- SKIP: TestAccAwsEc2ManagedPrefixList_Entry_Description (1.58s)
--- SKIP: TestAccAwsEc2ManagedPrefixList_Name (1.58s)
--- SKIP: TestAccAwsEc2ManagedPrefixList_Tags (1.59s)

@ewbankkit ewbankkit merged commit 5a3bd61 into main May 26, 2021
@ewbankkit ewbankkit deleted the b-aws_ec2_managed_prefix_list-update-crash branch May 26, 2021 18:39
@github-actions github-actions bot added this to the v3.43.0 milestone May 26, 2021
github-actions bot pushed a commit that referenced this pull request May 26, 2021
@ghost
Copy link

ghost commented Jun 1, 2021

This has been released in version 3.43.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

github-actions bot commented Jul 2, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/ec2 Issues and PRs that pertain to the ec2 service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resource/aws_ec2_managed_prefix_list: The plugin encountered an error, and failed to respond to the
2 participants