-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws_route(_table): Wrap CRUD operations on route tables and routes in retries #19426
Conversation
…estroy functions. Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_basic\|TestAccAWSRoute_disappears\|TestAccAWSDefaultRouteTable_basic\|TestAccAWSDefaultRouteTable_disappears\|TestAccAWSRouteTableAssociation_Subnet_basic\|TestAccAWSRouteTableAssociation_disappears' ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSRoute_basic\|TestAccAWSRoute_disappears\|TestAccAWSDefaultRouteTable_basic\|TestAccAWSDefaultRouteTable_disappears\|TestAccAWSRouteTableAssociation_Subnet_basic\|TestAccAWSRouteTableAssociation_disappears -timeout 180m === RUN TestAccAWSDefaultRouteTable_basic === PAUSE TestAccAWSDefaultRouteTable_basic === RUN TestAccAWSDefaultRouteTable_disappears_Vpc === PAUSE TestAccAWSDefaultRouteTable_disappears_Vpc === RUN TestAccAWSRouteTableAssociation_Subnet_basic === PAUSE TestAccAWSRouteTableAssociation_Subnet_basic === RUN TestAccAWSRouteTableAssociation_disappears === PAUSE TestAccAWSRouteTableAssociation_disappears === RUN TestAccAWSRoute_basic === PAUSE TestAccAWSRoute_basic === RUN TestAccAWSRoute_disappears === PAUSE TestAccAWSRoute_disappears === RUN TestAccAWSRoute_disappears_RouteTable === PAUSE TestAccAWSRoute_disappears_RouteTable === CONT TestAccAWSDefaultRouteTable_basic === CONT TestAccAWSRoute_basic --- PASS: TestAccAWSDefaultRouteTable_basic (28.58s) === CONT TestAccAWSRoute_disappears_RouteTable --- PASS: TestAccAWSRoute_basic (36.75s) === CONT TestAccAWSRoute_disappears --- PASS: TestAccAWSRoute_disappears_RouteTable (33.95s) === CONT TestAccAWSRouteTableAssociation_Subnet_basic --- PASS: TestAccAWSRoute_disappears (33.06s) === CONT TestAccAWSRouteTableAssociation_disappears --- PASS: TestAccAWSRouteTableAssociation_Subnet_basic (39.37s) === CONT TestAccAWSDefaultRouteTable_disappears_Vpc --- PASS: TestAccAWSRouteTableAssociation_disappears (36.32s) --- PASS: TestAccAWSDefaultRouteTable_disappears_Vpc (14.72s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 116.707s
… 'canonicalCidrBlock' and 'cidrBlocksEqual'.
This reverts commit 3ce6f12.
Acceptance test output: % make testacc TEST=./aws TESTARGS='-run=TestAccAWSRouteTableAssociation_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSRouteTableAssociation_ -timeout 180m === RUN TestAccAWSRouteTableAssociation_Subnet_basic === PAUSE TestAccAWSRouteTableAssociation_Subnet_basic === RUN TestAccAWSRouteTableAssociation_Subnet_ChangeRouteTable === PAUSE TestAccAWSRouteTableAssociation_Subnet_ChangeRouteTable === RUN TestAccAWSRouteTableAssociation_Gateway_basic === PAUSE TestAccAWSRouteTableAssociation_Gateway_basic === RUN TestAccAWSRouteTableAssociation_Gateway_ChangeRouteTable === PAUSE TestAccAWSRouteTableAssociation_Gateway_ChangeRouteTable === RUN TestAccAWSRouteTableAssociation_disappears === PAUSE TestAccAWSRouteTableAssociation_disappears === CONT TestAccAWSRouteTableAssociation_Subnet_basic === CONT TestAccAWSRouteTableAssociation_Gateway_ChangeRouteTable === CONT TestAccAWSRouteTableAssociation_disappears === CONT TestAccAWSRouteTableAssociation_Gateway_basic === CONT TestAccAWSRouteTableAssociation_Subnet_ChangeRouteTable --- PASS: TestAccAWSRouteTableAssociation_disappears (41.23s) --- PASS: TestAccAWSRouteTableAssociation_Subnet_basic (43.44s) --- PASS: TestAccAWSRouteTableAssociation_Subnet_ChangeRouteTable (64.12s) --- PASS: TestAccAWSRouteTableAssociation_Gateway_basic (74.27s) --- PASS: TestAccAWSRouteTableAssociation_Gateway_ChangeRouteTable (94.98s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 98.235s
Acceptance test output: % make testacc TEST=./aws TESTARGS='-run=TestAccAWSMainRouteTableAssociation_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSMainRouteTableAssociation_ -timeout 180m === RUN TestAccAWSMainRouteTableAssociation_basic === PAUSE TestAccAWSMainRouteTableAssociation_basic === CONT TestAccAWSMainRouteTableAssociation_basic --- PASS: TestAccAWSMainRouteTableAssociation_basic (61.64s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 65.154s
Test 'tfresource.RetryUntilFound'.
This reverts commit af7c026.
Acceptance test output: % make testacc TEST=./aws TESTARGS='-run=TestAccAWSVpcEndpointRouteTableAssociation_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSVpcEndpointRouteTableAssociation_ -timeout 180m === RUN TestAccAWSVpcEndpointRouteTableAssociation_basic === PAUSE TestAccAWSVpcEndpointRouteTableAssociation_basic === RUN TestAccAWSVpcEndpointRouteTableAssociation_disappears === PAUSE TestAccAWSVpcEndpointRouteTableAssociation_disappears === CONT TestAccAWSVpcEndpointRouteTableAssociation_basic === CONT TestAccAWSVpcEndpointRouteTableAssociation_disappears --- PASS: TestAccAWSVpcEndpointRouteTableAssociation_disappears (39.13s) --- PASS: TestAccAWSVpcEndpointRouteTableAssociation_basic (41.03s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 44.118s
Acceptance test output: % make testacc TEST=./aws TESTARGS='-run=TestAccAWSVpcEndpoint_interfaceBasic' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSVpcEndpoint_interfaceBasic -timeout 180m === RUN TestAccAWSVpcEndpoint_interfaceBasic === PAUSE TestAccAWSVpcEndpoint_interfaceBasic === CONT TestAccAWSVpcEndpoint_interfaceBasic --- PASS: TestAccAWSVpcEndpoint_interfaceBasic (141.62s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 145.881s
10533f4
to
8f8a267
Compare
Acceptance test output: % go test -v ./aws/internal/net === RUN TestCIDRBlocksEqual --- PASS: TestCIDRBlocksEqual (0.00s) === RUN TestCanonicalCIDRBlock --- PASS: TestCanonicalCIDRBlock (0.00s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws/internal/net 0.687s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
--- SKIP: TestAccAWSRouteDataSource_LocalGatewayID (1.07s)
--- PASS: TestAccAWSRouteDataSource_IPv6DestinationCidr (37.22s)
--- PASS: TestAccAWSRouteDataSource_CarrierGatewayID (42.01s)
--- PASS: TestAccAWSDefaultRouteTable_disappears_Vpc (22.62s)
--- PASS: TestAccAWSRouteDataSource_GatewayVpcEndpoint (72.08s)
--- PASS: TestAccAWSDefaultRouteTable_basic (38.14s)
--- PASS: TestAccAWSDefaultRouteTable_Tags (68.95s)
--- PASS: TestAccAWSDefaultRouteTable_Route_ConfigMode (104.56s)
--- PASS: TestAccAWSRouteDataSource_basic (147.52s)
--- PASS: TestAccAWSDefaultRouteTable_ConditionalCidrBlock (64.23s)
--- PASS: TestAccAWSDefaultRouteTable_VpcEndpointAssociation (89.44s)
--- PASS: TestAccAWSDefaultRouteTable_swap (109.36s)
--- PASS: TestAccAWSDefaultRouteTable_PrefixList_To_InternetGateway (85.21s)
--- PASS: TestAccAWSMainRouteTableAssociation_basic (72.12s)
--- PASS: TestAccAWSRouteDataSource_DestinationPrefixListId (215.41s)
--- PASS: TestAccAWSDefaultRouteTable_RevokeExistingRules (123.37s)
--- PASS: TestAccAWSDefaultRouteTable_IPv4_To_TransitGateway (342.00s)
--- PASS: TestAccAWSDefaultRouteTable_IPv4_To_VpcEndpoint (333.52s)
--- PASS: TestAccAWSRouteDataSource_TransitGatewayID (431.60s)
--- PASS: TestAccAWSRouteTableAssociation_Subnet_basic (43.75s)
--- PASS: TestAccAWSRouteTable_disappears (31.34s)
--- PASS: TestAccAWSRouteTable_basic (36.57s)
--- PASS: TestAccAWSRouteTable_disappears_SubnetAssociation (33.18s)
--- PASS: TestAccAWSRouteTableAssociation_Subnet_ChangeRouteTable (63.93s)
--- PASS: TestAccAWSRouteTableAssociation_disappears (47.88s)
--- PASS: TestAccAWSRouteTable_RequireRouteTarget (25.61s)
--- SKIP: TestAccAWSRouteTable_IPv4_To_LocalGateway (1.38s)
--- PASS: TestAccAWSRouteTableAssociation_Gateway_basic (89.07s)
--- PASS: TestAccAWSRouteTable_IPv6_To_EgressOnlyInternetGateway (69.96s)
--- PASS: TestAccAWSRouteTable_IPv4_To_InternetGateway (86.44s)
--- PASS: TestAccAWSRouteTableAssociation_Gateway_ChangeRouteTable (114.30s)
--- PASS: TestAccAWSRouteTable_IPv4_To_CarrierGateway (43.89s)
--- PASS: TestAccAWSRouteTable_IPv4_To_VpcPeeringConnection (35.02s)
--- PASS: TestAccAWSRouteTable_Tags (93.41s)
--- PASS: TestAccAWSRouteTable_VpcClassicLink (28.84s)
--- PASS: TestAccAWSRouteTable_ConditionalCidrBlock (64.95s)
--- PASS: TestAccAWSRouteTable_Route_ConfigMode (107.22s)
--- PASS: TestAccAWSRouteTable_IPv6_To_NetworkInterface_Unattached (57.36s)
--- PASS: TestAccAWSRouteTable_GatewayVpcEndpoint (37.06s)
--- PASS: TestAccAWSRouteTable_VpcMultipleCidrs (46.35s)
--- PASS: TestAccAWSRouteTable_IPv4_To_Instance (136.32s)
--- PASS: TestAccAWSRouteTable_PrefixList_To_InternetGateway (36.30s)
--- PASS: TestAccAWSRouteTable_VgwRoutePropagation (102.33s)
--- PASS: TestAccAWSRoute_basic (43.41s)
--- PASS: TestAccAWSRoute_disappears (42.53s)
--- PASS: TestAccAWSRoute_disappears_RouteTable (44.91s)
--- PASS: TestAccAWSRoute_IPv6_To_VpcPeeringConnection (39.55s)
--- PASS: TestAccAWSRoute_IPv6_To_InternetGateway (50.01s)
--- PASS: TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway (54.78s)
--- PASS: TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached (75.00s)
--- PASS: TestAccAWSRoute_IPv4_To_VpcPeeringConnection (36.19s)
--- PASS: TestAccAWSRoute_IPv4_To_VpnGateway (74.42s)
--- SKIP: TestAccAWSRoute_IPv4_To_LocalGateway (1.07s)
--- SKIP: TestAccAWSRoute_IPv6_To_LocalGateway (0.94s)
--- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached (63.19s)
--- PASS: TestAccAWSRouteTable_IPv4_To_NetworkInterfaces_Unattached (145.30s)
--- PASS: TestAccAWSRoute_DoesNotCrashWithVpcEndpoint (52.46s)
--- PASS: TestAccAWSRoute_IPv6_To_VpnGateway (98.79s)
--- PASS: TestAccAWSRoute_IPv4_To_CarrierGateway (30.25s)
--- PASS: TestAccAWSRoute_LocalRoute (21.96s)
--- PASS: TestAccAWSRoute_IPv4_To_Instance (106.08s)
--- PASS: TestAccAWSRoute_ConditionalCidrBlock (51.28s)
--- PASS: TestAccAWSRouteTable_IPv4_To_NatGateway (204.15s)
--- PASS: TestAccAWSRouteTable_MultipleRoutes (188.84s)
--- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments (124.09s)
--- PASS: TestAccAWSRoute_PrefixList_To_VpnGateway (51.83s)
--- PASS: TestAccAWSRoute_PrefixList_To_InternetGateway (58.88s)
--- SKIP: TestAccAWSRoute_PrefixList_To_LocalGateway (1.23s)
--- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_Attached (140.24s)
--- PASS: TestAccAWSRoute_PrefixList_To_VpcPeeringConnection (27.18s)
--- PASS: TestAccAWSRoute_PrefixList_To_NetworkInterface_Unattached (60.23s)
--- PASS: TestAccAWSRoute_PrefixList_To_CarrierGateway (30.43s)
--- PASS: TestAccAWSRoute_PrefixList_To_EgressOnlyInternetGateway (28.71s)
--- PASS: TestAccAWSRouteTable_RequireRouteDestination (312.32s)
--- PASS: TestAccAWSVpcEndpointRouteTableAssociation_basic (39.79s)
--- PASS: TestAccAWSVpcEndpointRouteTableAssociation_disappears (27.93s)
--- PASS: TestAccAWSRoute_IPv4_To_NatGateway (187.01s)
--- PASS: TestAccAWSRoute_IPv6_Update_Target (176.93s)
--- PASS: TestAccAWSRouteTable_IPv4_To_VpcEndpoint (379.06s)
--- PASS: TestAccAWSRouteTable_IPv4_To_TransitGateway (397.62s)
--- PASS: TestAccAWSRoute_IPv6_To_Instance (338.34s)
--- PASS: TestAccAWSRoute_PrefixList_To_NatGateway (202.83s)
--- PASS: TestAccAWSRoute_IPv4_To_VpcEndpoint (256.37s)
--- PASS: TestAccAWSVpcEndpoint_gatewayBasic (25.71s)
--- PASS: TestAccAWSRoute_IPv4_To_TransitGateway (353.62s)
--- PASS: TestAccAWSVpcEndpoint_gatewayPolicy (50.30s)
--- PASS: TestAccAWSVpcEndpoint_gatewayWithRouteTableAndPolicy (55.47s)
--- PASS: TestAccAWSRoute_PrefixList_To_Instance (301.94s)
--- PASS: TestAccAWSVpcEndpointService_GatewayLoadBalancerArns (219.21s)
--- PASS: TestAccAWSVpcEndpoint_interfaceBasic (74.35s)
--- PASS: TestAccAWSVpcEndpointService_basic (249.60s)
--- PASS: TestAccAWSVpcEndpointServiceAllowedPrincipal_basic (263.99s)
--- PASS: TestAccAWSVpcEndpoint_disappears (29.31s)
--- PASS: TestAccAWSVpcEndpointService_AllowedPrincipals (269.86s)
--- PASS: TestAccAWSRoute_IPv6_To_TransitGateway (389.68s)
--- PASS: TestAccAWSRoute_PrefixList_To_NetworkInterface_Attached (342.75s)
--- PASS: TestAccAWSVpcEndpoint_tags (52.19s)
--- PASS: TestAccAWSVpcEndpointService_tags (280.96s)
--- PASS: TestAccAWSVpcEndpointService_private_dns_name (271.32s)
--- PASS: TestAccAWSVpcEndpointConnectionNotification_basic (354.73s)
--- PASS: TestAccAWSRoute_PrefixList_To_TransitGateway (367.84s)
--- PASS: TestAccAWSVpcEndpointSubnetAssociation_basic (254.91s)
--- PASS: TestAccAWSVpcEndpointSubnetAssociation_disappears (258.64s)
--- PASS: TestAccAWSVpcEndpointService_disappears (359.86s)
--- PASS: TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnCreate (259.69s)
--- PASS: TestAccAWSVpcEndpoint_VpcEndpointType_GatewayLoadBalancer (260.98s)
--- PASS: TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnUpdate (289.50s)
--- PASS: TestAccAWSRoute_IPv4_Update_Target (614.71s)
--- PASS: TestAccAWSVpcEndpoint_interfaceWithSubnetAndSecurityGroup (377.67s)
--- PASS: TestAccAWSVpcEndpointSubnetAssociation_multiple (606.25s)
This functionality has been released in v3.47.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #19133.
Closes #11743.
Closes #19405.
Original PR description:
@alewando's commits have been enhanced with additional retries around all route creation, deletion and modification and all route table creation and deletion.
Falling out of that work, waiters have been added so that route table associations actually wait for the associations to reach the correct state.
Acceptance test output:
Commercial
GovCloud