r/servicecatalog_service_action: New resource #19369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
size/XL
YakDriver
force-pushed
the
f-servicecat-serviceaction
branch
from
54b511c
to
f76240a
Compare
ewbankkit
reviewed
May 18, 2021
| } | ||
|
|
||
| if tfawserr.ErrCodeEquals(err, servicecatalog.ErrCodeResourceNotFoundException) { | ||
| log.Printf("[INFO] Attempted to delete Service Action (%s) but does not exist", d.Id()) |
There was a problem hiding this comment.
We don't normally log this condition.
ewbankkit
approved these changes
May 18, 2021
There was a problem hiding this comment.
LGTM 🚀.
Commercial
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSServiceCatalogServiceAction_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSServiceCatalogServiceAction_ -timeout 180m
=== RUN TestAccAWSServiceCatalogServiceAction_basic
=== PAUSE TestAccAWSServiceCatalogServiceAction_basic
=== RUN TestAccAWSServiceCatalogServiceAction_disappears
=== PAUSE TestAccAWSServiceCatalogServiceAction_disappears
=== RUN TestAccAWSServiceCatalogServiceAction_update
=== PAUSE TestAccAWSServiceCatalogServiceAction_update
=== CONT TestAccAWSServiceCatalogServiceAction_basic
=== CONT TestAccAWSServiceCatalogServiceAction_update
=== CONT TestAccAWSServiceCatalogServiceAction_disappears
--- PASS: TestAccAWSServiceCatalogServiceAction_disappears (11.61s)
--- PASS: TestAccAWSServiceCatalogServiceAction_basic (15.18s)
--- PASS: TestAccAWSServiceCatalogServiceAction_update (24.92s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 27.876sGovCloud
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSServiceCatalogServiceAction_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSServiceCatalogServiceAction_ -timeout 180m
=== RUN TestAccAWSServiceCatalogServiceAction_basic
=== PAUSE TestAccAWSServiceCatalogServiceAction_basic
=== RUN TestAccAWSServiceCatalogServiceAction_disappears
=== PAUSE TestAccAWSServiceCatalogServiceAction_disappears
=== RUN TestAccAWSServiceCatalogServiceAction_update
=== PAUSE TestAccAWSServiceCatalogServiceAction_update
=== CONT TestAccAWSServiceCatalogServiceAction_basic
=== CONT TestAccAWSServiceCatalogServiceAction_update
=== CONT TestAccAWSServiceCatalogServiceAction_disappears
--- PASS: TestAccAWSServiceCatalogServiceAction_disappears (13.35s)
--- PASS: TestAccAWSServiceCatalogServiceAction_basic (17.82s)
--- PASS: TestAccAWSServiceCatalogServiceAction_update (31.71s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 34.658s
YakDriver
force-pushed
the
f-servicecat-serviceaction
branch
from
f76240a
to
ab28fd7
Compare
YakDriver
force-pushed
the
f-servicecat-serviceaction
branch
from
ab28fd7
to
da9e5cd
Compare
|
This has been released in version 3.42.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates #15369
Relates #18074
Relates #19122
Output from acceptance testing (
us-west-2):Output from acceptance testing (GovCloud):