Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource: f-aws_qldb_stream #19297

Merged
merged 70 commits into from
Apr 13, 2022
Merged

New resource: f-aws_qldb_stream #19297

merged 70 commits into from
Apr 13, 2022

Conversation

frumpled
Copy link
Contributor

@frumpled frumpled commented May 10, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #17471.
Closes #21711.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSQLDBStream_basic' 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSQLDBStream_basic -timeout 180m
=== RUN   TestAccAWSQLDBStream_basic
2021/05/19 14:25:32 Checking for QLDB stream's existence... aws_qldb_stream.test
=== PAUSE TestAccAWSQLDBStream_basic
=== CONT  TestAccAWSQLDBStream_basic
    resource_aws_qldb_stream_test.go:145: Step 1/3 error: Error running pre-apply refresh: 
        Error: Could not load plugin
        
        
        Plugin reinitialization required. Please run "terraform init".
        
        Plugins are external binaries that Terraform uses to access and manipulate
        resources. The configuration provided requires plugins which can't be
        located,
        don't satisfy the version constraints, or are otherwise incompatible.
        
        Terraform automatically discovers provider requirements from your
        configuration, including providers used in child modules. To see the
        requirements and constraints, run "terraform providers".
        
        failed to instantiate provider "registry.terraform.io/hashicorp/time" to
        obtain schema: unknown provider "registry.terraform.io/hashicorp/time"
        
    testing_new.go:56: Error retrieving state, there may be dangling resources: 
        Error: Could not load plugin
        
        
        Plugin reinitialization required. Please run "terraform init".
        
        Plugins are external binaries that Terraform uses to access and manipulate
        resources. The configuration provided requires plugins which can't be
        located,
        don't satisfy the version constraints, or are otherwise incompatible.
        
        Terraform automatically discovers provider requirements from your
        configuration, including providers used in child modules. To see the
        requirements and constraints, run "terraform providers".
        
        failed to instantiate provider "registry.terraform.io/hashicorp/time" to
        obtain schema: unknown provider "registry.terraform.io/hashicorp/time"
        
        
--- FAIL: TestAccAWSQLDBStream_basic (1.06s)
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	1.098s
FAIL
make: *** [GNUmakefile:28: testacc] Error 1

@frumpled frumpled requested a review from a team as a code owner May 10, 2021 15:46
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/qldb Issues and PRs that pertain to the qldb service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 10, 2021
Acceptance test output:

% make testacc TESTS=TestAccQLDBStream_basic PKG=qldb
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/qldb/... -v -count 1 -parallel 20 -run='TestAccQLDBStream_basic'  -timeout 180m
=== RUN   TestAccQLDBStream_basic
=== PAUSE TestAccQLDBStream_basic
=== CONT  TestAccQLDBStream_basic
--- PASS: TestAccQLDBStream_basic (212.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/qldb	215.880s
Acceptance test output:

% make testacc TESTS=TestAccQLDBStream_ PKG=qldb ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/qldb/... -v -count 1 -parallel 3 -run='TestAccQLDBStream_'  -timeout 180m
=== RUN   TestAccQLDBStream_basic
=== PAUSE TestAccQLDBStream_basic
=== RUN   TestAccQLDBStream_disappears
=== PAUSE TestAccQLDBStream_disappears
=== RUN   TestAccQLDBStream_tags
=== PAUSE TestAccQLDBStream_tags
=== RUN   TestAccQLDBStream_withEndTime
=== PAUSE TestAccQLDBStream_withEndTime
=== CONT  TestAccQLDBStream_basic
=== CONT  TestAccQLDBStream_tags
=== CONT  TestAccQLDBStream_disappears
--- PASS: TestAccQLDBStream_basic (179.71s)
=== CONT  TestAccQLDBStream_withEndTime
--- PASS: TestAccQLDBStream_disappears (210.84s)
--- PASS: TestAccQLDBStream_tags (257.82s)
--- PASS: TestAccQLDBStream_withEndTime (267.76s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/qldb	451.569s
Acceptance test output:

% make testacc TESTS=TestAccQLDBLedger_basic PKG=qldb ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/qldb/... -v -count 1 -parallel 3 -run='TestAccQLDBLedger_basic'  -timeout 180m
=== RUN   TestAccQLDBLedger_basic
=== PAUSE TestAccQLDBLedger_basic
=== CONT  TestAccQLDBLedger_basic
--- PASS: TestAccQLDBLedger_basic (251.31s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/qldb	254.902s
Acceptance test output:

% make testacc TESTS=TestAccQLDBLedger_ PKG=qldb ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/qldb/... -v -count 1 -parallel 2 -run='TestAccQLDBLedger_'  -timeout 180m
=== RUN   TestAccQLDBLedger_basic
=== PAUSE TestAccQLDBLedger_basic
=== RUN   TestAccQLDBLedger_nameGenerated
=== PAUSE TestAccQLDBLedger_nameGenerated
=== RUN   TestAccQLDBLedger_update
=== PAUSE TestAccQLDBLedger_update
=== RUN   TestAccQLDBLedger_tags
=== PAUSE TestAccQLDBLedger_tags
=== CONT  TestAccQLDBLedger_basic
=== CONT  TestAccQLDBLedger_update
--- PASS: TestAccQLDBLedger_basic (171.24s)
=== CONT  TestAccQLDBLedger_tags
--- PASS: TestAccQLDBLedger_update (198.04s)
=== CONT  TestAccQLDBLedger_nameGenerated
--- PASS: TestAccQLDBLedger_tags (197.82s)
--- PASS: TestAccQLDBLedger_nameGenerated (210.43s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/qldb	414.286s
Acceptance test output:

% make testacc TESTS=TestAccQLDBLedger_disappears PKG=qldb
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/qldb/... -v -count 1 -parallel 20 -run='TestAccQLDBLedger_disappears'  -timeout 180m
=== RUN   TestAccQLDBLedger_disappears
=== PAUSE TestAccQLDBLedger_disappears
=== CONT  TestAccQLDBLedger_disappears
--- PASS: TestAccQLDBLedger_disappears (176.82s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/qldb	180.235s
Acceptance test output:

% make testacc TESTS=TestAccQLDBLedgerDataSource_ PKG=qldb
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/qldb/... -v -count 1 -parallel 20 -run='TestAccQLDBLedgerDataSource_'  -timeout 180m
=== RUN   TestAccQLDBLedgerDataSource_basic
=== PAUSE TestAccQLDBLedgerDataSource_basic
=== CONT  TestAccQLDBLedgerDataSource_basic
--- PASS: TestAccQLDBLedgerDataSource_basic (208.71s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/qldb	212.653s
Acceptance test output:

% make testacc TESTS=TestAccQLDBLedger_kmsKey PKG=qldb
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/qldb/... -v -count 1 -parallel 20 -run='TestAccQLDBLedger_kmsKey'  -timeout 180m
=== RUN   TestAccQLDBLedger_kmsKey
=== PAUSE TestAccQLDBLedger_kmsKey
=== CONT  TestAccQLDBLedger_kmsKey
--- PASS: TestAccQLDBLedger_kmsKey (210.80s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/qldb	214.550s
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccQLDBLedger_\|TestAccQLDBLedgerDataSource_\|TestAccQLDBStream_' PKG=qldb ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/qldb/... -v -count 1 -parallel 3  -run=TestAccQLDBLedger_\|TestAccQLDBLedgerDataSource_\|TestAccQLDBStream_ -timeout 180m
=== RUN   TestAccQLDBLedgerDataSource_basic
=== PAUSE TestAccQLDBLedgerDataSource_basic
=== RUN   TestAccQLDBLedger_basic
=== PAUSE TestAccQLDBLedger_basic
=== RUN   TestAccQLDBLedger_disappears
=== PAUSE TestAccQLDBLedger_disappears
=== RUN   TestAccQLDBLedger_nameGenerated
=== PAUSE TestAccQLDBLedger_nameGenerated
=== RUN   TestAccQLDBLedger_update
=== PAUSE TestAccQLDBLedger_update
=== RUN   TestAccQLDBLedger_kmsKey
=== PAUSE TestAccQLDBLedger_kmsKey
=== RUN   TestAccQLDBLedger_tags
=== PAUSE TestAccQLDBLedger_tags
=== RUN   TestAccQLDBStream_basic
=== PAUSE TestAccQLDBStream_basic
=== RUN   TestAccQLDBStream_disappears
=== PAUSE TestAccQLDBStream_disappears
=== RUN   TestAccQLDBStream_tags
=== PAUSE TestAccQLDBStream_tags
=== RUN   TestAccQLDBStream_withEndTime
=== PAUSE TestAccQLDBStream_withEndTime
=== CONT  TestAccQLDBLedgerDataSource_basic
=== CONT  TestAccQLDBStream_withEndTime
=== CONT  TestAccQLDBLedger_kmsKey
--- PASS: TestAccQLDBLedgerDataSource_basic (167.95s)
=== CONT  TestAccQLDBLedger_nameGenerated
--- PASS: TestAccQLDBStream_withEndTime (174.58s)
=== CONT  TestAccQLDBLedger_update
--- PASS: TestAccQLDBLedger_kmsKey (253.80s)
=== CONT  TestAccQLDBLedger_disappears
--- PASS: TestAccQLDBLedger_nameGenerated (157.96s)
=== CONT  TestAccQLDBLedger_basic
--- PASS: TestAccQLDBLedger_update (192.74s)
=== CONT  TestAccQLDBStream_disappears
--- PASS: TestAccQLDBLedger_disappears (152.14s)
=== CONT  TestAccQLDBStream_tags
--- PASS: TestAccQLDBLedger_basic (156.17s)
=== CONT  TestAccQLDBStream_basic
--- PASS: TestAccQLDBStream_disappears (169.45s)
=== CONT  TestAccQLDBLedger_tags
--- PASS: TestAccQLDBStream_tags (239.68s)
--- PASS: TestAccQLDBStream_basic (180.91s)
--- PASS: TestAccQLDBLedger_tags (200.72s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/qldb	741.078s

@ewbankkit
Copy link
Contributor

@frumpled Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 31dcb99 into hashicorp:main Apr 13, 2022
@github-actions github-actions bot added this to the v4.10.0 milestone Apr 13, 2022
@github-actions
Copy link

This functionality has been released in v4.10.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2022
@frumpled frumpled deleted the f-aws_qldb_stream branch June 1, 2022 18:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/qldb Issues and PRs that pertain to the qldb service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for AWS QLDB Ledger KMS Customer Managed Key New Resource - QLDB Data Streams
5 participants