Add support for aws_cloudwatch_metric_stream

[gcacace]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #18525

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSCloudWatchMetricStream'

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCloudWatchMetricStream -timeout 180m
=== RUN   TestAccAWSCloudWatchMetricStream_basic
=== PAUSE TestAccAWSCloudWatchMetricStream_basic
=== RUN   TestAccAWSCloudWatchMetricStream_noName
=== PAUSE TestAccAWSCloudWatchMetricStream_noName
=== RUN   TestAccAWSCloudWatchMetricStream_namePrefix
=== PAUSE TestAccAWSCloudWatchMetricStream_namePrefix
=== RUN   TestAccAWSCloudWatchMetricStream_includeFilters
=== PAUSE TestAccAWSCloudWatchMetricStream_includeFilters
=== RUN   TestAccAWSCloudWatchMetricStream_excludeFilters
=== PAUSE TestAccAWSCloudWatchMetricStream_excludeFilters
=== RUN   TestAccAWSCloudWatchMetricStream_update
=== PAUSE TestAccAWSCloudWatchMetricStream_update
=== RUN   TestAccAWSCloudWatchMetricStream_updateName
=== PAUSE TestAccAWSCloudWatchMetricStream_updateName
=== CONT  TestAccAWSCloudWatchMetricStream_basic
=== CONT  TestAccAWSCloudWatchMetricStream_update
=== CONT  TestAccAWSCloudWatchMetricStream_excludeFilters
=== CONT  TestAccAWSCloudWatchMetricStream_namePrefix
=== CONT  TestAccAWSCloudWatchMetricStream_includeFilters
=== CONT  TestAccAWSCloudWatchMetricStream_noName
=== CONT  TestAccAWSCloudWatchMetricStream_updateName
--- PASS: TestAccAWSCloudWatchMetricStream_excludeFilters (35.26s)
--- PASS: TestAccAWSCloudWatchMetricStream_includeFilters (35.35s)
--- PASS: TestAccAWSCloudWatchMetricStream_noName (35.40s)
--- PASS: TestAccAWSCloudWatchMetricStream_namePrefix (37.61s)
--- PASS: TestAccAWSCloudWatchMetricStream_basic (111.76s)
--- PASS: TestAccAWSCloudWatchMetricStream_update (125.37s)
--- PASS: TestAccAWSCloudWatchMetricStream_updateName (191.73s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	193.508s

[github-actions]

Welcome @gcacace 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[YakDriver]

@gcacace After a quick scan, this PR is looking good. Overall, the neatness and completeness, with implementation, docs, tests, is great! Thank you for submitting it! I may point out a few minor items. Also, I encourage you to check the "allow edits by maintainers" box to facilitate getting this merged more quickly.

[YakDriver]

Thanks for your time on this!

[gcacace]

Hi @YakDriver, wondering if I've missed anything here apart from your comments that I've addressed in the latest revision.

[frankreno]

Hi Folks, is there any eta on when this will be merged, released, and supported by TF? This is a great add we are ourselves waiting on.

[gcacace]

@YakDriver it has been almost 20 days since I've replied and fixed all the review comments. Is there any chance we can get this merged?

[YakDriver]

@gcacace I was unable to push to your branch to fix remaining issues. I'm not sure if you "allow edits by maintainers" or if it fails because your branch name is "main." It is best to name branches following the convention of f- prefix for features, like a new resource (d- for docs, td- for technical debt, b- for bugs). One thing I notice that you'll need is to add, since the resource has tags, is the default tags capability. All resources should now have them. You can find examples in any resource with tags. Fixes needed for default tags:

1. tags_all addition to schema
2. Create: defaultTagsConfig addition, calculate tags var with MergeTags(), tags.IgnoreAWS()...
3. Read: defaultTagsConfig, ignoreTagsConfig additions, if err := d.Set("tags"..., if err := d.Set("tags_all"...
4. Update: if d.HasChang("tags_all")...

[YakDriver]

This will be superceded by #19429

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.