service/fms: Fix acceptance testing and use API model regular expression for resource_type and resource_type_list argument plan time validation

[bflad]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #17399
Closes #18551

Output from acceptance testing in AWS Commercial (main account):

--- PASS: TestAccAWSFms_serial (6.69s)
    --- PASS: TestAccAWSFms_serial/AdminAccount (1.13s)
        --- SKIP: TestAccAWSFms_serial/AdminAccount/basic (1.13s)
    --- PASS: TestAccAWSFms_serial/Policy (5.56s)
        --- SKIP: TestAccAWSFms_serial/Policy/tags (0.10s)
        --- SKIP: TestAccAWSFms_serial/Policy/basic (0.10s)
        --- SKIP: TestAccAWSFms_serial/Policy/cloudfrontDistribution (0.09s)
        --- SKIP: TestAccAWSFms_serial/Policy/includeMap (0.11s)
        --- SKIP: TestAccAWSFms_serial/Policy/update (5.16s)

Output from acceptance testing in AWS Commercial (Organizations account):

--- PASS: TestAccAWSFms_serial (8148.92s)
    --- PASS: TestAccAWSFms_serial/AdminAccount (1260.56s)
        --- PASS: TestAccAWSFms_serial/AdminAccount/basic (1260.56s)
    --- PASS: TestAccAWSFms_serial/Policy (6888.35s)
        --- PASS: TestAccAWSFms_serial/Policy/cloudfrontDistribution (2277.23s)
        --- PASS: TestAccAWSFms_serial/Policy/includeMap (1253.20s)
        --- PASS: TestAccAWSFms_serial/Policy/update (1147.13s)
        --- PASS: TestAccAWSFms_serial/Policy/tags (1095.08s)
        --- PASS: TestAccAWSFms_serial/Policy/basic (1115.72s)

[anGie44]

changes here look great! my only note is that in the resource docs for fms_policy, the "Valid values" in the resource_type and resource_type_list arg descriptions could point to the AWS documentation instead of an explicit list as its not entirely inclusive.

Update: Output of tests (organizations account)

--- PASS: TestAccAWSFms_serial (8719.25s)
    --- PASS: TestAccAWSFms_serial/AdminAccount (1228.91s)
        --- PASS: TestAccAWSFms_serial/AdminAccount/basic (1228.91s)
    --- PASS: TestAccAWSFms_serial/Policy (7490.34s)
        --- PASS: TestAccAWSFms_serial/Policy/tags (1248.56s)
        --- PASS: TestAccAWSFms_serial/Policy/basic (1236.79s)
        --- PASS: TestAccAWSFms_serial/Policy/cloudfrontDistribution (1353.20s)
        --- PASS: TestAccAWSFms_serial/Policy/includeMap (1255.28s)
        --- PASS: TestAccAWSFms_serial/Policy/update (2396.52s)

[bflad]

my only note is that in the resource docs for fms_policy, the "Valid values" in the resource_type and resource_type_list arg descriptions could point to the AWS documentation instead of an explicit list as its not entirely inclusive.

Yes it should! Updated in latest commit.

[ghost]

This has been released in version 3.37.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!