Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rd/iam_policy - tagging support #18276

Merged
merged 11 commits into from
Mar 26, 2021
Merged

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Mar 19, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #17594

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSIAMPolicy_'
--- PASS: TestAccAWSIAMPolicy_disappears (27.88s)
--- PASS: TestAccAWSIAMPolicy_description (40.09s)
--- PASS: TestAccAWSIAMPolicy_path (40.27s)
--- PASS: TestAccAWSIAMPolicy_namePrefix (40.36s)
--- PASS: TestAccAWSIAMPolicy_basic (40.69s)
--- PASS: TestAccAWSIAMPolicy_policy (68.83s)
--- PASS: TestAccAWSIAMPolicy_tags (91.92s)


--- PASS: TestAccAWSDataSourceIAMPolicy_basic (36.37s)

@DrFaust92 DrFaust92 requested a review from a team as a code owner March 19, 2021 07:48
@ghost ghost added size/L Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/iam Issues and PRs that pertain to the iam service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 19, 2021
@DrFaust92 DrFaust92 changed the title r/iam_policy - tagging support rd/iam_policy - tagging support Mar 19, 2021
@DrFaust92 DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Mar 19, 2021
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. and removed size/L Managed by automation to categorize the size of a PR. labels Mar 19, 2021
@ewbankkit
Copy link
Contributor

Verified acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSIAMPolicy_\|TestAccAWSDataSourceIAMPolicy_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSIAMPolicy_\|TestAccAWSDataSourceIAMPolicy_ -timeout 180m
=== RUN   TestAccAWSDataSourceIAMPolicy_basic
=== PAUSE TestAccAWSDataSourceIAMPolicy_basic
=== RUN   TestAccAWSIAMPolicy_basic
=== PAUSE TestAccAWSIAMPolicy_basic
=== RUN   TestAccAWSIAMPolicy_description
=== PAUSE TestAccAWSIAMPolicy_description
=== RUN   TestAccAWSIAMPolicy_tags
=== PAUSE TestAccAWSIAMPolicy_tags
=== RUN   TestAccAWSIAMPolicy_disappears
=== PAUSE TestAccAWSIAMPolicy_disappears
=== RUN   TestAccAWSIAMPolicy_namePrefix
=== PAUSE TestAccAWSIAMPolicy_namePrefix
=== RUN   TestAccAWSIAMPolicy_path
=== PAUSE TestAccAWSIAMPolicy_path
=== RUN   TestAccAWSIAMPolicy_policy
=== PAUSE TestAccAWSIAMPolicy_policy
=== CONT  TestAccAWSDataSourceIAMPolicy_basic
=== CONT  TestAccAWSIAMPolicy_disappears
=== CONT  TestAccAWSIAMPolicy_namePrefix
=== CONT  TestAccAWSIAMPolicy_policy
=== CONT  TestAccAWSIAMPolicy_path
=== CONT  TestAccAWSIAMPolicy_tags
=== CONT  TestAccAWSIAMPolicy_description
=== CONT  TestAccAWSIAMPolicy_basic
--- PASS: TestAccAWSIAMPolicy_disappears (23.59s)
--- PASS: TestAccAWSDataSourceIAMPolicy_basic (26.33s)
--- PASS: TestAccAWSIAMPolicy_basic (29.82s)
--- PASS: TestAccAWSIAMPolicy_namePrefix (29.98s)
--- PASS: TestAccAWSIAMPolicy_description (29.98s)
--- PASS: TestAccAWSIAMPolicy_path (30.00s)
--- PASS: TestAccAWSIAMPolicy_policy (38.79s)
--- PASS: TestAccAWSIAMPolicy_tags (46.39s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	46.523s

@bflad bflad self-assigned this Mar 25, 2021
.changelog/18276.txt Outdated Show resolved Hide resolved
.changelog/18276.txt Outdated Show resolved Hide resolved
.changelog/18276.txt Outdated Show resolved Hide resolved
website/docs/r/iam_policy.html.markdown Outdated Show resolved Hide resolved
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you, @DrFaust92 🚀

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSDataSourceIAMPolicy_basic (20.45s)

--- PASS: TestAccAWSIAMPolicy_basic (22.11s)
--- PASS: TestAccAWSIAMPolicy_description (21.92s)
--- PASS: TestAccAWSIAMPolicy_disappears (18.51s)
--- PASS: TestAccAWSIAMPolicy_namePrefix (22.36s)
--- PASS: TestAccAWSIAMPolicy_path (22.27s)
--- PASS: TestAccAWSIAMPolicy_policy (29.66s)
--- PASS: TestAccAWSIAMPolicy_tags (36.52s)

Output from acceptance testing in AWS GovCloud (US):

--- PASS: TestAccAWSDataSourceIAMPolicy_basic (25.35s)

--- PASS: TestAccAWSIAMPolicy_basic (27.37s)
--- PASS: TestAccAWSIAMPolicy_description (27.37s)
--- PASS: TestAccAWSIAMPolicy_disappears (21.46s)
--- PASS: TestAccAWSIAMPolicy_namePrefix (27.86s)
--- PASS: TestAccAWSIAMPolicy_path (27.19s)
--- PASS: TestAccAWSIAMPolicy_policy (41.21s)
--- PASS: TestAccAWSIAMPolicy_tags (53.53s)

@bflad bflad merged commit 3a08c22 into hashicorp:main Mar 26, 2021
@github-actions github-actions bot added this to the v3.35.0 milestone Mar 26, 2021
@ghost
Copy link

ghost commented Apr 1, 2021

This has been released in version 3.35.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Apr 26, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. provider Pertains to the provider itself, rather than any interaction with AWS. service/iam Issues and PRs that pertain to the iam service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants