r/iam_oidc_provider - add tagging support + validations + sweeper

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #17594

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSIAMOpenIDConnectProvider_'
--- PASS: TestAccAWSIAMOpenIDConnectProvider_disappears (27.34s)
--- PASS: TestAccAWSIAMOpenIDConnectProvider_basic (56.82s)
--- PASS: TestAccAWSIAMOpenIDConnectProvider_tags (78.49s)

[ewbankkit]

Verified acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSIAMOpenIDConnectProvider_' 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSIAMOpenIDConnectProvider_ -timeout 120m
=== RUN   TestAccAWSIAMOpenIDConnectProvider_basic
=== PAUSE TestAccAWSIAMOpenIDConnectProvider_basic
=== RUN   TestAccAWSIAMOpenIDConnectProvider_tags
=== PAUSE TestAccAWSIAMOpenIDConnectProvider_tags
=== RUN   TestAccAWSIAMOpenIDConnectProvider_disappears
=== PAUSE TestAccAWSIAMOpenIDConnectProvider_disappears
=== CONT  TestAccAWSIAMOpenIDConnectProvider_basic
=== CONT  TestAccAWSIAMOpenIDConnectProvider_disappears
=== CONT  TestAccAWSIAMOpenIDConnectProvider_tags
--- PASS: TestAccAWSIAMOpenIDConnectProvider_disappears (11.47s)
--- PASS: TestAccAWSIAMOpenIDConnectProvider_basic (23.76s)
--- PASS: TestAccAWSIAMOpenIDConnectProvider_tags (31.17s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	31.281s

[ewbankkit]

Ran sweeper:

$ TEST=./aws SWEEP=us-west-2 SWEEPARGS=-sweep-run=aws_iam_openid_connect_provider make sweep
WARNING: This will destroy infrastructure. Use only in development accounts.
go test ./aws -v -sweep=us-west-2 -sweep-run=aws_iam_openid_connect_provider -timeout 60m
2021/03/06 16:48:56 [DEBUG] Running Sweepers for region (us-west-2):
2021/03/06 16:48:56 [DEBUG] Running Sweeper (aws_iam_openid_connect_provider) in region (us-west-2)
2021/03/06 16:48:56 [INFO] AWS Auth provider used: "EnvProvider"
2021/03/06 16:48:56 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2021/03/06 16:48:56 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2021/03/06 16:48:57 Sweeper Tests ran successfully:
	- aws_iam_openid_connect_provider
ok  	github.com/terraform-providers/terraform-provider-aws/aws	0.851s

[bflad]

Verified this does not have an available paginator or token to manually do so.

[bflad]

Looks great, thank you, @DrFaust92 🚀

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSIAMOpenIDConnectProvider_disappears (10.03s)
--- PASS: TestAccAWSIAMOpenIDConnectProvider_basic (20.50s)
--- PASS: TestAccAWSIAMOpenIDConnectProvider_tags (32.26s)

Output from acceptance testing in AWS GovCloud (US):

--- PASS: TestAccAWSIAMOpenIDConnectProvider_disappears (15.58s)
--- PASS: TestAccAWSIAMOpenIDConnectProvider_basic (36.70s)
--- PASS: TestAccAWSIAMOpenIDConnectProvider_tags (47.27s)

[ghost]

This has been released in version 3.34.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!