Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/neptune_cluster_parameter_group: update parameter field modification on create/update #17872

Merged
merged 2 commits into from
Mar 2, 2021

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Mar 2, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #17870

Output from acceptance testing:

--- PASS: TestAccAWSNeptuneClusterParameterGroup_namePrefix (16.91s)
--- PASS: TestAccAWSNeptuneClusterParameterGroup_basic (16.91s)
--- PASS: TestAccAWSNeptuneClusterParameterGroup_Description (16.93s)
--- PASS: TestAccAWSNeptuneClusterParameterGroup_generatedName (16.94s)
--- PASS: TestAccAWSNeptuneClusterParameterGroup_NamePrefix_Parameter (28.77s)
--- PASS: TestAccAWSNeptuneClusterParameterGroup_Parameter (28.96s)
--- PASS: TestAccAWSNeptuneClusterParameterGroup_Tags (39.71s)

@anGie44 anGie44 requested a review from a team as a code owner March 2, 2021 04:42
@ghost ghost added size/L Managed by automation to categorize the size of a PR. service/neptune Issues and PRs that pertain to the neptune service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 2, 2021
@anGie44 anGie44 added the bug Addresses a defect in current functionality. label Mar 2, 2021
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSNeptuneClusterParameterGroup_namePrefix (23.16s)
--- PASS: TestAccAWSNeptuneClusterParameterGroup_generatedName (23.18s)
--- PASS: TestAccAWSNeptuneClusterParameterGroup_basic (23.39s)
--- PASS: TestAccAWSNeptuneClusterParameterGroup_Description (23.51s)
--- PASS: TestAccAWSNeptuneClusterParameterGroup_Parameter (33.94s)
--- PASS: TestAccAWSNeptuneClusterParameterGroup_NamePrefix_Parameter (34.17s)
--- PASS: TestAccAWSNeptuneClusterParameterGroup_Tags (44.63s)

Output from acceptance testing in AWS GovCloud (US):

--- PASS: TestAccAWSNeptuneClusterParameterGroup_basic (25.21s)
--- PASS: TestAccAWSNeptuneClusterParameterGroup_generatedName (25.67s)
--- PASS: TestAccAWSNeptuneClusterParameterGroup_namePrefix (25.70s)
--- PASS: TestAccAWSNeptuneClusterParameterGroup_Description (25.72s)
--- PASS: TestAccAWSNeptuneClusterParameterGroup_NamePrefix_Parameter (39.75s)
--- PASS: TestAccAWSNeptuneClusterParameterGroup_Parameter (39.89s)
--- PASS: TestAccAWSNeptuneClusterParameterGroup_Tags (52.71s)

@anGie44 anGie44 added this to the v3.31.0 milestone Mar 2, 2021
@anGie44 anGie44 merged commit a8e7f75 into main Mar 2, 2021
@anGie44 anGie44 deleted the b-neptune-parameter-group-update branch March 2, 2021 16:09
github-actions bot pushed a commit that referenced this pull request Mar 2, 2021
@ghost
Copy link

ghost commented Mar 5, 2021

This has been released in version 3.31.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Apr 1, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/neptune Issues and PRs that pertain to the neptune service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resource_aws_neptune_cluster_parameter_group attempts to use name before it is assigned
2 participants