r/ssm_association - validations + wait for association argument + arn attribute

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSSSMAssociation_'
--- PASS: TestAccSSMAssociation_withDocumentVersion (52.79s)
--- PASS: TestAccSSMAssociation_applyOnlyAtCronInterval (85.90s)
--- PASS: TestAccSSMAssociation_withScheduleExpression (86.16s)
--- PASS: TestAccSSMAssociation_withAssociationNameAndScheduleExpression (86.24s)
--- PASS: TestAccSSMAssociation_withParameters (86.36s)
--- PASS: TestAccSSMAssociation_rateControl (86.36s)
--- PASS: TestAccSSMAssociation_withAssociationName (92.62s)
--- PASS: TestAccSSMAssociation_withComplianceSeverity (93.61s)
--- PASS: TestAccSSMAssociation_withTargets (117.98s)
--- PASS: TestAccSSMAssociation_disappears_document (157.77s)
--- PASS: TestAccSSMAssociation_disappears (166.70s)
--- PASS: TestAccSSMAssociation_basic (174.55s)
--- PASS: TestAccSSMAssociation_withOutputLocation_s3Region (188.80s)
--- PASS: TestAccSSMAssociation_withOutputLocation (200.40s)
--- PASS: TestAccSSMAssociation_withAutomationTargetParamName (110.68s)

[zhelding]

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

[ewbankkit]

LGTM 🚀.

% make testacc TESTS=TestAccSSMAssociation_ PKG=ssm
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ssm/... -v -count 1 -parallel 20 -run='TestAccSSMAssociation_'  -timeout 180m
=== RUN   TestAccSSMAssociation_basic
=== PAUSE TestAccSSMAssociation_basic
=== RUN   TestAccSSMAssociation_disappears
=== PAUSE TestAccSSMAssociation_disappears
=== RUN   TestAccSSMAssociation_disappears_document
=== PAUSE TestAccSSMAssociation_disappears_document
=== RUN   TestAccSSMAssociation_applyOnlyAtCronInterval
=== PAUSE TestAccSSMAssociation_applyOnlyAtCronInterval
=== RUN   TestAccSSMAssociation_withTargets
=== PAUSE TestAccSSMAssociation_withTargets
=== RUN   TestAccSSMAssociation_withParameters
=== PAUSE TestAccSSMAssociation_withParameters
=== RUN   TestAccSSMAssociation_withAssociationName
=== PAUSE TestAccSSMAssociation_withAssociationName
=== RUN   TestAccSSMAssociation_withAssociationNameAndScheduleExpression
=== PAUSE TestAccSSMAssociation_withAssociationNameAndScheduleExpression
=== RUN   TestAccSSMAssociation_withDocumentVersion
=== PAUSE TestAccSSMAssociation_withDocumentVersion
=== RUN   TestAccSSMAssociation_withOutputLocation
=== PAUSE TestAccSSMAssociation_withOutputLocation
=== RUN   TestAccSSMAssociation_withOutputLocation_s3Region
=== PAUSE TestAccSSMAssociation_withOutputLocation_s3Region
=== RUN   TestAccSSMAssociation_withAutomationTargetParamName
=== PAUSE TestAccSSMAssociation_withAutomationTargetParamName
=== RUN   TestAccSSMAssociation_withScheduleExpression
=== PAUSE TestAccSSMAssociation_withScheduleExpression
=== RUN   TestAccSSMAssociation_withComplianceSeverity
=== PAUSE TestAccSSMAssociation_withComplianceSeverity
=== RUN   TestAccSSMAssociation_rateControl
=== PAUSE TestAccSSMAssociation_rateControl
=== CONT  TestAccSSMAssociation_basic
=== CONT  TestAccSSMAssociation_withScheduleExpression
=== CONT  TestAccSSMAssociation_withAutomationTargetParamName
=== CONT  TestAccSSMAssociation_withComplianceSeverity
=== CONT  TestAccSSMAssociation_disappears_document
=== CONT  TestAccSSMAssociation_withDocumentVersion
=== CONT  TestAccSSMAssociation_withOutputLocation
=== CONT  TestAccSSMAssociation_withTargets
=== CONT  TestAccSSMAssociation_withAssociationNameAndScheduleExpression
=== CONT  TestAccSSMAssociation_withAssociationName
=== CONT  TestAccSSMAssociation_withOutputLocation_s3Region
=== CONT  TestAccSSMAssociation_withParameters
=== CONT  TestAccSSMAssociation_rateControl
=== CONT  TestAccSSMAssociation_disappears
=== CONT  TestAccSSMAssociation_applyOnlyAtCronInterval
--- PASS: TestAccSSMAssociation_withDocumentVersion (46.16s)
--- PASS: TestAccSSMAssociation_rateControl (84.79s)
--- PASS: TestAccSSMAssociation_withAssociationName (89.45s)
--- PASS: TestAccSSMAssociation_withParameters (89.59s)
--- PASS: TestAccSSMAssociation_withScheduleExpression (93.81s)
--- PASS: TestAccSSMAssociation_withComplianceSeverity (96.63s)
--- PASS: TestAccSSMAssociation_withAutomationTargetParamName (97.90s)
--- PASS: TestAccSSMAssociation_withAssociationNameAndScheduleExpression (107.08s)
--- PASS: TestAccSSMAssociation_applyOnlyAtCronInterval (110.28s)
--- PASS: TestAccSSMAssociation_withTargets (110.35s)
--- PASS: TestAccSSMAssociation_withOutputLocation_s3Region (138.52s)
--- PASS: TestAccSSMAssociation_basic (140.35s)
--- PASS: TestAccSSMAssociation_disappears (143.13s)
--- PASS: TestAccSSMAssociation_disappears_document (146.69s)
--- PASS: TestAccSSMAssociation_withOutputLocation (146.98s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ssm	154.129s

[ewbankkit]

@DrFaust92 Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v4.1.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.