Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_backup_plan: 'advanced_backup_setting.backup_options' and 'advanced_backup_setting.resource_type' are both Required #17692

Conversation

ewbankkit
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #17667.
Relates: hashicorp/terraform-plugin-sdk#588.

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsBackupPlan_AdvancedBackupSetting'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsBackupPlan_AdvancedBackupSetting -timeout 120m
=== RUN   TestAccAwsBackupPlan_AdvancedBackupSetting
=== PAUSE TestAccAwsBackupPlan_AdvancedBackupSetting
=== CONT  TestAccAwsBackupPlan_AdvancedBackupSetting
--- PASS: TestAccAwsBackupPlan_AdvancedBackupSetting (27.80s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	27.930s

…nced_backup_setting.resource_type' are both Required.

Acceptance test output:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsBackupPlan_AdvancedBackupSetting'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsBackupPlan_AdvancedBackupSetting -timeout 120m
=== RUN   TestAccAwsBackupPlan_AdvancedBackupSetting
=== PAUSE TestAccAwsBackupPlan_AdvancedBackupSetting
=== CONT  TestAccAwsBackupPlan_AdvancedBackupSetting
--- PASS: TestAccAwsBackupPlan_AdvancedBackupSetting (27.80s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	27.930s
@ewbankkit ewbankkit requested a review from a team as a code owner February 18, 2021 23:17
@ghost ghost added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/backup Issues and PRs that pertain to the backup service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Feb 18, 2021
Copy link
Collaborator

@DrFaust92 DrFaust92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@breathingdust
Copy link
Member

LGTM 🚀 Thanks @ewbankkit!

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsBackupPlan_AdvancedBackupSetting'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsBackupPlan_AdvancedBackupSetting -timeout 120m
=== RUN   TestAccAwsBackupPlan_AdvancedBackupSetting
=== PAUSE TestAccAwsBackupPlan_AdvancedBackupSetting
=== CONT  TestAccAwsBackupPlan_AdvancedBackupSetting
--- PASS: TestAccAwsBackupPlan_AdvancedBackupSetting (26.49s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       33.348s

Verified Acceptance Tests in GovCloud (us-gov-west-1)

make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsBackupPlan_AdvancedBackupSetting'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsBackupPlan_AdvancedBackupSetting -timeout 120m
=== RUN   TestAccAwsBackupPlan_AdvancedBackupSetting
=== PAUSE TestAccAwsBackupPlan_AdvancedBackupSetting
=== CONT  TestAccAwsBackupPlan_AdvancedBackupSetting
--- PASS: TestAccAwsBackupPlan_AdvancedBackupSetting (17.96s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       21.123s

@breathingdust breathingdust merged commit f7886da into hashicorp:main Feb 23, 2021
@github-actions github-actions bot added this to the v3.30.0 milestone Feb 23, 2021
@ewbankkit ewbankkit deleted the b-aws_backup_plan-advanced_backup_setting-no-backup-options branch February 23, 2021 17:47
@ghost
Copy link

ghost commented Feb 26, 2021

This has been released in version 3.30.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 25, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 25, 2021
@DrFaust92 DrFaust92 removed their assignment Jun 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/backup Issues and PRs that pertain to the backup service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Advanced Backup Setting Arguments backup_options is not optional
3 participants