r/ssoadmin_permission_set: include relay_state in the UpdatePermissionSet request when available

[anGie44]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #17411

Output from acceptance test before change:

    TestAccAWSSSOAdminPermissionSet_updateOnlySessionDuration: resource_aws_ssoadmin_permission_set_test.go:282: 
Step 2/3 error: Check failed: Check 4/5 error: aws_ssoadmin_permission_set.test: Attribute 'relay_state' expected "https://example.com", got ""
--- FAIL: TestAccAWSSSOAdminPermissionSet_updateOnlySessionDuration (18.79s)

Output from complete resource acceptance testing after change:

--- PASS: TestAccAWSSSOAdminPermissionSet_basic (11.95s)
--- PASS: TestAccAWSSSOAdminPermissionSet_relayState_updateSessionDuration (24.29s)
--- PASS: TestAccAWSSSOAdminPermissionSet_updateDescription (25.25s)
--- PASS: TestAccAWSSSOAdminPermissionSet_updateSessionDuration (27.61s)
--- PASS: TestAccAWSSSOAdminPermissionSet_updateRelayState (48.18s)
--- PASS: TestAccAWSSSOAdminPermissionSet_mixedPolicyAttachments (51.67s)

[bflad]

Looks good to me, although having trouble running the acceptance testing myself. May be worth all the attributes similarly (include if present vs only if changed) since usually APIs work similarly across attributes but not worth holding this up on that.

[anGie44]

sure thing I can update the other argument checks--definitely crossed my mind!

Output of acceptance tests with recent change:

--- PASS: TestAccAWSSSOAdminPermissionSet_basic (15.00s)
--- PASS: TestAccAWSSSOAdminPermissionSet_updateSessionDuration (28.19s)
--- PASS: TestAccAWSSSOAdminPermissionSet_relayState_updateSessionDuration (28.58s)
--- PASS: TestAccAWSSSOAdminPermissionSet_updateDescription (29.08s)
--- PASS: TestAccAWSSSOAdminPermissionSet_updateRelayState (29.20s)
--- PASS: TestAccAWSSSOAdminPermissionSet_mixedPolicyAttachments (31.19s)

[ghost]

This has been released in version 3.27.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!