-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resource/aws_api_gateway_method_settings: Prevent unexpected errors during creation and deletion #17234
Conversation
…uring creation and deletion Reference: #13985 Reference: #16796 Fixing this as part of API Gateway service spike work. As mentioned in the issue this will not help mitigate the cause of the problem, but will at least give a better error message. Output from acceptance testing: ``` --- PASS: TestAccAWSAPIGatewayMethodSettings_basic (25.35s) --- PASS: TestAccAWSAPIGatewayMethodSettings_disappears (247.81s) --- PASS: TestAccAWSAPIGatewayMethodSettings_Settings_CacheDataEncrypted (147.06s) --- PASS: TestAccAWSAPIGatewayMethodSettings_Settings_CacheTtlInSeconds (340.17s) --- PASS: TestAccAWSAPIGatewayMethodSettings_Settings_CachingEnabled (448.46s) --- PASS: TestAccAWSAPIGatewayMethodSettings_Settings_DataTraceEnabled (216.61s) --- PASS: TestAccAWSAPIGatewayMethodSettings_Settings_LoggingLevel (55.96s) --- PASS: TestAccAWSAPIGatewayMethodSettings_Settings_MetricsEnabled (397.43s) --- PASS: TestAccAWSAPIGatewayMethodSettings_Settings_Multiple (692.67s) --- PASS: TestAccAWSAPIGatewayMethodSettings_Settings_RequireAuthorizationForCacheControl (178.96s) --- PASS: TestAccAWSAPIGatewayMethodSettings_Settings_ThrottlingBurstLimit (118.97s) --- PASS: TestAccAWSAPIGatewayMethodSettings_Settings_ThrottlingBurstLimitDisabledByDefault (86.39s) --- PASS: TestAccAWSAPIGatewayMethodSettings_Settings_ThrottlingRateLimit (515.72s) --- PASS: TestAccAWSAPIGatewayMethodSettings_Settings_ThrottlingRateLimitDisabledByDefault (484.35s) --- PASS: TestAccAWSAPIGatewayMethodSettings_Settings_UnauthorizedCacheControlHeaderStrategy (312.16s) ```
if !ok { | ||
log.Printf("[WARN] API Gateway Method Settings for %q not found, removing", methodPath) | ||
|
||
if !d.IsNewResource() && !ok { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😎 😎
This has been released in version 3.27.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Closes #13985
Reference: #16796
Fixing this as part of API Gateway service spike work. As mentioned in the issue this will not help mitigate the cause of the problem, but will at least give a better error message.
Output from acceptance testing: