Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_globalaccelerator_*: Timeouts for Global Accelerator resources #17112

Merged
merged 1 commit into from
Jan 14, 2021
Merged

resource/aws_globalaccelerator_*: Timeouts for Global Accelerator resources #17112

merged 1 commit into from
Jan 14, 2021

Conversation

brent-au
Copy link
Contributor

@brent-au brent-au commented Jan 14, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #17048

Release note for CHANGELOG:

Add Timeouts to AWS Global Accelerator resources

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAwsGlobalAccelerator'           
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsGlobalAccelerator -timeout 120m
=== RUN   TestAccAwsGlobalAcceleratorAccelerator_basic
=== PAUSE TestAccAwsGlobalAcceleratorAccelerator_basic
=== RUN   TestAccAwsGlobalAcceleratorAccelerator_update
=== PAUSE TestAccAwsGlobalAcceleratorAccelerator_update
=== RUN   TestAccAwsGlobalAcceleratorAccelerator_attributes
=== PAUSE TestAccAwsGlobalAcceleratorAccelerator_attributes
=== RUN   TestAccAwsGlobalAcceleratorAccelerator_tags
=== PAUSE TestAccAwsGlobalAcceleratorAccelerator_tags
=== RUN   TestAccAwsGlobalAcceleratorEndpointGroup_basic
=== PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_basic
=== RUN   TestAccAwsGlobalAcceleratorEndpointGroup_disappears
=== PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_disappears
=== RUN   TestAccAwsGlobalAcceleratorEndpointGroup_ALBEndpoint_ClientIP
=== PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_ALBEndpoint_ClientIP
=== RUN   TestAccAwsGlobalAcceleratorEndpointGroup_InstanceEndpoint
=== PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_InstanceEndpoint
=== RUN   TestAccAwsGlobalAcceleratorEndpointGroup_MultiRegion
=== PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_MultiRegion
=== RUN   TestAccAwsGlobalAcceleratorEndpointGroup_PortOverrides
=== PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_PortOverrides
=== RUN   TestAccAwsGlobalAcceleratorEndpointGroup_TCPHealthCheckProtocol
=== PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_TCPHealthCheckProtocol
=== RUN   TestAccAwsGlobalAcceleratorEndpointGroup_Update
=== PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_Update
=== RUN   TestAccAwsGlobalAcceleratorListener_basic
=== PAUSE TestAccAwsGlobalAcceleratorListener_basic
=== RUN   TestAccAwsGlobalAcceleratorListener_update
=== PAUSE TestAccAwsGlobalAcceleratorListener_update
=== CONT  TestAccAwsGlobalAcceleratorAccelerator_basic
=== CONT  TestAccAwsGlobalAcceleratorEndpointGroup_MultiRegion
=== CONT  TestAccAwsGlobalAcceleratorEndpointGroup_basic
=== CONT  TestAccAwsGlobalAcceleratorListener_update
=== CONT  TestAccAwsGlobalAcceleratorListener_basic
=== CONT  TestAccAwsGlobalAcceleratorEndpointGroup_PortOverrides
=== CONT  TestAccAwsGlobalAcceleratorEndpointGroup_InstanceEndpoint
=== CONT  TestAccAwsGlobalAcceleratorEndpointGroup_ALBEndpoint_ClientIP
=== CONT  TestAccAwsGlobalAcceleratorAccelerator_attributes
=== CONT  TestAccAwsGlobalAcceleratorAccelerator_update
=== CONT  TestAccAwsGlobalAcceleratorEndpointGroup_TCPHealthCheckProtocol
=== CONT  TestAccAwsGlobalAcceleratorEndpointGroup_Update
=== CONT  TestAccAwsGlobalAcceleratorAccelerator_tags
=== CONT  TestAccAwsGlobalAcceleratorEndpointGroup_disappears
--- PASS: TestAccAwsGlobalAcceleratorAccelerator_basic (81.60s)
--- PASS: TestAccAwsGlobalAcceleratorAccelerator_attributes (95.73s)
--- PASS: TestAccAwsGlobalAcceleratorAccelerator_tags (115.54s)
--- PASS: TestAccAwsGlobalAcceleratorListener_basic (130.25s)
--- PASS: TestAccAwsGlobalAcceleratorAccelerator_update (131.40s)
--- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_MultiRegion (152.70s)
--- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_TCPHealthCheckProtocol (160.97s)
--- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_disappears (167.98s)
--- PASS: TestAccAwsGlobalAcceleratorListener_update (170.39s)
--- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_basic (181.54s)
--- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_Update (192.80s)
--- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_PortOverrides (221.51s)
--- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_InstanceEndpoint (566.37s)
--- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_ALBEndpoint_ClientIP (726.14s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       726.201s

...

This PR adds user customisable timeouts to the AWS Global Accelerator resources. Currently the timeout is set to 30 minutes for all operations in response to feedback on #17048.

Please note that a delete timeout has not been added to aws_globalaccelerator_accelerator as the deletion process involves disabling it first (covered by update timeout), after which deletion is rapid.

@brent-au brent-au requested a review from a team as a code owner January 14, 2021 15:24
@ghost ghost added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/globalaccelerator Issues and PRs that pertain to the globalaccelerator service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 14, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Jan 14, 2021
@ewbankkit ewbankkit self-assigned this Jan 14, 2021
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Jan 14, 2021
ewbankkit
ewbankkit approved these changes Jan 14, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

$ make testacc TEST=./aws TESTARGS='-run=TestAccAwsGlobalAccelerator'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsGlobalAccelerator -timeout 120m
=== RUN   TestAccAwsGlobalAcceleratorAccelerator_basic
=== PAUSE TestAccAwsGlobalAcceleratorAccelerator_basic
=== RUN   TestAccAwsGlobalAcceleratorAccelerator_update
=== PAUSE TestAccAwsGlobalAcceleratorAccelerator_update
=== RUN   TestAccAwsGlobalAcceleratorAccelerator_attributes
=== PAUSE TestAccAwsGlobalAcceleratorAccelerator_attributes
=== RUN   TestAccAwsGlobalAcceleratorAccelerator_tags
=== PAUSE TestAccAwsGlobalAcceleratorAccelerator_tags
=== RUN   TestAccAwsGlobalAcceleratorEndpointGroup_basic
=== PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_basic
=== RUN   TestAccAwsGlobalAcceleratorEndpointGroup_disappears
=== PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_disappears
=== RUN   TestAccAwsGlobalAcceleratorEndpointGroup_ALBEndpoint_ClientIP
=== PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_ALBEndpoint_ClientIP
=== RUN   TestAccAwsGlobalAcceleratorEndpointGroup_InstanceEndpoint
=== PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_InstanceEndpoint
=== RUN   TestAccAwsGlobalAcceleratorEndpointGroup_MultiRegion
=== PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_MultiRegion
=== RUN   TestAccAwsGlobalAcceleratorEndpointGroup_PortOverrides
=== PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_PortOverrides
=== RUN   TestAccAwsGlobalAcceleratorEndpointGroup_TCPHealthCheckProtocol
=== PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_TCPHealthCheckProtocol
=== RUN   TestAccAwsGlobalAcceleratorEndpointGroup_Update
=== PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_Update
=== RUN   TestAccAwsGlobalAcceleratorListener_basic
=== PAUSE TestAccAwsGlobalAcceleratorListener_basic
=== RUN   TestAccAwsGlobalAcceleratorListener_update
=== PAUSE TestAccAwsGlobalAcceleratorListener_update
=== CONT  TestAccAwsGlobalAcceleratorAccelerator_basic
=== CONT  TestAccAwsGlobalAcceleratorEndpointGroup_MultiRegion
=== CONT  TestAccAwsGlobalAcceleratorListener_update
=== CONT  TestAccAwsGlobalAcceleratorListener_basic
=== CONT  TestAccAwsGlobalAcceleratorEndpointGroup_Update
=== CONT  TestAccAwsGlobalAcceleratorEndpointGroup_TCPHealthCheckProtocol
=== CONT  TestAccAwsGlobalAcceleratorEndpointGroup_PortOverrides
=== CONT  TestAccAwsGlobalAcceleratorEndpointGroup_basic
=== CONT  TestAccAwsGlobalAcceleratorEndpointGroup_InstanceEndpoint
=== CONT  TestAccAwsGlobalAcceleratorEndpointGroup_ALBEndpoint_ClientIP
=== CONT  TestAccAwsGlobalAcceleratorEndpointGroup_disappears
=== CONT  TestAccAwsGlobalAcceleratorAccelerator_attributes
=== CONT  TestAccAwsGlobalAcceleratorAccelerator_tags
=== CONT  TestAccAwsGlobalAcceleratorAccelerator_update
--- PASS: TestAccAwsGlobalAcceleratorAccelerator_basic (124.30s)
--- PASS: TestAccAwsGlobalAcceleratorAccelerator_attributes (145.91s)
--- PASS: TestAccAwsGlobalAcceleratorAccelerator_tags (150.58s)
--- PASS: TestAccAwsGlobalAcceleratorAccelerator_update (164.49s)
--- PASS: TestAccAwsGlobalAcceleratorListener_basic (168.94s)
--- PASS: TestAccAwsGlobalAcceleratorListener_update (197.95s)
--- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_TCPHealthCheckProtocol (215.99s)
--- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_disappears (220.34s)
--- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_basic (224.84s)
--- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_MultiRegion (229.86s)
--- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_PortOverrides (254.53s)
--- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_Update (264.91s)
--- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_InstanceEndpoint (628.45s)
--- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_ALBEndpoint_ClientIP (799.11s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	799.290s

@breathingdust
Copy link
Member

LGTM 🚀 Thanks @brent-au for the contribution!

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TEST=./aws TESTARGS='-run=TestAccAwsGlobalAccelerator'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsGlobalAccelerator -timeout 120m
=== RUN   TestAccAwsGlobalAcceleratorAccelerator_basic
=== PAUSE TestAccAwsGlobalAcceleratorAccelerator_basic
=== RUN   TestAccAwsGlobalAcceleratorAccelerator_update
=== PAUSE TestAccAwsGlobalAcceleratorAccelerator_update
=== RUN   TestAccAwsGlobalAcceleratorAccelerator_attributes
=== PAUSE TestAccAwsGlobalAcceleratorAccelerator_attributes
=== RUN   TestAccAwsGlobalAcceleratorAccelerator_tags
=== PAUSE TestAccAwsGlobalAcceleratorAccelerator_tags
=== RUN   TestAccAwsGlobalAcceleratorEndpointGroup_basic
=== PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_basic
=== RUN   TestAccAwsGlobalAcceleratorEndpointGroup_disappears
=== PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_disappears
=== RUN   TestAccAwsGlobalAcceleratorEndpointGroup_ALBEndpoint_ClientIP
=== PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_ALBEndpoint_ClientIP
=== RUN   TestAccAwsGlobalAcceleratorEndpointGroup_InstanceEndpoint
=== PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_InstanceEndpoint
=== RUN   TestAccAwsGlobalAcceleratorEndpointGroup_MultiRegion
=== PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_MultiRegion
=== RUN   TestAccAwsGlobalAcceleratorEndpointGroup_PortOverrides
=== PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_PortOverrides
=== RUN   TestAccAwsGlobalAcceleratorEndpointGroup_TCPHealthCheckProtocol
=== PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_TCPHealthCheckProtocol
=== RUN   TestAccAwsGlobalAcceleratorEndpointGroup_Update
=== PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_Update
=== RUN   TestAccAwsGlobalAcceleratorListener_basic
=== PAUSE TestAccAwsGlobalAcceleratorListener_basic
=== RUN   TestAccAwsGlobalAcceleratorListener_update
=== PAUSE TestAccAwsGlobalAcceleratorListener_update
=== CONT  TestAccAwsGlobalAcceleratorAccelerator_basic
=== CONT  TestAccAwsGlobalAcceleratorEndpointGroup_MultiRegion
=== CONT  TestAccAwsGlobalAcceleratorListener_update
=== CONT  TestAccAwsGlobalAcceleratorEndpointGroup_TCPHealthCheckProtocol
=== CONT  TestAccAwsGlobalAcceleratorEndpointGroup_InstanceEndpoint
=== CONT  TestAccAwsGlobalAcceleratorEndpointGroup_ALBEndpoint_ClientIP
=== CONT  TestAccAwsGlobalAcceleratorEndpointGroup_disappears
=== CONT  TestAccAwsGlobalAcceleratorListener_basic
=== CONT  TestAccAwsGlobalAcceleratorAccelerator_attributes
=== CONT  TestAccAwsGlobalAcceleratorEndpointGroup_PortOverrides
=== CONT  TestAccAwsGlobalAcceleratorAccelerator_tags
=== CONT  TestAccAwsGlobalAcceleratorAccelerator_update
=== CONT  TestAccAwsGlobalAcceleratorEndpointGroup_Update
=== CONT  TestAccAwsGlobalAcceleratorEndpointGroup_basic
--- PASS: TestAccAwsGlobalAcceleratorAccelerator_basic (67.32s)
--- PASS: TestAccAwsGlobalAcceleratorAccelerator_attributes (88.17s)
--- PASS: TestAccAwsGlobalAcceleratorAccelerator_tags (89.25s)
--- PASS: TestAccAwsGlobalAcceleratorAccelerator_update (102.05s)
--- PASS: TestAccAwsGlobalAcceleratorListener_basic (117.95s)
--- PASS: TestAccAwsGlobalAcceleratorListener_update (156.19s)
--- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_TCPHealthCheckProtocol (159.82s)
--- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_basic (161.04s)
--- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_MultiRegion (161.87s)
--- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_disappears (166.72s)
--- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_PortOverrides (193.86s)
--- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_Update (207.41s)
--- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_InstanceEndpoint (563.90s)
--- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_ALBEndpoint_ClientIP (864.93s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	866.606s

@breathingdust breathingdust merged commit a67c78f into hashicorp:master Jan 14, 2021
@github-actions github-actions bot added this to the v3.24.0 milestone Jan 14, 2021
breathingdust added a commit that referenced this pull request Jan 14, 2021
@breathingdust
Update CHANGELOG.md for #17112
de0c2ef
@ghost
Copy link

ghost commented Jan 15, 2021

This has been released in version 3.24.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Feb 14, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
documentation Introduces or discusses updates to documentation. service/globalaccelerator Issues and PRs that pertain to the globalaccelerator service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.24.0
Development

Successfully merging this pull request may close these issues.

aws_globalaccelerator_accelerator timeout longer then 10 minuets
3 participants
@brent-au @breathingdust @ewbankkit