Add support for Amazon Managed Service for Prometheus

[nicolai86]

When merged, this will close #16788

[github-actions]

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

• Check open pull requests with the dependencies label to view other dependency updates.
• If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
• If this pull request is for supporting a new AWS service:
  • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
  • If this pull request is already a separate pull request from the above item, you can ignore this message.

[github-actions]

Welcome @nicolai86 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[jeromeinsf]

Amazon Managed Service for Prometheus (AMP)

[lcacciagioni]

Any updates when this can be merged?

[github-actions]

Thank you for your contribution! 🚀

Please note that the CHANGELOG.md file contents are handled by the maintainers during merge. This is to prevent pull request merge conflicts, especially for contributions which may not be merged immediately. Please see the Contributing Guide for additional pull request review items.

Remove any changes to the CHANGELOG.md file and commit them in this pull request to prevent delays with reviewing and potentially merging this pull request.

[bflad]

Hi @nicolai86 👋 Thank you for submitting this. Overall it was on the right track. Please see the below initial feedback and reach out if you have any questions. 👍

[nicolai86]

thanks for the pointers @bflad . I've pushed a new revision that introduces waiters, removes the state, and adopts a ton of your comments.

[bflad]

Looking real good. Just some polish so we can hopefully release this today 🤞

[bflad]

Looks great, thank you for this, @nicolai86 🚀

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSAMPWorkspace_disappears (12.45s)
--- PASS: TestAccAWSAMPWorkspace_basic (33.77s)

Output from acceptance testing in AWS GovCloud (US):

=== CONT  TestAccAWSAMPWorkspace_disappears
    resource_aws_prometheus_workspace_test.go:54: Step 1/1 error: Error running apply:
        Error: error creating Prometheus WorkSpace (): RequestError: send request failed
        caused by: Post "https://aps.us-gov-west-1.amazonaws.com/workspaces": dial tcp: lookup aps.us-gov-west-1.amazonaws.com: no such host


--- FAIL: TestAccAWSAMPWorkspace_disappears (29.51s)
=== CONT  TestAccAWSAMPWorkspace_basic
    resource_aws_prometheus_workspace_test.go:18: Step 1/4 error: Error running apply:
        Error: error creating Prometheus WorkSpace (): RequestError: send request failed
        caused by: Post "https://aps.us-gov-west-1.amazonaws.com/workspaces": dial tcp: lookup aps.us-gov-west-1.amazonaws.com: no such host


--- FAIL: TestAccAWSAMPWorkspace_basic (33.28s)

Which is expected because the service does not exist in those regions. Will create a followup issue to add custom PreCheck since the service is also not published in the AWS Go SDK endpoints.

[ghost]

This has been released in version 3.26.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!