Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws_ami: gp3 volume scalable throughtput #16631

Merged
merged 8 commits into from
Jan 19, 2021
Merged

aws_ami: gp3 volume scalable throughtput #16631

merged 8 commits into from
Jan 19, 2021

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Dec 7, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #16514.

Release note for CHANGELOG:

resource/aws_ami: Support `volume_type` value of `gp3`. Add `throughput` attribute to `ebs_block_device` configuration.
data-source/aws_ami: Add `throughput` value to `block_device_mappings.ebs` mapping.
resource/aws_ami_copy: Add `throughput` attribute to `ebs_block_device` configuration.
resource/aws_ami_from_instance: Add `throughput` attribute to `ebs_block_device` configuration.

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAMI_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAMI_ -timeout 120m
=== RUN   TestAccAWSAMI_basic
=== PAUSE TestAccAWSAMI_basic
=== RUN   TestAccAWSAMI_description
=== PAUSE TestAccAWSAMI_description
=== RUN   TestAccAWSAMI_disappears
=== PAUSE TestAccAWSAMI_disappears
=== RUN   TestAccAWSAMI_EphemeralBlockDevices
=== PAUSE TestAccAWSAMI_EphemeralBlockDevices
=== RUN   TestAccAWSAMI_Gp3BlockDevice
=== PAUSE TestAccAWSAMI_Gp3BlockDevice
=== RUN   TestAccAWSAMI_tags
=== PAUSE TestAccAWSAMI_tags
=== CONT  TestAccAWSAMI_description
=== CONT  TestAccAWSAMI_basic
=== CONT  TestAccAWSAMI_Gp3BlockDevice
=== CONT  TestAccAWSAMI_tags
=== CONT  TestAccAWSAMI_EphemeralBlockDevices
=== CONT  TestAccAWSAMI_disappears
--- PASS: TestAccAWSAMI_description (57.76s)
--- PASS: TestAccAWSAMI_disappears (61.16s)
--- PASS: TestAccAWSAMI_EphemeralBlockDevices (64.17s)
--- PASS: TestAccAWSAMI_basic (64.66s)
--- PASS: TestAccAWSAMI_Gp3BlockDevice (65.80s)
--- PASS: TestAccAWSAMI_tags (86.83s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	86.928s
$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAmiDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAmiDataSource_ -timeout 120m
=== RUN   TestAccAWSAmiDataSource_natInstance
=== PAUSE TestAccAWSAmiDataSource_natInstance
=== RUN   TestAccAWSAmiDataSource_windowsInstance
=== PAUSE TestAccAWSAmiDataSource_windowsInstance
=== RUN   TestAccAWSAmiDataSource_instanceStore
=== PAUSE TestAccAWSAmiDataSource_instanceStore
=== RUN   TestAccAWSAmiDataSource_localNameFilter
=== PAUSE TestAccAWSAmiDataSource_localNameFilter
=== RUN   TestAccAWSAmiDataSource_Gp3BlockDevice
=== PAUSE TestAccAWSAmiDataSource_Gp3BlockDevice
=== CONT  TestAccAWSAmiDataSource_natInstance
=== CONT  TestAccAWSAmiDataSource_localNameFilter
=== CONT  TestAccAWSAmiDataSource_Gp3BlockDevice
=== CONT  TestAccAWSAmiDataSource_instanceStore
=== CONT  TestAccAWSAmiDataSource_windowsInstance
--- PASS: TestAccAWSAmiDataSource_natInstance (16.66s)
--- PASS: TestAccAWSAmiDataSource_instanceStore (16.93s)
--- PASS: TestAccAWSAmiDataSource_windowsInstance (17.75s)
--- PASS: TestAccAWSAmiDataSource_localNameFilter (18.27s)
--- PASS: TestAccAWSAmiDataSource_Gp3BlockDevice (56.17s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	56.257s
$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAMICopy_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAMICopy_ -timeout 120m
=== RUN   TestAccAWSAMICopy_basic
=== PAUSE TestAccAWSAMICopy_basic
=== RUN   TestAccAWSAMICopy_Description
=== PAUSE TestAccAWSAMICopy_Description
=== RUN   TestAccAWSAMICopy_EnaSupport
=== PAUSE TestAccAWSAMICopy_EnaSupport
=== RUN   TestAccAWSAMICopy_tags
=== PAUSE TestAccAWSAMICopy_tags
=== CONT  TestAccAWSAMICopy_basic
=== CONT  TestAccAWSAMICopy_tags
=== CONT  TestAccAWSAMICopy_EnaSupport
=== CONT  TestAccAWSAMICopy_Description
--- PASS: TestAccAWSAMICopy_EnaSupport (385.38s)
--- PASS: TestAccAWSAMICopy_basic (386.46s)
--- PASS: TestAccAWSAMICopy_Description (397.85s)
--- PASS: TestAccAWSAMICopy_tags (411.06s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	411.151s
$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAMIFromInstance_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAMIFromInstance_ -timeout 120m
=== RUN   TestAccAWSAMIFromInstance_basic
=== PAUSE TestAccAWSAMIFromInstance_basic
=== RUN   TestAccAWSAMIFromInstance_tags
=== PAUSE TestAccAWSAMIFromInstance_tags
=== CONT  TestAccAWSAMIFromInstance_basic
=== CONT  TestAccAWSAMIFromInstance_tags
--- PASS: TestAccAWSAMIFromInstance_basic (243.32s)
--- PASS: TestAccAWSAMIFromInstance_tags (302.97s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	303.062s

@ewbankkit ewbankkit requested a review from a team as a code owner December 7, 2020 17:18
@ghost ghost added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. labels Dec 7, 2020
@ewbankkit ewbankkit mentioned this pull request Dec 7, 2020
Closed
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed size/L Managed by automation to categorize the size of a PR. labels Dec 7, 2020
@ewbankkit ewbankkit changed the title [WIP] aws_ami: gp3 volume scalable throughtput aws_ami: gp3 volume scalable throughtput Dec 7, 2020
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Dec 17, 2020
@bflad bflad self-assigned this Dec 17, 2020
bflad
bflad suggested changes Dec 17, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this is not easy to know right now, but the aws_ami_copy and aws_ami_from_instance resources also require updates when adjusting this:

=== CONT  TestAccAWSAMIFromInstance_basic
------- Stderr: -------
panic: Invalid address to set: []string{"ebs_block_device", "0", "throughput"}
goroutine 447 [running]:
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*ResourceData).Set(0xc001c22c00, 0x77540f5, 0x10, 0x60b8ce0, 0xc001c73200, 0x1, 0x0)
  /opt/teamcity-agent/work/2e10e023da0c7520/pkg/mod/github.com/hashicorp/terraform-plugin-sdk/[email protected]/helper/schema/resource_data.go:230 +0x36f
github.com/terraform-providers/terraform-provider-aws/aws.resourceAwsAmiRead(0xc001c22c00, 0x69f6660, 0xc000694000, 0xc0025a7b50, 0xc00064ab00)
  /opt/teamcity-agent/work/2e10e023da0c7520/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_ami.go:366 +0xd47
github.com/terraform-providers/terraform-provider-aws/aws.resourceAwsAmiFromInstanceCreate(0xc001c22c00, 0x69f6660, 0xc000694000, 0x3, 0xffffffffffffffff)
  /opt/teamcity-agent/work/2e10e023da0c7520/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_ami_from_instance.go:215 +0x425

=== CONT  TestAccAWSAMICopy_basic
------- Stderr: -------
panic: Invalid address to set: []string{"ebs_block_device", "0", "throughput"}
goroutine 627 [running]:
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*ResourceData).Set(0xc00231f980, 0x77540f5, 0x10, 0x60b8ce0, 0xc001cbcd40, 0x1, 0x0)
  /opt/teamcity-agent/work/2e10e023da0c7520/pkg/mod/github.com/hashicorp/terraform-plugin-sdk/[email protected]/helper/schema/resource_data.go:230 +0x36f
github.com/terraform-providers/terraform-provider-aws/aws.resourceAwsAmiRead(0xc00231f980, 0x69f6660, 0xc001e48680, 0xc0031af528, 0xc002d80e00)
  /opt/teamcity-agent/work/2e10e023da0c7520/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_ami.go:366 +0xd47
github.com/terraform-providers/terraform-provider-aws/aws.resourceAwsAmiCopyCreate(0xc00231f980, 0x69f6660, 0xc001e48680, 0x2, 0xffffffffffffffff)
  /opt/teamcity-agent/work/2e10e023da0c7520/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_ami_copy.go:233 +0x4e7

Hopefully early next year we will have some tooling to help with this, even for running acceptance tests locally.

@bflad bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Dec 17, 2020
@ewbankkit
r/aws_ami: Add 'throughput' attribute to 'ebs_block_device' block.
221275d 
Acceptance test output:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAMI_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAMI_ -timeout 120m
=== RUN   TestAccAWSAMI_basic
=== PAUSE TestAccAWSAMI_basic
=== RUN   TestAccAWSAMI_description
=== PAUSE TestAccAWSAMI_description
=== RUN   TestAccAWSAMI_disappears
=== PAUSE TestAccAWSAMI_disappears
=== RUN   TestAccAWSAMI_tags
=== PAUSE TestAccAWSAMI_tags
=== RUN   TestAccAWSAMI_snapshotSize
=== PAUSE TestAccAWSAMI_snapshotSize
=== CONT  TestAccAWSAMI_basic
=== CONT  TestAccAWSAMI_tags
=== CONT  TestAccAWSAMI_snapshotSize
=== CONT  TestAccAWSAMI_disappears
=== CONT  TestAccAWSAMI_description
--- PASS: TestAccAWSAMI_basic (44.48s)
--- PASS: TestAccAWSAMI_disappears (57.89s)
--- PASS: TestAccAWSAMI_snapshotSize (63.02s)
--- PASS: TestAccAWSAMI_description (75.15s)
--- PASS: TestAccAWSAMI_tags (87.46s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	87.563s
@ewbankkit
r/aws_ami: Simplify existing test configurations.
f218169 
Acceptance test output:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAMI_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAMI_ -timeout 120m
=== RUN   TestAccAWSAMI_basic
=== PAUSE TestAccAWSAMI_basic
=== RUN   TestAccAWSAMI_description
=== PAUSE TestAccAWSAMI_description
=== RUN   TestAccAWSAMI_disappears
=== PAUSE TestAccAWSAMI_disappears
=== RUN   TestAccAWSAMI_tags
=== PAUSE TestAccAWSAMI_tags
=== CONT  TestAccAWSAMI_basic
=== CONT  TestAccAWSAMI_tags
=== CONT  TestAccAWSAMI_disappears
=== CONT  TestAccAWSAMI_description
--- PASS: TestAccAWSAMI_disappears (57.44s)
--- PASS: TestAccAWSAMI_description (71.50s)
--- PASS: TestAccAWSAMI_basic (74.41s)
--- PASS: TestAccAWSAMI_tags (98.56s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	98.647s
@ewbankkit
r/aws_ami: Add 'TestAccAWSAMI_EphemeralBlockDevices'.
493a1f5 
Acceptance test output:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAMI_EphemeralBlockDevices'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAMI_EphemeralBlockDevices -timeout 120m
=== RUN   TestAccAWSAMI_EphemeralBlockDevices
=== PAUSE TestAccAWSAMI_EphemeralBlockDevices
=== CONT  TestAccAWSAMI_EphemeralBlockDevices
--- PASS: TestAccAWSAMI_EphemeralBlockDevices (55.38s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	55.476s
@ewbankkit
r/aws_ami: Add 'TestAccAWSAMI_Gp3BlockDevice'.
bc96842 
Acceptance test output:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAMI_Gp3BlockDevice'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAMI_Gp3BlockDevice -timeout 120m
=== RUN   TestAccAWSAMI_Gp3BlockDevice
=== PAUSE TestAccAWSAMI_Gp3BlockDevice
=== CONT  TestAccAWSAMI_Gp3BlockDevice
--- PASS: TestAccAWSAMI_Gp3BlockDevice (56.18s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	56.262s
@ewbankkit
d/aws_ami: Add 'throughput' value to 'block_device_mappings.ebs' mapp…
d3f796b 
…ing.

Acceptance test output:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAmiDataSource_Gp3BlockDevice'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAmiDataSource_Gp3BlockDevice -timeout 120m
=== RUN   TestAccAWSAmiDataSource_Gp3BlockDevice
=== PAUSE TestAccAWSAmiDataSource_Gp3BlockDevice
=== CONT  TestAccAWSAmiDataSource_Gp3BlockDevice
--- PASS: TestAccAWSAmiDataSource_Gp3BlockDevice (39.62s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	39.694s
@ewbankkit
r/aws_ami_copy: Add 'throughput' attribute to 'ebs_block_device' block.
341590c 
Acceptance test output:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAMICopy_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAMICopy_ -timeout 120m
=== RUN   TestAccAWSAMICopy_basic
=== PAUSE TestAccAWSAMICopy_basic
=== RUN   TestAccAWSAMICopy_Description
=== PAUSE TestAccAWSAMICopy_Description
=== RUN   TestAccAWSAMICopy_EnaSupport
=== PAUSE TestAccAWSAMICopy_EnaSupport
=== RUN   TestAccAWSAMICopy_tags
=== PAUSE TestAccAWSAMICopy_tags
=== CONT  TestAccAWSAMICopy_basic
=== CONT  TestAccAWSAMICopy_tags
=== CONT  TestAccAWSAMICopy_EnaSupport
=== CONT  TestAccAWSAMICopy_Description
--- PASS: TestAccAWSAMICopy_EnaSupport (385.38s)
--- PASS: TestAccAWSAMICopy_basic (386.46s)
--- PASS: TestAccAWSAMICopy_Description (397.85s)
--- PASS: TestAccAWSAMICopy_tags (411.06s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	411.151s
@ewbankkit
r/aws_ami_from_instance: Add 'throughput' attribute to 'ebs_block_dev…
c13e09b 
…ice' block.

Acceptance test output:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAMIFromInstance_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAMIFromInstance_ -timeout 120m
=== RUN   TestAccAWSAMIFromInstance_basic
=== PAUSE TestAccAWSAMIFromInstance_basic
=== RUN   TestAccAWSAMIFromInstance_tags
=== PAUSE TestAccAWSAMIFromInstance_tags
=== CONT  TestAccAWSAMIFromInstance_basic
=== CONT  TestAccAWSAMIFromInstance_tags
--- PASS: TestAccAWSAMIFromInstance_basic (243.32s)
--- PASS: TestAccAWSAMIFromInstance_tags (302.97s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	303.062s
@ewbankkit ewbankkit requested a review from bflad December 17, 2020 13:23
@ewbankkit ewbankkit removed the waiting-response Maintainers are waiting on response from community or contributor. label Jan 4, 2021
@ewbankkit
resource/aws_ami*: Follow Data Handling and Conversion guidelines for…
dcaeb89 
… 'expand' and 'flatten' functions.

Acceptance test output:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAMI_\|TestAccAWSAmiDataSource_\|TestAccAWSAMICopy_\|TestAccAWSAMIFromInstance_' ACCTEST_PARALLELISM=4
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 4 -run=TestAccAWSAMI_\|TestAccAWSAmiDataSource_\|TestAccAWSAMICopy_\|TestAccAWSAMIFromInstance_ -timeout 120m
=== RUN   TestAccAWSAmiDataSource_natInstance
=== PAUSE TestAccAWSAmiDataSource_natInstance
=== RUN   TestAccAWSAmiDataSource_windowsInstance
=== PAUSE TestAccAWSAmiDataSource_windowsInstance
=== RUN   TestAccAWSAmiDataSource_instanceStore
=== PAUSE TestAccAWSAmiDataSource_instanceStore
=== RUN   TestAccAWSAmiDataSource_localNameFilter
=== PAUSE TestAccAWSAmiDataSource_localNameFilter
=== RUN   TestAccAWSAmiDataSource_Gp3BlockDevice
=== PAUSE TestAccAWSAmiDataSource_Gp3BlockDevice
=== RUN   TestAccAWSAMICopy_basic
=== PAUSE TestAccAWSAMICopy_basic
=== RUN   TestAccAWSAMICopy_Description
=== PAUSE TestAccAWSAMICopy_Description
=== RUN   TestAccAWSAMICopy_EnaSupport
=== PAUSE TestAccAWSAMICopy_EnaSupport
=== RUN   TestAccAWSAMICopy_tags
=== PAUSE TestAccAWSAMICopy_tags
=== RUN   TestAccAWSAMIFromInstance_basic
=== PAUSE TestAccAWSAMIFromInstance_basic
=== RUN   TestAccAWSAMIFromInstance_tags
=== PAUSE TestAccAWSAMIFromInstance_tags
=== RUN   TestAccAWSAMI_basic
=== PAUSE TestAccAWSAMI_basic
=== RUN   TestAccAWSAMI_description
=== PAUSE TestAccAWSAMI_description
=== RUN   TestAccAWSAMI_disappears
=== PAUSE TestAccAWSAMI_disappears
=== RUN   TestAccAWSAMI_EphemeralBlockDevices
=== PAUSE TestAccAWSAMI_EphemeralBlockDevices
=== RUN   TestAccAWSAMI_Gp3BlockDevice
=== PAUSE TestAccAWSAMI_Gp3BlockDevice
=== RUN   TestAccAWSAMI_tags
=== PAUSE TestAccAWSAMI_tags
=== CONT  TestAccAWSAmiDataSource_natInstance
=== CONT  TestAccAWSAMI_tags
=== CONT  TestAccAWSAMI_Gp3BlockDevice
=== CONT  TestAccAWSAMI_EphemeralBlockDevices
--- PASS: TestAccAWSAmiDataSource_natInstance (14.28s)
=== CONT  TestAccAWSAMI_disappears
--- PASS: TestAccAWSAMI_disappears (39.57s)
=== CONT  TestAccAWSAMI_description
--- PASS: TestAccAWSAMI_Gp3BlockDevice (61.35s)
=== CONT  TestAccAWSAMI_basic
--- PASS: TestAccAWSAMI_EphemeralBlockDevices (61.73s)
=== CONT  TestAccAWSAMIFromInstance_tags
--- PASS: TestAccAWSAMI_tags (86.70s)
=== CONT  TestAccAWSAMICopy_basic
--- PASS: TestAccAWSAMI_basic (56.36s)
=== CONT  TestAccAWSAMIFromInstance_basic
--- PASS: TestAccAWSAMI_description (69.73s)
=== CONT  TestAccAWSAMICopy_tags
=== CONT  TestAccAWSAMICopy_EnaSupport
--- PASS: TestAccAWSAMIFromInstance_basic (212.82s)
--- PASS: TestAccAWSAMIFromInstance_tags (285.49s)
=== CONT  TestAccAWSAMICopy_Description
=== CONT  TestAccAWSAmiDataSource_localNameFilter
--- PASS: TestAccAWSAMICopy_basic (370.81s)
--- PASS: TestAccAWSAmiDataSource_localNameFilter (13.49s)
=== CONT  TestAccAWSAmiDataSource_Gp3BlockDevice
--- PASS: TestAccAWSAmiDataSource_Gp3BlockDevice (41.36s)
=== CONT  TestAccAWSAmiDataSource_instanceStore
--- PASS: TestAccAWSAMICopy_tags (398.78s)
=== CONT  TestAccAWSAmiDataSource_windowsInstance
--- PASS: TestAccAWSAmiDataSource_instanceStore (11.85s)
--- PASS: TestAccAWSAmiDataSource_windowsInstance (12.87s)
--- PASS: TestAccAWSAMICopy_Description (384.37s)
--- PASS: TestAccAWSAMICopy_EnaSupport (438.88s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	769.512s
@ewbankkit
Copy link
Contributor Author

Acceptance test output:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAMI_\|TestAccAWSAmiDataSource_\|TestAccAWSAMICopy_\|TestAccAWSAMIFromInstance_' ACCTEST_PARALLELISM=4
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 4 -run=TestAccAWSAMI_\|TestAccAWSAmiDataSource_\|TestAccAWSAMICopy_\|TestAccAWSAMIFromInstance_ -timeout 120m
=== RUN   TestAccAWSAmiDataSource_natInstance
=== PAUSE TestAccAWSAmiDataSource_natInstance
=== RUN   TestAccAWSAmiDataSource_windowsInstance
=== PAUSE TestAccAWSAmiDataSource_windowsInstance
=== RUN   TestAccAWSAmiDataSource_instanceStore
=== PAUSE TestAccAWSAmiDataSource_instanceStore
=== RUN   TestAccAWSAmiDataSource_localNameFilter
=== PAUSE TestAccAWSAmiDataSource_localNameFilter
=== RUN   TestAccAWSAmiDataSource_Gp3BlockDevice
=== PAUSE TestAccAWSAmiDataSource_Gp3BlockDevice
=== RUN   TestAccAWSAMICopy_basic
=== PAUSE TestAccAWSAMICopy_basic
=== RUN   TestAccAWSAMICopy_Description
=== PAUSE TestAccAWSAMICopy_Description
=== RUN   TestAccAWSAMICopy_EnaSupport
=== PAUSE TestAccAWSAMICopy_EnaSupport
=== RUN   TestAccAWSAMICopy_tags
=== PAUSE TestAccAWSAMICopy_tags
=== RUN   TestAccAWSAMIFromInstance_basic
=== PAUSE TestAccAWSAMIFromInstance_basic
=== RUN   TestAccAWSAMIFromInstance_tags
=== PAUSE TestAccAWSAMIFromInstance_tags
=== RUN   TestAccAWSAMI_basic
=== PAUSE TestAccAWSAMI_basic
=== RUN   TestAccAWSAMI_description
=== PAUSE TestAccAWSAMI_description
=== RUN   TestAccAWSAMI_disappears
=== PAUSE TestAccAWSAMI_disappears
=== RUN   TestAccAWSAMI_EphemeralBlockDevices
=== PAUSE TestAccAWSAMI_EphemeralBlockDevices
=== RUN   TestAccAWSAMI_Gp3BlockDevice
=== PAUSE TestAccAWSAMI_Gp3BlockDevice
=== RUN   TestAccAWSAMI_tags
=== PAUSE TestAccAWSAMI_tags
=== CONT  TestAccAWSAmiDataSource_natInstance
=== CONT  TestAccAWSAMI_tags
=== CONT  TestAccAWSAMI_Gp3BlockDevice
=== CONT  TestAccAWSAMI_EphemeralBlockDevices
--- PASS: TestAccAWSAmiDataSource_natInstance (14.28s)
=== CONT  TestAccAWSAMI_disappears
--- PASS: TestAccAWSAMI_disappears (39.57s)
=== CONT  TestAccAWSAMI_description
--- PASS: TestAccAWSAMI_Gp3BlockDevice (61.35s)
=== CONT  TestAccAWSAMI_basic
--- PASS: TestAccAWSAMI_EphemeralBlockDevices (61.73s)
=== CONT  TestAccAWSAMIFromInstance_tags
--- PASS: TestAccAWSAMI_tags (86.70s)
=== CONT  TestAccAWSAMICopy_basic
--- PASS: TestAccAWSAMI_basic (56.36s)
=== CONT  TestAccAWSAMIFromInstance_basic
--- PASS: TestAccAWSAMI_description (69.73s)
=== CONT  TestAccAWSAMICopy_tags
=== CONT  TestAccAWSAMICopy_EnaSupport
--- PASS: TestAccAWSAMIFromInstance_basic (212.82s)
--- PASS: TestAccAWSAMIFromInstance_tags (285.49s)
=== CONT  TestAccAWSAMICopy_Description
=== CONT  TestAccAWSAmiDataSource_localNameFilter
--- PASS: TestAccAWSAMICopy_basic (370.81s)
--- PASS: TestAccAWSAmiDataSource_localNameFilter (13.49s)
=== CONT  TestAccAWSAmiDataSource_Gp3BlockDevice
--- PASS: TestAccAWSAmiDataSource_Gp3BlockDevice (41.36s)
=== CONT  TestAccAWSAmiDataSource_instanceStore
--- PASS: TestAccAWSAMICopy_tags (398.78s)
=== CONT  TestAccAWSAmiDataSource_windowsInstance
--- PASS: TestAccAWSAmiDataSource_instanceStore (11.85s)
--- PASS: TestAccAWSAmiDataSource_windowsInstance (12.87s)
--- PASS: TestAccAWSAMICopy_Description (384.37s)
--- PASS: TestAccAWSAMICopy_EnaSupport (438.88s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	769.512s

bflad
bflad approved these changes Jan 15, 2021
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀 (Won't merge immediately as we are in a temporary code freeze until the aws_instance regression and #16215 are sorted)

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSAMI_basic (64.21s)
--- PASS: TestAccAWSAMI_description (76.85s)
--- PASS: TestAccAWSAMI_disappears (60.98s)
--- PASS: TestAccAWSAMI_EphemeralBlockDevices (64.91s)
--- PASS: TestAccAWSAMI_Gp3BlockDevice (48.76s)
--- PASS: TestAccAWSAMI_tags (73.71s)

--- PASS: TestAccAWSAMICopy_basic (378.01s)
--- PASS: TestAccAWSAMICopy_Description (391.97s)
--- PASS: TestAccAWSAMICopy_EnaSupport (377.97s)
--- PASS: TestAccAWSAMICopy_tags (404.08s)

--- PASS: TestAccAWSAmiDataSource_Gp3BlockDevice (48.44s)
--- PASS: TestAccAWSAmiDataSource_instanceStore (27.12s)
--- PASS: TestAccAWSAmiDataSource_localNameFilter (30.76s)
--- PASS: TestAccAWSAmiDataSource_natInstance (26.80s)
--- PASS: TestAccAWSAmiDataSource_windowsInstance (28.30s)

--- PASS: TestAccAWSAMIFromInstance_basic (444.76s)
--- PASS: TestAccAWSAMIFromInstance_tags (294.34s)

--- PASS: TestAccAWSAMILaunchPermission_basic (344.81s)
--- PASS: TestAccAWSAMILaunchPermission_Disappears_AMI (359.20s)
--- PASS: TestAccAWSAMILaunchPermission_Disappears_LaunchPermission (336.46s)
--- PASS: TestAccAWSAMILaunchPermission_Disappears_LaunchPermission_Public (348.74s)

Output from acceptance testing in AWS GovCloud (US):

--- PASS: TestAccAWSAMI_basic (68.61s)
--- PASS: TestAccAWSAMI_description (76.31s)
--- PASS: TestAccAWSAMI_disappears (65.32s)
--- PASS: TestAccAWSAMI_EphemeralBlockDevices (69.63s)
--- PASS: TestAccAWSAMI_Gp3BlockDevice (67.43s)
--- PASS: TestAccAWSAMI_tags (99.68s)

--- PASS: TestAccAWSAMICopy_basic (391.97s)
--- PASS: TestAccAWSAMICopy_Description (409.20s)
--- PASS: TestAccAWSAMICopy_EnaSupport (392.72s)
--- PASS: TestAccAWSAMICopy_tags (413.77s)

--- PASS: TestAccAWSAmiDataSource_Gp3BlockDevice (67.39s)
--- PASS: TestAccAWSAmiDataSource_instanceStore (27.26s)
--- PASS: TestAccAWSAmiDataSource_localNameFilter (30.92s)
--- PASS: TestAccAWSAmiDataSource_natInstance (27.50s)
--- PASS: TestAccAWSAmiDataSource_windowsInstance (27.77s)

--- PASS: TestAccAWSAMIFromInstance_basic (255.31s)
--- PASS: TestAccAWSAMIFromInstance_tags (359.49s)

--- PASS: TestAccAWSAMILaunchPermission_basic (356.36s)
--- PASS: TestAccAWSAMILaunchPermission_Disappears_AMI (371.79s)
--- PASS: TestAccAWSAMILaunchPermission_Disappears_LaunchPermission (354.32s)
--- PASS: TestAccAWSAMILaunchPermission_Disappears_LaunchPermission_Public (353.67s)

@bflad bflad added this to the v3.25.0 milestone Jan 19, 2021
@bflad bflad merged commit 59d3866 into hashicorp:master Jan 19, 2021
bflad added a commit that referenced this pull request Jan 19, 2021
@bflad
Update CHANGELOG for #16631
79fe9fa
@ewbankkit ewbankkit deleted the f-aws_ami-gp3-throughput branch January 19, 2021 13:17
@ghost
Copy link

ghost commented Jan 22, 2021

This has been released in version 3.25.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Feb 18, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.25.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ewbankkit @bflad