Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resources & Data Sources: ElastiCache Redis - User #16629

Merged
merged 5 commits into from
Jul 21, 2021
Merged

New Resources & Data Sources: ElastiCache Redis - User #16629

merged 5 commits into from
Jul 21, 2021

Conversation

drarnold
Copy link

@drarnold drarnold commented Dec 7, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates to #16327
Blocks #16504

Release note for CHANGELOG:

resource/aws_elasticache_user: add elasticache_user resource [GH-16629]

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSElasticacheUser_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSElasticacheUser_ -timeout 120m
=== RUN   TestAccAWSElasticacheUser_basic
=== PAUSE TestAccAWSElasticacheUser_basic
=== RUN   TestAccAWSElasticacheUser_updateAccessString
=== PAUSE TestAccAWSElasticacheUser_updateAccessString
=== RUN   TestAccAWSElasticacheUser_addPasswords
=== PAUSE TestAccAWSElasticacheUser_addPasswords
=== RUN   TestAccAWSElasticacheUser_removePasswords
=== PAUSE TestAccAWSElasticacheUser_removePasswords
=== CONT  TestAccAWSElasticacheUser_basic
=== CONT  TestAccAWSElasticacheUser_removePasswords
=== CONT  TestAccAWSElasticacheUser_addPasswords
=== CONT  TestAccAWSElasticacheUser_updateAccessString
--- PASS: TestAccAWSElasticacheUser_basic (35.69s)
--- PASS: TestAccAWSElasticacheUser_addPasswords (99.15s)
--- PASS: TestAccAWSElasticacheUser_updateAccessString (99.19s)
--- PASS: TestAccAWSElasticacheUser_removePasswords (99.19s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	101.319s

@drarnold drarnold requested a review from a team as a code owner December 7, 2020 16:38
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/elasticache Issues and PRs that pertain to the elasticache service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 7, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Dec 7, 2020
@drarnold
Copy link
Author

Still need to add a lot of functionality, but the foundation is there now from a testability perspecitve.

@drarnold drarnold changed the title WIP: New Resource: ElastiCache Redis - User New Resource: ElastiCache Redis - User Dec 12, 2020
@drarnold
Copy link
Author

I feel that this is ready for review. Please let me know if there is anything else we might need to go over. Thank you!

@drarnold drarnold changed the title New Resource: ElastiCache Redis - User New Resources & Data Sources: ElastiCache Redis - User Dec 20, 2020
Base automatically changed from master to main January 23, 2021 00:59
@boxrick
Copy link

boxrick commented Apr 1, 2021

Any movement with this?

@edbighead
Copy link

patiently waiting

@boxrick
Copy link

boxrick commented Apr 15, 2021

I've ended up hacking my own Cloudformation / CLI hack in the meanwhile. It's sadly meant we used a bunch of workarounds.

If this needs some more tests or merge conflicts fixing to get it out, im happy to help.

@stevehipwell
Copy link

Any progress on this?

@OmarSalka
Copy link

@hashicorp/terraform-aws

@stevehipwell
Copy link

Could a maintainer rebase this?

@drarnold
Copy link
Author

Sorry for the radio silence with this project. I will start working on it again during the evenings and should try to get something out shortly.

Copy link
Contributor

@bill-rich bill-rich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSElasticacheUser_ -timeout 180m
=== RUN   TestAccAWSElasticacheUser_basic
=== PAUSE TestAccAWSElasticacheUser_basic
=== RUN   TestAccAWSElasticacheUser_tags
=== PAUSE TestAccAWSElasticacheUser_tags
=== RUN   TestAccAWSElasticacheUser_disappears
=== PAUSE TestAccAWSElasticacheUser_disappears
=== CONT  TestAccAWSElasticacheUser_basic
=== CONT  TestAccAWSElasticacheUser_disappears
=== CONT  TestAccAWSElasticacheUser_tags
--- PASS: TestAccAWSElasticacheUser_disappears (14.71s)
--- PASS: TestAccAWSElasticacheUser_basic (17.78s)
--- PASS: TestAccAWSElasticacheUser_tags (40.13s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	40.196s

@bill-rich bill-rich merged commit fd95bcd into hashicorp:main Jul 21, 2021
@github-actions github-actions bot added this to the v3.51.0 milestone Jul 21, 2021
@github-actions
Copy link

This functionality has been released in v3.51.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2021
@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/elasticache Issues and PRs that pertain to the elasticache service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants