Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

increased max retention period for kinesis stream to 8760 #16608

Merged
merged 2 commits into from
Dec 22, 2020
Merged

increased max retention period for kinesis stream to 8760 #16608

merged 2 commits into from
Dec 22, 2020

Conversation

with-joy
Copy link
Contributor

@with-joy with-joy commented Dec 5, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #16179

Release note for CHANGELOG:

resource/aws_kinesis_stream: Added support for retention period up to 8760 hours.

Output from acceptance testing:

make testacc TESTARGS='-run=TestAccAWSKinesisStream_retentionPeriod'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSKinesisStream_retentionPeriod -timeout 120m
=== RUN   TestAccAWSKinesisStream_retentionPeriod
=== PAUSE TestAccAWSKinesisStream_retentionPeriod
=== CONT  TestAccAWSKinesisStream_retentionPeriod
--- PASS: TestAccAWSKinesisStream_retentionPeriod (157.29s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       159.160s

...

@with-joy with-joy requested a review from a team as a code owner December 5, 2020 07:35
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/kinesis Issues and PRs that pertain to the kinesis service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 5, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Dec 5, 2020
@ewbankkit
Copy link
Contributor

@with-joy Thanks for the contribution.
Could you please also update the documentation in website/docs/r/kinesis_stream.html.markdown.

@ewbankkit
Copy link
Contributor

Verified acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSKinesisStream_retentionPeriod'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSKinesisStream_retentionPeriod -timeout 120m
=== RUN   TestAccAWSKinesisStream_retentionPeriod
=== PAUSE TestAccAWSKinesisStream_retentionPeriod
=== CONT  TestAccAWSKinesisStream_retentionPeriod
--- PASS: TestAccAWSKinesisStream_retentionPeriod (96.87s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	96.975s

@ewbankkit ewbankkit added waiting-response Maintainers are waiting on response from community or contributor. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 5, 2020
@ghost ghost added the documentation Introduces or discusses updates to documentation. label Dec 7, 2020
@with-joy
Copy link
Contributor Author

with-joy commented Dec 7, 2020

@ewbankkit : ah apologies missed that. Have updated the documentation now.

@ghost ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Dec 7, 2020
ewbankkit
ewbankkit approved these changes Dec 7, 2020
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@with-joy
Copy link
Contributor Author

with-joy commented Dec 9, 2020

@ewbankkit can this be merged in?

anGie44
anGie44 approved these changes Dec 22, 2020
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for this PR @with-joy 🚀

@anGie44 anGie44 added the enhancement Requests to existing resources that expand the functionality or scope. label Dec 22, 2020
@anGie44 anGie44 added this to the v3.23.0 milestone Dec 22, 2020
@anGie44 anGie44 merged commit 4c00888 into hashicorp:master Dec 22, 2020
anGie44 added a commit that referenced this pull request Dec 22, 2020
@anGie44
Update CHANGELOG for #16608
bebe732
@anGie44 anGie44 mentioned this pull request Dec 22, 2020
Closed
@with-joy with-joy deleted the f-increased_retention_period_for_kinesis_streams branch January 6, 2021 14:11
@ghost
Copy link

ghost commented Jan 8, 2021

This has been released in version 3.23.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jan 22, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anGie44 anGie44 anGie44 approved these changes

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/kinesis Issues and PRs that pertain to the kinesis service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.23.0
Development

Successfully merging this pull request may close these issues.

provider/aws: Increased retention period for Kinesis streams
3 participants
@with-joy @ewbankkit @anGie44