add schedule_offset parameter to aws_ssm_maintenance_window

[sysamma]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

add schedule_offset parameter to aws_ssm_maintenance_window

Output from acceptance testing:

make testacc TESTARGS='-run=TestAccAWSSSMMaintenanceWindow_basic'                                                                                                 46s
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSSMMaintenanceWindow_basic -timeout 120m
=== RUN   TestAccAWSSSMMaintenanceWindow_basic
=== PAUSE TestAccAWSSSMMaintenanceWindow_basic
=== CONT  TestAccAWSSSMMaintenanceWindow_basic
--- PASS: TestAccAWSSSMMaintenanceWindow_basic (37.08s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	39.163s

...

[github-actions]

Welcome @sysamma 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[bflad]

Thank you for this, @sysamma 🚀 Pulling this in and fixing the remaining test failure:

=== CONT  TestAccAWSSSMMaintenanceWindow_ScheduleOffset
TestAccAWSSSMMaintenanceWindow_ScheduleOffset: resource_aws_ssm_maintenance_window_test.go:471: Step 1/3 error: Error running apply:
Error: error creating SSM Maintenance Window: ValidationException: An offset can't be added to the specified schedule. A schedule offset can be specified only for CRON expressions that target a specific day in a specific week of the month, such as TUE#3.
  status code: 400, request id: eb9f29ef-04a5-45a0-bbfc-a2d92943664b
--- FAIL: TestAccAWSSSMMaintenanceWindow_ScheduleOffset (20.50s)

Other resource acceptance testing:

--- PASS: TestAccAWSSSMMaintenanceWindow_basic (70.25s)
--- PASS: TestAccAWSSSMMaintenanceWindow_Cutoff (110.11s)
--- PASS: TestAccAWSSSMMaintenanceWindow_description (110.14s)
--- PASS: TestAccAWSSSMMaintenanceWindow_disappears (50.95s)
--- PASS: TestAccAWSSSMMaintenanceWindow_Duration (95.55s)
--- PASS: TestAccAWSSSMMaintenanceWindow_Enabled (77.48s)
--- PASS: TestAccAWSSSMMaintenanceWindow_EndDate (85.32s)
--- PASS: TestAccAWSSSMMaintenanceWindow_multipleUpdates (103.51s)
--- PASS: TestAccAWSSSMMaintenanceWindow_Schedule (66.02s)
--- PASS: TestAccAWSSSMMaintenanceWindow_ScheduleTimezone (74.36s)
--- PASS: TestAccAWSSSMMaintenanceWindow_StartDate (69.76s)
--- PASS: TestAccAWSSSMMaintenanceWindow_tags (126.19s)

[ghost]

This has been released in version 3.21.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!