r/glue_registry - new resource

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #16342
Release note for CHANGELOG:

resource_aws_glue_registry - add new resource

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSGlueRegistry_'
--- PASS: TestAccAWSGlueRegistry_disappears (29.99s)
--- PASS: TestAccAWSGlueRegistry_basic (41.39s)
--- PASS: TestAccAWSGlueRegistry_Description (72.98s)
--- PASS: TestAccAWSGlueRegistry_tags (103.72s)

[ewbankkit]

Nit. My understanding is that Create and Parse ID functions are meant to work on strings only, so this functionality can just be moved into finder.RegistryByID.

[ewbankkit]

LGTM.

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSGlueRegistry_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGlueRegistry_ -timeout 120m
=== RUN   TestAccAWSGlueRegistry_basic
=== PAUSE TestAccAWSGlueRegistry_basic
=== RUN   TestAccAWSGlueRegistry_Description
=== PAUSE TestAccAWSGlueRegistry_Description
=== RUN   TestAccAWSGlueRegistry_tags
=== PAUSE TestAccAWSGlueRegistry_tags
=== RUN   TestAccAWSGlueRegistry_disappears
=== PAUSE TestAccAWSGlueRegistry_disappears
=== CONT  TestAccAWSGlueRegistry_basic
=== CONT  TestAccAWSGlueRegistry_disappears
=== CONT  TestAccAWSGlueRegistry_tags
=== CONT  TestAccAWSGlueRegistry_Description
--- PASS: TestAccAWSGlueRegistry_disappears (13.39s)
--- PASS: TestAccAWSGlueRegistry_basic (19.79s)
--- PASS: TestAccAWSGlueRegistry_Description (32.31s)
--- PASS: TestAccAWSGlueRegistry_tags (43.51s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	43.579s

[breathingdust]

LGTM 🚀 Thanks @DrFaust92

Verified Acceptance Tests in Commercial (us-west-2).

make testacc TEST=./aws TESTARGS='-run=TestAccAWSGlueRegistry_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGlueRegistry_ -timeout 120m
=== RUN   TestAccAWSGlueRegistry_basic
=== PAUSE TestAccAWSGlueRegistry_basic
=== RUN   TestAccAWSGlueRegistry_Description
=== PAUSE TestAccAWSGlueRegistry_Description
=== RUN   TestAccAWSGlueRegistry_tags
=== PAUSE TestAccAWSGlueRegistry_tags
=== RUN   TestAccAWSGlueRegistry_disappears
=== PAUSE TestAccAWSGlueRegistry_disappears
=== CONT  TestAccAWSGlueRegistry_basic
=== CONT  TestAccAWSGlueRegistry_disappears
=== CONT  TestAccAWSGlueRegistry_tags
=== CONT  TestAccAWSGlueRegistry_Description
--- PASS: TestAccAWSGlueRegistry_disappears (11.29s)
--- PASS: TestAccAWSGlueRegistry_basic (15.10s)
--- PASS: TestAccAWSGlueRegistry_Description (25.43s)
--- PASS: TestAccAWSGlueRegistry_tags (35.70s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	37.355s

Verified Acceptance Tests in GovCloud (us-gov-west-1) (Registries appear not to be supported in GovCloud)

make testacc TEST=./aws TESTARGS='-run=TestAccAWSGlueRegistry_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGlueRegistry_ -timeout 120m
=== RUN   TestAccAWSGlueRegistry_basic
=== PAUSE TestAccAWSGlueRegistry_basic
=== RUN   TestAccAWSGlueRegistry_Description
=== PAUSE TestAccAWSGlueRegistry_Description
=== RUN   TestAccAWSGlueRegistry_tags
=== PAUSE TestAccAWSGlueRegistry_tags
=== RUN   TestAccAWSGlueRegistry_disappears
=== PAUSE TestAccAWSGlueRegistry_disappears
=== CONT  TestAccAWSGlueRegistry_basic
=== CONT  TestAccAWSGlueRegistry_disappears
=== CONT  TestAccAWSGlueRegistry_Description
=== CONT  TestAccAWSGlueRegistry_tags
=== CONT  TestAccAWSGlueRegistry_disappears
    resource_aws_glue_registry_test.go:191: skipping acceptance testing: AccessDeniedException: Operation not allowed
--- SKIP: TestAccAWSGlueRegistry_disappears (0.99s)
=== CONT  TestAccAWSGlueRegistry_tags
    resource_aws_glue_registry_test.go:191: skipping acceptance testing: AccessDeniedException: Operation not allowed
--- SKIP: TestAccAWSGlueRegistry_tags (0.99s)
=== CONT  TestAccAWSGlueRegistry_basic
    resource_aws_glue_registry_test.go:191: skipping acceptance testing: AccessDeniedException: Operation not allowed
--- SKIP: TestAccAWSGlueRegistry_basic (1.00s)
=== CONT  TestAccAWSGlueRegistry_Description
    resource_aws_glue_registry_test.go:191: skipping acceptance testing: AccessDeniedException: Operation not allowed
--- SKIP: TestAccAWSGlueRegistry_Description (1.01s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	2.595s

[ghost]

This has been released in version 3.19.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!