service/networkfirewall: Investigate Tags Field in Describe API Calls

[bflad]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The general availability release of the Network Firewall APIs includes a Tags field in the following API calls:

• DescribeFirewall
• DescribeFirewallPolicy
• DescribeRuleGroup

This may allow us to remove the extra ListTagsForResource calls in the resources that support resource tagging.

Affected Resource(s)

• aws_networkfirewall_firewall
• aws_networkfirewall_firewall_policy
• aws_networkfirewall_rule_group

Potential Terraform Code

// Replace

tags, err := keyvaluetags.NetworkfirewallListTags(conn, arn)
if err != nil {
	return diag.FromErr(fmt.Errorf("error listing tags for NetworkFirewall Firewall (%s): %w", arn, err))
}

if err := d.Set("tags", tags.IgnoreAws().IgnoreConfig(ignoreTagsConfig).Map()); err != nil {
	return diag.FromErr(fmt.Errorf("error setting tags: %w", err))
}

// With

if err := d.Set("tags", keyvaluetags.NetworkfirewallKeyValueTags(resp.Tags).IgnoreAws().IgnoreConfig(ignoreTagsConfig).Map()); err != nil {
	return diag.FromErr(fmt.Errorf("error setting tags: %w", err))
}

References

• r/networkfirewall: new resources #16277 (review)
• Contributing Guide on Running/Writing Acceptance Testing

[anGie44]

This enhancement has been merged and will release with v3.17.0 of the Terraform AWS provider, likely out on Thurs.

[ghost]

This has been released in version 3.17.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!