r/aws_ec2_carrier_gateway: New resource.

[ewbankkit]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #14518.

Release note for CHANGELOG:

resource/aws_ec2_carrier_gateway: New resource

Output from acceptance testing:

Account not enabled for Wavelength:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSEc2CarrierGateway_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEc2CarrierGateway_ -timeout 120m
=== RUN   TestAccAWSEc2CarrierGateway_basic
=== PAUSE TestAccAWSEc2CarrierGateway_basic
=== RUN   TestAccAWSEc2CarrierGateway_disappears
=== PAUSE TestAccAWSEc2CarrierGateway_disappears
=== RUN   TestAccAWSEc2CarrierGateway_Tags
=== PAUSE TestAccAWSEc2CarrierGateway_Tags
=== CONT  TestAccAWSEc2CarrierGateway_basic
=== CONT  TestAccAWSEc2CarrierGateway_Tags
=== CONT  TestAccAWSEc2CarrierGateway_disappears
    resource_aws_ec2_carrier_gateway_test.go:195: skipping since no Wavelength Zones are available
--- SKIP: TestAccAWSEc2CarrierGateway_disappears (1.33s)
=== CONT  TestAccAWSEc2CarrierGateway_basic
    resource_aws_ec2_carrier_gateway_test.go:195: skipping since no Wavelength Zones are available
--- SKIP: TestAccAWSEc2CarrierGateway_basic (1.37s)
=== CONT  TestAccAWSEc2CarrierGateway_Tags
    resource_aws_ec2_carrier_gateway_test.go:195: skipping since no Wavelength Zones are available
--- SKIP: TestAccAWSEc2CarrierGateway_Tags (1.37s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1.419s

Account enabled for Wavelength:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSEc2CarrierGateway_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEc2CarrierGateway_ -timeout 120m
=== RUN   TestAccAWSEc2CarrierGateway_basic
=== PAUSE TestAccAWSEc2CarrierGateway_basic
=== RUN   TestAccAWSEc2CarrierGateway_disappears
=== PAUSE TestAccAWSEc2CarrierGateway_disappears
=== RUN   TestAccAWSEc2CarrierGateway_Tags
=== PAUSE TestAccAWSEc2CarrierGateway_Tags
=== CONT  TestAccAWSEc2CarrierGateway_basic
=== CONT  TestAccAWSEc2CarrierGateway_Tags
=== CONT  TestAccAWSEc2CarrierGateway_disappears
--- PASS: TestAccAWSEc2CarrierGateway_disappears (22.26s)
--- PASS: TestAccAWSEc2CarrierGateway_basic (29.77s)
--- PASS: TestAccAWSEc2CarrierGateway_Tags (71.47s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	71.533s

[ewbankkit]

TODO: Add test sweeper.

$ TEST=./aws SWEEP=us-west-2 SWEEPARGS=-sweep-run=aws_ec2_carrier_gateway make sweep
WARNING: This will destroy infrastructure. Use only in development accounts.
go test ./aws -v -sweep=us-west-2 -sweep-run=aws_ec2_carrier_gateway -timeout 60m
2020/11/19 15:42:33 [DEBUG] Running Sweepers for region (us-west-2):
2020/11/19 15:42:33 [DEBUG] Running Sweeper (aws_ec2_carrier_gateway) in region (us-west-2)
2020/11/19 15:42:33 [INFO] AWS Auth provider used: "EnvProvider"
2020/11/19 15:42:33 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2020/11/19 15:42:34 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2020/11/19 15:42:35 Sweeper Tests ran successfully:
	- aws_ec2_carrier_gateway
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1.166s

[bflad]

Looks great, thank you @ewbankkit 🚀

Output from acceptance testing in AWS Commercial (Wavelength preview enabled):

--- PASS: TestAccAWSEc2CarrierGateway_disappears (23.47s)
--- PASS: TestAccAWSEc2CarrierGateway_basic (31.14s)
--- PASS: TestAccAWSEc2CarrierGateway_Tags (72.24s)

Output from acceptance testing in AWS GovCloud (US):

--- SKIP: TestAccAWSEc2CarrierGateway_basic (1.95s)
--- SKIP: TestAccAWSEc2CarrierGateway_Tags (1.97s)
--- SKIP: TestAccAWSEc2CarrierGateway_disappears (1.98s)

[ghost]

This has been released in version 3.21.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!