added appliance_mode_support argument/attribute #16159

philnichol · 2020-11-12T13:03:01Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

aws_ec2_transit_gateway_vpc_attachment - added appliance_mode_support argument/attribute to resource and data

Output from acceptance testing:

$ TF_ACC=1 go test ./aws -v -count 1 -parallel 4 -run=TestAccAWSEc2TransitGatewayVpcAttachmentDataSource_ -timeout 60m
=== RUN   TestAccAWSEc2TransitGatewayVpcAttachmentDataSource_Filter
=== PAUSE TestAccAWSEc2TransitGatewayVpcAttachmentDataSource_Filter
=== RUN   TestAccAWSEc2TransitGatewayVpcAttachmentDataSource_ID
=== PAUSE TestAccAWSEc2TransitGatewayVpcAttachmentDataSource_ID
=== CONT  TestAccAWSEc2TransitGatewayVpcAttachmentDataSource_Filter
=== CONT  TestAccAWSEc2TransitGatewayVpcAttachmentDataSource_ID
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachmentDataSource_ID (385.44s)
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachmentDataSource_Filter (385.46s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       385.501s

$ TF_ACC=1 go test ./aws -v -count 1 -parallel 4 -run=TestAccAWSEc2TransitGatewayVpcAttachment -timeout 60m
=== RUN   TestAccAWSEc2TransitGatewayVpcAttachmentDataSource_Filter
=== PAUSE TestAccAWSEc2TransitGatewayVpcAttachmentDataSource_Filter
=== RUN   TestAccAWSEc2TransitGatewayVpcAttachmentDataSource_ID
=== PAUSE TestAccAWSEc2TransitGatewayVpcAttachmentDataSource_ID
=== RUN   TestAccAWSEc2TransitGatewayVpcAttachmentAccepter_basic
=== PAUSE TestAccAWSEc2TransitGatewayVpcAttachmentAccepter_basic
=== RUN   TestAccAWSEc2TransitGatewayVpcAttachmentAccepter_Tags
=== PAUSE TestAccAWSEc2TransitGatewayVpcAttachmentAccepter_Tags
=== RUN   TestAccAWSEc2TransitGatewayVpcAttachmentAccepter_TransitGatewayDefaultRouteTableAssociationAndPropagation
=== PAUSE TestAccAWSEc2TransitGatewayVpcAttachmentAccepter_TransitGatewayDefaultRouteTableAssociationAndPropagation
=== RUN   TestAccAWSEc2TransitGatewayVpcAttachment_basic
=== PAUSE TestAccAWSEc2TransitGatewayVpcAttachment_basic
=== RUN   TestAccAWSEc2TransitGatewayVpcAttachment_disappears
=== PAUSE TestAccAWSEc2TransitGatewayVpcAttachment_disappears
=== RUN   TestAccAWSEc2TransitGatewayVpcAttachment_ApplianceModeSupport
=== PAUSE TestAccAWSEc2TransitGatewayVpcAttachment_ApplianceModeSupport
=== RUN   TestAccAWSEc2TransitGatewayVpcAttachment_DnsSupport
=== PAUSE TestAccAWSEc2TransitGatewayVpcAttachment_DnsSupport
=== RUN   TestAccAWSEc2TransitGatewayVpcAttachment_Ipv6Support
=== PAUSE TestAccAWSEc2TransitGatewayVpcAttachment_Ipv6Support
=== RUN   TestAccAWSEc2TransitGatewayVpcAttachment_SharedTransitGateway
=== PAUSE TestAccAWSEc2TransitGatewayVpcAttachment_SharedTransitGateway
=== RUN   TestAccAWSEc2TransitGatewayVpcAttachment_SubnetIds
=== PAUSE TestAccAWSEc2TransitGatewayVpcAttachment_SubnetIds
=== RUN   TestAccAWSEc2TransitGatewayVpcAttachment_Tags
=== PAUSE TestAccAWSEc2TransitGatewayVpcAttachment_Tags
=== RUN   TestAccAWSEc2TransitGatewayVpcAttachment_TransitGatewayDefaultRouteTableAssociationAndPropagationDisabled
=== PAUSE TestAccAWSEc2TransitGatewayVpcAttachment_TransitGatewayDefaultRouteTableAssociationAndPropagationDisabled
=== RUN   TestAccAWSEc2TransitGatewayVpcAttachment_TransitGatewayDefaultRouteTableAssociation
=== PAUSE TestAccAWSEc2TransitGatewayVpcAttachment_TransitGatewayDefaultRouteTableAssociation
=== RUN   TestAccAWSEc2TransitGatewayVpcAttachment_TransitGatewayDefaultRouteTablePropagation
=== PAUSE TestAccAWSEc2TransitGatewayVpcAttachment_TransitGatewayDefaultRouteTablePropagation
=== CONT  TestAccAWSEc2TransitGatewayVpcAttachmentDataSource_Filter
=== CONT  TestAccAWSEc2TransitGatewayVpcAttachment_Ipv6Support
=== CONT  TestAccAWSEc2TransitGatewayVpcAttachment_Tags
=== CONT  TestAccAWSEc2TransitGatewayVpcAttachment_SubnetIds
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachment_Tags (343.17s)
=== CONT  TestAccAWSEc2TransitGatewayVpcAttachment_TransitGatewayDefaultRouteTableAssociationAndPropagationDisabled
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachment_Ipv6Support (343.19s)
=== CONT  TestAccAWSEc2TransitGatewayVpcAttachment_TransitGatewayDefaultRouteTablePropagation
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachmentDataSource_Filter (366.36s)
=== CONT  TestAccAWSEc2TransitGatewayVpcAttachment_TransitGatewayDefaultRouteTableAssociation
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachment_SubnetIds (462.11s)
=== CONT  TestAccAWSEc2TransitGatewayVpcAttachment_basic
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachment_TransitGatewayDefaultRouteTableAssociationAndPropagationDisabled (305.30s)
=== CONT  TestAccAWSEc2TransitGatewayVpcAttachment_SharedTransitGateway
    resource_aws_ec2_transit_gateway_vpc_attachment_test.go:256: Step 1/2 error: Error running pre-apply refresh:
        Error: Error describing organization: AWSOrganizationsNotInUseException: Your account is not a member of an organization.


--- FAIL: TestAccAWSEc2TransitGatewayVpcAttachment_SharedTransitGateway (3.14s)
=== CONT  TestAccAWSEc2TransitGatewayVpcAttachment_DnsSupport
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachment_TransitGatewayDefaultRouteTablePropagation (360.25s)
=== CONT  TestAccAWSEc2TransitGatewayVpcAttachment_ApplianceModeSupport
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachment_TransitGatewayDefaultRouteTableAssociation (460.74s)
=== CONT  TestAccAWSEc2TransitGatewayVpcAttachment_disappears
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachment_basic (385.47s)
=== CONT  TestAccAWSEc2TransitGatewayVpcAttachmentAccepter_Tags
    resource_aws_ec2_transit_gateway_vpc_attachment_accepter_test.go:69: Step 1/3 error: Error running apply:
        Error: Error associating principal with RAM resource share: OperationNotPermittedException: The resource you are attempting to share can only be shared within your AWS Organization. This error may also occur if you have not enabled sharing with your AWS organization, or that onboarding process is still in progress.



        Error: error associating RAM Resource Share: OperationNotPermittedException: The resource you are attempting to share can only be shared within your AWS Organization. This error may also occur if you have not enabled sharing with your AWS organization, or that onboarding process is still in progress.


--- PASS: TestAccAWSEc2TransitGatewayVpcAttachment_DnsSupport (380.67s)
=== CONT  TestAccAWSEc2TransitGatewayVpcAttachmentAccepter_TransitGatewayDefaultRouteTableAssociationAndPropagation
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachment_ApplianceModeSupport (361.96s)
=== CONT  TestAccAWSEc2TransitGatewayVpcAttachmentAccepter_basic
--- FAIL: TestAccAWSEc2TransitGatewayVpcAttachmentAccepter_Tags (239.27s)
=== CONT  TestAccAWSEc2TransitGatewayVpcAttachmentDataSource_ID
=== CONT  TestAccAWSEc2TransitGatewayVpcAttachmentAccepter_TransitGatewayDefaultRouteTableAssociationAndPropagation
    resource_aws_ec2_transit_gateway_vpc_attachment_accepter_test.go:138: Step 1/4 error: Error running apply:
        Error: Error associating principal with RAM resource share: OperationNotPermittedException: The resource you are attempting to share can only be shared within your AWS Organization. This error may also occur if you have not enabled sharing with your AWS organization, or that onboarding process is still in progress.



        Error: error associating RAM Resource Share: OperationNotPermittedException: The resource you are attempting to share can only be shared within your AWS Organization. This error may also occur if you have not enabled sharing with your AWS organization, or that onboarding process is still in progress.


=== CONT  TestAccAWSEc2TransitGatewayVpcAttachmentAccepter_basic
    resource_aws_ec2_transit_gateway_vpc_attachment_accepter_test.go:23: Step 1/2 error: Error running apply:
        Error: error associating RAM Resource Share: OperationNotPermittedException: The resource you are attempting to share can only be shared within your AWS Organization. This error may also occur if you have not enabled sharing with your AWS organization, or that onboarding process is still in progress.



        Error: Error associating principal with RAM resource share: OperationNotPermittedException: The resource you are attempting to share can only be shared within your AWS Organization. This error may also occur if you have not enabled sharing with your AWS organization, or that onboarding process is still in progress.


--- PASS: TestAccAWSEc2TransitGatewayVpcAttachment_disappears (362.67s)
--- FAIL: TestAccAWSEc2TransitGatewayVpcAttachmentAccepter_TransitGatewayDefaultRouteTableAssociationAndPropagation (219.07s)
--- FAIL: TestAccAWSEc2TransitGatewayVpcAttachmentAccepter_basic (198.47s)
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachmentDataSource_ID (343.91s)
FAIL
FAIL    github.com/terraform-providers/terraform-provider-aws/aws       1431.197s
FAIL

Some of the acceptance tests failed locally since I don't have an AWS organization or multiple accounts to test this on, hoping if this looks good someone who has this available can run them to make sure it's all good?

Thanks in advance for your review!

Requires AWS SDK v1.35.18:

#15930

bflad

Hi @philnichol 👋 Overall looks really good, just some minor things then we'll run the testing to verify everything. 👍

aws/resource_aws_ec2_transit_gateway_vpc_attachment.go

bflad · 2020-11-12T14:27:53Z

aws/data_source_aws_ec2_transit_gateway_vpc_attachment.go

@@ -16,6 +16,10 @@ func dataSourceAwsEc2TransitGatewayVpcAttachment() *schema.Resource {
 		Read: dataSourceAwsEc2TransitGatewayVpcAttachmentRead,

 		Schema: map[string]*schema.Schema{
+			"appliance_mode_support": {


Needs documentation in website/docs/d/ec2_transit_gateway_vpc_attachment.html.markdown 👍

Good spot, completely forgot that! Have updated the doc

Co-authored-by: Brian Flad <[email protected]>

…form-provider-aws into e-adding-appliance-mode

bflad

Looks fantastic, thanks @philnichol 🚀

Output from acceptance testing (ignoring RAM-related failures):

--- PASS: TestAccAWSEc2TransitGatewayVpcAttachment_ApplianceModeSupport (432.34s)
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachment_basic (424.94s)
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachment_disappears (408.65s)
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachment_DnsSupport (431.95s)
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachment_Ipv6Support (424.15s)
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachment_SubnetIds (547.74s)
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachment_Tags (427.05s)
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachment_TransitGatewayDefaultRouteTableAssociation (543.11s)
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachment_TransitGatewayDefaultRouteTableAssociationAndPropagationDisabled (305.43s)
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachment_TransitGatewayDefaultRouteTablePropagation (485.59s)

--- PASS: TestAccAWSEc2TransitGatewayVpcAttachmentDataSource_Filter (370.83s)
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachmentDataSource_ID (433.38s)

philnichol · 2020-11-12T14:57:03Z

Cheers @bflad and thanks for the review!

nckbnv · 2020-11-12T15:06:21Z

That was super fast - thank you both @philnichol and @bflad

ghost · 2020-11-12T23:36:29Z

This has been released in version 3.15.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

ghost · 2020-12-12T17:12:24Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

added appliance_mode_support argument/attribute

1dcc26c

philnichol requested a review from a team as a code owner November 12, 2020 13:03

ghost added size/M Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 12, 2020

github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Nov 12, 2020

fixed test linting error

48274ba

bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 12, 2020

bflad linked an issue Nov 12, 2020 that may be closed by this pull request

ec2_transit_gateway_vpc_attachment: add support for "enable_appliance_mode" #16161

Closed

bflad reviewed Nov 12, 2020

View reviewed changes

bflad added this to the v3.15.0 milestone Nov 12, 2020

bflad self-assigned this Nov 12, 2020

philnichol and others added 3 commits November 12, 2020 14:30

Update aws/resource_aws_ec2_transit_gateway_vpc_attachment.go

06b6bae

Co-authored-by: Brian Flad <[email protected]>

added appliance_mode_support attribute to docs

53c56e7

Merge branch 'e-adding-appliance-mode' of github.com:philnichol/terra…

7dd1f4d

…form-provider-aws into e-adding-appliance-mode

bflad approved these changes Nov 12, 2020

View reviewed changes

bflad merged commit 276a95e into hashicorp:master Nov 12, 2020

philnichol deleted the e-adding-appliance-mode branch November 12, 2020 14:57

bflad added a commit that referenced this pull request Nov 12, 2020

Update CHANGELOG for #16159

7fcd5b6

ghost locked as resolved and limited conversation to collaborators Dec 12, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added appliance_mode_support argument/attribute #16159

added appliance_mode_support argument/attribute #16159

philnichol commented Nov 12, 2020

bflad left a comment

bflad Nov 12, 2020

philnichol Nov 12, 2020

bflad left a comment

philnichol commented Nov 12, 2020

nckbnv commented Nov 12, 2020

ghost commented Nov 12, 2020

ghost commented Dec 12, 2020

added appliance_mode_support argument/attribute #16159

added appliance_mode_support argument/attribute #16159

Conversation

philnichol commented Nov 12, 2020

Community Note

bflad left a comment

Choose a reason for hiding this comment

bflad Nov 12, 2020

Choose a reason for hiding this comment

philnichol Nov 12, 2020

Choose a reason for hiding this comment

bflad left a comment

Choose a reason for hiding this comment

philnichol commented Nov 12, 2020

nckbnv commented Nov 12, 2020

ghost commented Nov 12, 2020

ghost commented Dec 12, 2020