r/storagegateway_nfs_file_share - support `file_share_name` #16072

DrFaust92 · 2020-11-06T10:35:10Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

resource_aws_storagegateway_nfs_file_share - support `file_share_name`

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSStorageGatewayNfsFileShare_'
--- PASS: TestAccAWSStorageGatewayNfsFileShare_basic (286.69s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_disappears (314.00s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_cacheAttributes (545.97s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_KMSKeyArn (554.94s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_ReadOnly (409.35s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_Squash (459.57s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_ObjectACL (377.12s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_RequesterPays (393.68s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_KMSEncrypted (341.95s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_DefaultStorageClass (444.18s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_fileShareName (428.53s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_NFSFileShareDefaults (469.43s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_tags (543.66s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_ClientList (672.34s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_GuessMIMETypeEnabled (444.01s)

ewbankkit · 2020-11-06T14:21:17Z

Relates: #16008.

website/docs/r/storagegateway_nfs_file_share.html.markdown

ewbankkit

LGTM.

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSStorageGatewayNfsFileShare_fileShareName'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSStorageGatewayNfsFileShare_fileShareName -timeout 120m
=== RUN   TestAccAWSStorageGatewayNfsFileShare_fileShareName
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_fileShareName
=== CONT  TestAccAWSStorageGatewayNfsFileShare_fileShareName
--- PASS: TestAccAWSStorageGatewayNfsFileShare_fileShareName (284.18s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	284.238s

Co-authored-by: Kit Ewbank <[email protected]>

breathingdust · 2020-11-17T22:52:48Z

LGTM 🚀 Thanks @DrFaust92 for the contribution!

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TEST=./aws TESTARGS='-run=TestAccAWSStorageGatewayNfsFileShare_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSStorageGatewayNfsFileShare_ -timeout 120m
=== RUN   TestAccAWSStorageGatewayNfsFileShare_basic
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_basic
=== RUN   TestAccAWSStorageGatewayNfsFileShare_tags
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_tags
=== RUN   TestAccAWSStorageGatewayNfsFileShare_fileShareName
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_fileShareName
=== RUN   TestAccAWSStorageGatewayNfsFileShare_ClientList
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_ClientList
=== RUN   TestAccAWSStorageGatewayNfsFileShare_DefaultStorageClass
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_DefaultStorageClass
=== RUN   TestAccAWSStorageGatewayNfsFileShare_GuessMIMETypeEnabled
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_GuessMIMETypeEnabled
=== RUN   TestAccAWSStorageGatewayNfsFileShare_KMSEncrypted
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_KMSEncrypted
=== RUN   TestAccAWSStorageGatewayNfsFileShare_KMSKeyArn
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_KMSKeyArn
=== RUN   TestAccAWSStorageGatewayNfsFileShare_NFSFileShareDefaults
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_NFSFileShareDefaults
=== RUN   TestAccAWSStorageGatewayNfsFileShare_ObjectACL
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_ObjectACL
=== RUN   TestAccAWSStorageGatewayNfsFileShare_ReadOnly
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_ReadOnly
=== RUN   TestAccAWSStorageGatewayNfsFileShare_RequesterPays
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_RequesterPays
=== RUN   TestAccAWSStorageGatewayNfsFileShare_Squash
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_Squash
=== RUN   TestAccAWSStorageGatewayNfsFileShare_cacheAttributes
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_cacheAttributes
=== RUN   TestAccAWSStorageGatewayNfsFileShare_disappears
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_disappears
=== CONT  TestAccAWSStorageGatewayNfsFileShare_basic
=== CONT  TestAccAWSStorageGatewayNfsFileShare_NFSFileShareDefaults
=== CONT  TestAccAWSStorageGatewayNfsFileShare_cacheAttributes
=== CONT  TestAccAWSStorageGatewayNfsFileShare_DefaultStorageClass
=== CONT  TestAccAWSStorageGatewayNfsFileShare_KMSKeyArn
=== CONT  TestAccAWSStorageGatewayNfsFileShare_KMSEncrypted
=== CONT  TestAccAWSStorageGatewayNfsFileShare_Squash
=== CONT  TestAccAWSStorageGatewayNfsFileShare_GuessMIMETypeEnabled
=== CONT  TestAccAWSStorageGatewayNfsFileShare_fileShareName
=== CONT  TestAccAWSStorageGatewayNfsFileShare_disappears
=== CONT  TestAccAWSStorageGatewayNfsFileShare_ClientList
=== CONT  TestAccAWSStorageGatewayNfsFileShare_RequesterPays
=== CONT  TestAccAWSStorageGatewayNfsFileShare_ObjectACL
=== CONT  TestAccAWSStorageGatewayNfsFileShare_ReadOnly
=== CONT  TestAccAWSStorageGatewayNfsFileShare_tags
2020/11/17 14:35:16 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2020/11/17 14:35:16 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2020/11/17 14:35:16 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2020/11/17 14:35:21 [DEBUG] Waiting for state to become: [success]
2020/11/17 14:36:24 [INFO] AWS Auth provider used: "SharedCredentialsProvider"
--- PASS: TestAccAWSStorageGatewayNfsFileShare_disappears (233.37s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_KMSEncrypted (239.53s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_basic (258.49s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_fileShareName (285.94s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_Squash (289.51s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_ReadOnly (293.96s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_DefaultStorageClass (298.18s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_NFSFileShareDefaults (298.33s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_ObjectACL (305.71s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_tags (307.41s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_GuessMIMETypeEnabled (336.60s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_cacheAttributes (337.57s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_RequesterPays (348.27s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_ClientList (387.98s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_KMSKeyArn (450.87s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	452.792s

Verified Acceptance Tests in GovCloud (us-gov-west-1)

make testacc TEST=./aws TESTARGS='-run=TestAccAWSStorageGatewayNfsFileShare_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSStorageGatewayNfsFileShare_ -timeout 120m
=== RUN   TestAccAWSStorageGatewayNfsFileShare_basic
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_basic
=== RUN   TestAccAWSStorageGatewayNfsFileShare_tags
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_tags
=== RUN   TestAccAWSStorageGatewayNfsFileShare_fileShareName
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_fileShareName
=== RUN   TestAccAWSStorageGatewayNfsFileShare_ClientList
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_ClientList
=== RUN   TestAccAWSStorageGatewayNfsFileShare_DefaultStorageClass
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_DefaultStorageClass
=== RUN   TestAccAWSStorageGatewayNfsFileShare_GuessMIMETypeEnabled
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_GuessMIMETypeEnabled
=== RUN   TestAccAWSStorageGatewayNfsFileShare_KMSEncrypted
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_KMSEncrypted
=== RUN   TestAccAWSStorageGatewayNfsFileShare_KMSKeyArn
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_KMSKeyArn
=== RUN   TestAccAWSStorageGatewayNfsFileShare_NFSFileShareDefaults
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_NFSFileShareDefaults
=== RUN   TestAccAWSStorageGatewayNfsFileShare_ObjectACL
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_ObjectACL
=== RUN   TestAccAWSStorageGatewayNfsFileShare_ReadOnly
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_ReadOnly
=== RUN   TestAccAWSStorageGatewayNfsFileShare_RequesterPays
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_RequesterPays
=== RUN   TestAccAWSStorageGatewayNfsFileShare_Squash
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_Squash
=== RUN   TestAccAWSStorageGatewayNfsFileShare_cacheAttributes
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_cacheAttributes
=== RUN   TestAccAWSStorageGatewayNfsFileShare_disappears
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_disappears
=== CONT  TestAccAWSStorageGatewayNfsFileShare_basic
=== CONT  TestAccAWSStorageGatewayNfsFileShare_NFSFileShareDefaults
=== CONT  TestAccAWSStorageGatewayNfsFileShare_DefaultStorageClass
=== CONT  TestAccAWSStorageGatewayNfsFileShare_tags
=== CONT  TestAccAWSStorageGatewayNfsFileShare_cacheAttributes
=== CONT  TestAccAWSStorageGatewayNfsFileShare_Squash
=== CONT  TestAccAWSStorageGatewayNfsFileShare_RequesterPays
=== CONT  TestAccAWSStorageGatewayNfsFileShare_ReadOnly
=== CONT  TestAccAWSStorageGatewayNfsFileShare_ObjectACL
=== CONT  TestAccAWSStorageGatewayNfsFileShare_KMSEncrypted
=== CONT  TestAccAWSStorageGatewayNfsFileShare_fileShareName
=== CONT  TestAccAWSStorageGatewayNfsFileShare_KMSKeyArn
=== CONT  TestAccAWSStorageGatewayNfsFileShare_ClientList
=== CONT  TestAccAWSStorageGatewayNfsFileShare_GuessMIMETypeEnabled
=== CONT  TestAccAWSStorageGatewayNfsFileShare_disappears
2020/11/17 14:41:30 [INFO] AWS Auth provider used: "SharedCredentialsProvider"
2020/11/17 14:41:30 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2020/11/17 14:41:30 [DEBUG] Waiting for state to become: [success]
2020/11/17 14:41:30 [DEBUG] Waiting for state to become: [success]
2020/11/17 14:41:30 [DEBUG] setting computed for "versioning" from ComputedKeys
2020/11/17 14:41:30 [DEBUG] S3 bucket create: tf-acc-test-306670832944446823
2020/11/17 14:41:30 [DEBUG] S3 bucket tf-acc-test-306670832944446823 has canned ACL private
2020/11/17 14:41:30 [DEBUG] S3 bucket create: tf-acc-test-306670832944446823, using region: us-gov-west-1
2020/11/17 14:41:30 [DEBUG] Waiting for state to become: [success]
2020/11/17 14:41:30 [DEBUG] Trying to create new S3 bucket: "tf-acc-test-306670832944446823"
2020/11/17 14:43:55 [DEBUG] Reading Storage Gateway SMB Settings: {
  GatewayARN: "arn:aws-us-gov:storagegateway:us-gov-west-1:357342307427:gateway/sgw-978066FE"
}
2020/11/17 14:44:01 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2020/11/17 14:44:01 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2020/11/17 14:44:32 [INFO] AWS Auth provider used: "SharedCredentialsProvider"
--- PASS: TestAccAWSStorageGatewayNfsFileShare_disappears (203.21s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_KMSEncrypted (212.57s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_basic (240.76s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_tags (250.82s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_ReadOnly (264.13s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_RequesterPays (267.59s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_GuessMIMETypeEnabled (274.54s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_Squash (307.63s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_NFSFileShareDefaults (308.28s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_DefaultStorageClass (315.51s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_fileShareName (317.54s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_ClientList (320.33s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_ObjectACL (326.75s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_KMSKeyArn (344.21s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_cacheAttributes (384.61s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	386.095s

ghost · 2020-11-18T19:51:47Z

This has been released in version 3.16.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

ghost · 2020-12-18T17:11:19Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

DrFaust92 added 3 commits November 6, 2020 12:21

add file_share_name

30dfb89

docs

179d18a

computed and basic test

42efc16

ghost added size/M Managed by automation to categorize the size of a PR. service/storagegateway Issues and PRs that pertain to the storagegateway service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 6, 2020

DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 6, 2020

DrFaust92 marked this pull request as ready for review November 6, 2020 11:12

DrFaust92 requested a review from a team as a code owner November 6, 2020 11:12

ewbankkit reviewed Nov 6, 2020

View reviewed changes

website/docs/r/storagegateway_nfs_file_share.html.markdown Outdated Show resolved Hide resolved

ewbankkit approved these changes Nov 6, 2020

View reviewed changes

Update website/docs/r/storagegateway_nfs_file_share.html.markdown

c8756fe

Co-authored-by: Kit Ewbank <[email protected]>

breathingdust added this to the v3.16.0 milestone Nov 17, 2020

breathingdust merged commit fe3e61a into hashicorp:master Nov 17, 2020

breathingdust added a commit that referenced this pull request Nov 17, 2020

Update CHANGELOG.md for #16072

0a6fe66

nathancarmona mentioned this pull request Nov 18, 2020

Storage Gateway - NFS file share name #16267

Closed

ghost locked as resolved and limited conversation to collaborators Dec 18, 2020

DrFaust92 deleted the r/storagegateway_nfs_name branch April 15, 2021 10:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

r/storagegateway_nfs_file_share - support `file_share_name` #16072

r/storagegateway_nfs_file_share - support `file_share_name` #16072

DrFaust92 commented Nov 6, 2020 •

edited

Loading

ewbankkit commented Nov 6, 2020

ewbankkit left a comment

breathingdust commented Nov 17, 2020

ghost commented Nov 18, 2020

ghost commented Dec 18, 2020

r/storagegateway_nfs_file_share - support file_share_name #16072

r/storagegateway_nfs_file_share - support file_share_name #16072

Conversation

DrFaust92 commented Nov 6, 2020 • edited Loading

Community Note

ewbankkit commented Nov 6, 2020

ewbankkit left a comment

Choose a reason for hiding this comment

breathingdust commented Nov 17, 2020

ghost commented Nov 18, 2020

ghost commented Dec 18, 2020

r/storagegateway_nfs_file_share - support `file_share_name` #16072

r/storagegateway_nfs_file_share - support `file_share_name` #16072

DrFaust92 commented Nov 6, 2020 •

edited

Loading