Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New resource: aws_elasticache_global_replication_group #15885

Merged
merged 15 commits into from
Feb 19, 2021
Merged

New resource: aws_elasticache_global_replication_group #15885

merged 15 commits into from
Feb 19, 2021

Conversation

MqllR
Copy link
Contributor

@MqllR MqllR commented Oct 28, 2020 •
edited by gdavison
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #12708

Release note for CHANGELOG:

New Resource: aws_elasticache_global_replication_group

Output from acceptance testing:

make testacc TESTARGS='-run=TestAccAWSElasticacheGlobalReplicationGroup'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSElasticacheGlobalReplicationGroup -timeout 120m
=== RUN   TestAccAWSElasticacheGlobalReplicationGroup_basic
=== PAUSE TestAccAWSElasticacheGlobalReplicationGroup_basic
=== RUN   TestAccAWSElasticacheGlobalReplicationGroup_disappears
=== PAUSE TestAccAWSElasticacheGlobalReplicationGroup_disappears
=== CONT  TestAccAWSElasticacheGlobalReplicationGroup_basic
=== CONT  TestAccAWSElasticacheGlobalReplicationGroup_disappears
    resource_aws_elasticache_global_replication_group_test.go:114: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSElasticacheGlobalReplicationGroup_basic (970.16s)
--- PASS: TestAccAWSElasticacheGlobalReplicationGroup_disappears (987.04s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       987.066s

Note:
In order to get a working ElastiCache Global Datastore, we should refine the resource elasticache_replication_group. Actually, to associate an elasticache_replication_group, the only parameter accepted is a global_replication_group_id. The change is pretty big on the resource elasticache_replication_group, so what do you recommend? Treating this in another PR?

@MqllR
feat: implement the elasticache_global_replication_group resource
42388a0
@MqllR
feat: manage the global replication group deletion
45d9c5a
@MqllR
feat: create the base documentation page for elasticache_global_repli…
a2264f0 
…cation_group
@MqllR
feat: add basic acceptance test and initiate doc
5f98c7f
@MqllR
feat: improve doc resource page and fix fmt test
57a8afa
@MqllR
fix misspell words
60850dd
@MqllR
add disappears tests
43280e9
@MqllR
feat: implement the elasticache_global_replication_group resource
02b5f60
@MqllR
feat: manage the global replication group deletion
348260e
@MqllR
feat: create the base documentation page for elasticache_global_repli…
5e266b6 
…cation_group
@MqllR
feat: add basic acceptance test and initiate doc
adc8f6b
@MqllR
feat: improve doc resource page and fix fmt test
e362f58
@MqllR
fix misspell words
19996bd
@MqllR
add disappears tests
6de6f93
@MqllR
Merge branch 'elasticache_global_replication_group' of github.com:Mql…
15ee11e 
…lR/terraform-provider-aws into elasticache_global_replication_group
@MqllR MqllR requested a review from a team October 28, 2020 15:17
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/elasticache Issues and PRs that pertain to the elasticache service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 28, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Oct 28, 2020
@MqllR MqllR mentioned this pull request Oct 28, 2020
Closed
@bill-rich bill-rich removed the needs-triage Waiting for first response or review from a maintainer. label Nov 2, 2020
@fphilippon
Copy link

Hello, any idea when this wonderful PR will be merged?
Thanks!

Base automatically changed from master to main January 23, 2021 00:59
@breathingdust breathingdust requested a review from a team as a code owner January 23, 2021 00:59
@ppapishe
Copy link

ppapishe commented Feb 1, 2021

is there any way we can get some traction on this PR?

@gdavison gdavison self-assigned this Feb 6, 2021
@gdavison gdavison mentioned this pull request Feb 15, 2021
Merged
gdavison
gdavison reviewed Feb 15, 2021
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @MqllR. This is a great start. I've completed the initial support in #17615

aws/resource_aws_elasticache_global_replication_group_test.go
return fmt.Errorf("Elasticache Global Replication Group not found")
}

if aws.StringValue(cluster.Status) != "available" && aws.StringValue(cluster.Status) != "primary-only" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this is a good check

aws/resource_aws_elasticache_global_replication_group_test.go
Comment on lines +229 to +232
resource "aws_elasticache_global_replication_group" "test" {
global_replication_group_id_suffix = %q
primary_replication_group_id = aws_elasticache_replication_group.test.id
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that you put the resource under test at the top. It makes it a lot easier to understand the test

@MqllR
Copy link
Contributor Author

MqllR commented Feb 16, 2021

Thanks @gdavison for your review. Let me know if I can help or review something :)

@gdavison gdavison merged commit 8d3e4a9 into hashicorp:main Feb 19, 2021
@github-actions github-actions bot added this to the v3.29.0 milestone Feb 19, 2021
@gdavison gdavison mentioned this pull request Feb 19, 2021
Closed
3 tasks
@ghost
Copy link

ghost commented Feb 19, 2021

This has been released in version 3.29.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 21, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gdavison gdavison gdavison left review comments

Assignees

@gdavison gdavison

Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/elasticache Issues and PRs that pertain to the elasticache service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.29.0
Development

Successfully merging this pull request may close these issues.
5 participants
@MqllR @fphilippon @ppapishe @gdavison @bill-rich