Feature/ds key pair

[pkruk]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #15590

Release note for CHANGELOG:

NONE

Output from acceptance testing:

☁  terraform-provider-aws [feature/ds_key_pair] ⚡  AWS_PROFILE=default make testacc TESTARGS='-run=TestAccDataSourceAwsKeyPair_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsKeyPair_basic -timeout 120m

=== RUN   TestAccDataSourceAwsKeyPair_basic
=== PAUSE TestAccDataSourceAwsKeyPair_basic
=== CONT  TestAccDataSourceAwsKeyPair_basic
--- PASS: TestAccDataSourceAwsKeyPair_basic (35.10s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       37.831s
...

This is my first PR here, I will be very happy for feedback and if you spot anything missing in PR :)

[andrzej-jedrzejewski]

When this will be merged and released?

[andrzej-jedrzejewski]

merge and release, please :)

[evandam]

Hey folks, anything holding this PR back? Seems like it's ready to go and would be helpful!

[bneigher]

looking forward to this!

[fabriciomariani]

Is there anything blockthing this from getting released? Seems like everything is ready to go

[pkruk]

Hi,
Any chance to get it merged :)? There is anything I can do ?

[mboogerd]

Code makes sense, documentation and tests are provided. All automated lights are green. Could we get this small but useful feature merged, or an ETA on when it'll be looked into? Thanks in advance :)

[alexbricepalo]

Whats the holdup here?

[mbainter]

See the contributions file, specifically:

Edit: Snipped out the quote regarding a moratorium on PRs, as that apparently doesn't apply to providers but only terraform core. See @justinretzolk's comment below.

[justinretzolk]

Hi all 👋 Thank you all for your patience here. We use the "👍" reactions on a given issue/pull request in order to aid in prioritizing community contributions (thank you to everyone who has reacted to this one so far!). While I can't promise any sort of timeline for review/merge, the team is aware of this pull request, and will work on it as soon as time permits. Please keep adding "👍" if this pull request would help you; the more votes it receives, the more likely it is that it will be included in an upcoming release.

I'd be remiss if I didn't mention the quote that @mbainter provided. That update applies only to Terraform Core, not the separate provider repositories. We are still reviewing and accepting community contributions to the individual providers, including the AWS provider.

[pkruk]

I just resolved the merge conflict, so we will have a clean state for merging ;)

[zhelding]

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

[ewbankkit]

LGTM 🚀.

Commercial

% make testacc PKG_NAME=internal/service/ec2 TESTARGS='-run=TestAccEC2KeyPair_\|TestAccEC2KeyPairDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2KeyPair_\|TestAccEC2KeyPairDataSource_ -timeout 180m
=== RUN   TestAccEC2KeyPairDataSource_basic
=== PAUSE TestAccEC2KeyPairDataSource_basic
=== RUN   TestAccEC2KeyPair_basic
=== PAUSE TestAccEC2KeyPair_basic
=== RUN   TestAccEC2KeyPair_tags
=== PAUSE TestAccEC2KeyPair_tags
=== RUN   TestAccEC2KeyPair_nameGenerated
=== PAUSE TestAccEC2KeyPair_nameGenerated
=== RUN   TestAccEC2KeyPair_namePrefix
=== PAUSE TestAccEC2KeyPair_namePrefix
=== RUN   TestAccEC2KeyPair_disappears
=== PAUSE TestAccEC2KeyPair_disappears
=== CONT  TestAccEC2KeyPairDataSource_basic
=== CONT  TestAccEC2KeyPair_nameGenerated
=== CONT  TestAccEC2KeyPair_disappears
=== CONT  TestAccEC2KeyPair_namePrefix
=== CONT  TestAccEC2KeyPair_tags
=== CONT  TestAccEC2KeyPair_basic
--- PASS: TestAccEC2KeyPair_disappears (13.90s)
--- PASS: TestAccEC2KeyPairDataSource_basic (16.08s)
--- PASS: TestAccEC2KeyPair_basic (16.57s)
--- PASS: TestAccEC2KeyPair_namePrefix (18.78s)
--- PASS: TestAccEC2KeyPair_nameGenerated (18.93s)
--- PASS: TestAccEC2KeyPair_tags (39.36s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	43.226s

GovCloud

% make testacc PKG_NAME=internal/service/ec2 TESTARGS='-run=TestAccEC2KeyPair_\|TestAccEC2KeyPairDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2KeyPair_\|TestAccEC2KeyPairDataSource_ -timeout 180m
=== RUN   TestAccEC2KeyPairDataSource_basic
=== PAUSE TestAccEC2KeyPairDataSource_basic
=== RUN   TestAccEC2KeyPair_basic
=== PAUSE TestAccEC2KeyPair_basic
=== RUN   TestAccEC2KeyPair_tags
=== PAUSE TestAccEC2KeyPair_tags
=== RUN   TestAccEC2KeyPair_nameGenerated
=== PAUSE TestAccEC2KeyPair_nameGenerated
=== RUN   TestAccEC2KeyPair_namePrefix
=== PAUSE TestAccEC2KeyPair_namePrefix
=== RUN   TestAccEC2KeyPair_disappears
=== PAUSE TestAccEC2KeyPair_disappears
=== CONT  TestAccEC2KeyPairDataSource_basic
=== CONT  TestAccEC2KeyPair_namePrefix
=== CONT  TestAccEC2KeyPair_tags
=== CONT  TestAccEC2KeyPair_basic
=== CONT  TestAccEC2KeyPair_disappears
=== CONT  TestAccEC2KeyPair_nameGenerated
--- PASS: TestAccEC2KeyPair_disappears (18.06s)
--- PASS: TestAccEC2KeyPairDataSource_basic (20.76s)
--- PASS: TestAccEC2KeyPair_nameGenerated (23.55s)
--- PASS: TestAccEC2KeyPair_basic (23.58s)
--- PASS: TestAccEC2KeyPair_namePrefix (23.63s)
--- PASS: TestAccEC2KeyPair_tags (49.26s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	53.100s

[ewbankkit]

@pkruk Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v3.65.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.