Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/sagemaker_notebook_instance - add url and network_interface_id attributes #15802

Merged

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Oct 23, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

resource_aws_sagemaker_notebook_instance - add `url` and `network_interface_id` attributes

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'
--- PASS: TestAccAWSSagemakerNotebookInstance_basic (334.35s)
--- PASS: TestAccAWSSagemakerNotebookInstance_direct_internet_access (770.32s)

@ghost ghost added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/sagemaker Issues and PRs that pertain to the sagemaker service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 23, 2020
@DrFaust92 DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Oct 23, 2020
@DrFaust92 DrFaust92 marked this pull request as ready for review October 23, 2020 06:51
@DrFaust92 DrFaust92 requested a review from a team October 23, 2020 06:51
@bflad bflad added this to the v3.13.0 milestone Oct 27, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀

Output from acceptance testing:

--- PASS: TestAccAWSSagemakerNotebookInstanceLifecycleConfiguration_basic (24.20s)
--- PASS: TestAccAWSSagemakerNotebookInstanceLifecycleConfiguration_Update (33.29s)
--- PASS: TestAccAWSSagemakerNotebookInstance_disappears (337.73s)
--- PASS: TestAccAWSSagemakerNotebookInstance_basic (353.41s)
--- PASS: TestAccAWSSagemakerNotebookInstance_tags (393.15s)
--- PASS: TestAccAWSSagemakerNotebookInstance_kms (425.06s)
--- PASS: TestAccAWSSagemakerNotebookInstance_direct_internet_access (686.21s)
--- PASS: TestAccAWSSagemakerNotebookInstance_update (723.22s)
--- PASS: TestAccAWSSagemakerNotebookInstance_root_access (735.50s)
--- PASS: TestAccAWSSagemakerNotebookInstance_volumesize (995.32s)
--- PASS: TestAccAWSSagemakerNotebookInstance_default_code_repository (1007.47s)
--- PASS: TestAccAWSSagemakerNotebookInstance_LifecycleConfigName (1011.45s)

@bflad bflad merged commit 1b5bb59 into hashicorp:master Oct 27, 2020
bflad added a commit that referenced this pull request Oct 27, 2020
@ghost
Copy link

ghost commented Oct 29, 2020

This has been released in version 3.13.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 26, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 26, 2020
@DrFaust92 DrFaust92 deleted the r/sagemaker_notebook_instance_attributes branch April 15, 2021 10:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/sagemaker Issues and PRs that pertain to the sagemaker service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants